Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] gdrom: fix a memory leak bug
To:     Wenwen Wang <wang6495@umn.edu>
Cc:     Maurizio Lombardi <mlombard@redhat.com>,
        zhong jiang <zhongjiang@huawei.com>,
        open list <linux-kernel@vger.kernel.org>
References: <1545876914-11283-1-git-send-email-wang6495@umn.edu>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <f0ef28cb-7f4e-e346-7b88-aaf85ae0b5f5@kernel.dk>
Date:   Sat, 29 Dec 2018 08:21:58 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <1545876914-11283-1-git-send-email-wang6495@umn.edu>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 12/26/18 7:15 PM, Wenwen Wang wrote:
> In probe_gdrom(), the buffer pointed by 'gd.cd_info' is allocated through
> kzalloc() and is used to hold the information of the gdrom device. To
> register and unregister the device, the pointer 'gd.cd_info' is passed to
> the functions register_cdrom() and unregister_cdrom(), respectively.
> However, this buffer is not freed after it is used, which can cause a
> memory leak bug.
> 
> This patch simply frees the buffer 'gd.cd_info' in exit_gdrom() to fix the
> above issue.

Applied, thanks.

-- 
Jens Axboe