Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp9299555imu; Sat, 29 Dec 2018 15:44:51 -0800 (PST) X-Google-Smtp-Source: ALg8bN7tVV4TKRVQTEsj3ufN4ivqR4sHSbvAWRU6zH5u+vWFwP0Gmnboh+qmyGh2ZgFlqGTwBOme X-Received: by 2002:a17:902:4124:: with SMTP id e33mr32368785pld.236.1546127091227; Sat, 29 Dec 2018 15:44:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546127091; cv=none; d=google.com; s=arc-20160816; b=ZDswO02SLad8y7cDgtVn7PL4lv38G05Lb9NAkdKwt8A+7jEEyoBxk/vgu8upQ94k82 h8ifqHnJx0vl674Ey1Vmg1/VOETsUd93CIxwDXTCKLXW79KWOsz3q3rTZ1IgdGPBzce9 PVivsOj2EmgYT/d71YGpRNIIgCgBNdANyuMuaBbVu6QmxkJ6gdqQ9F4w35Ed76SVeebC qq8pZrAF0THiFhHziSCSbYAx6hJJVX78tVZzLhZAir5AD9jd1xk7EeyqMT7UciYZTHv0 y1pgCVgAjKR68sqXlJWLiVhRsX8vwpWutXt7SO5N2TosI3jxd5GS5Z/m3RKbkABptuyr kgkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=YXgP+2V3OYwcKzbAfYm48EKhyG4c8+8j0nmyZduCkbE=; b=LyZCIz7+DFSRwdsZ+X3B/U32xDpk6wv8Y3oUQ9hff7ZJUjXaMFrhyx28fG5xTt5W9h obP6kztMwIottWfJ0l2GkaW1e9RmdS7RDphRqDEBKwH5ya+tCmn8IsUqgFXaMWAwaciT K1EuJc77u+VtoL6QkTlswKXvdIFW/tCDoMZERms501tqmNEGIPhv7X3ULPpjkq6iSIe9 y5faxhq2NeXSmN0LZrlU6hXxixIdnQ130kvlXs/u5xmK4lILWWen01utWTVN0xACFLVU Furq/bNSZp0MQBJZvtSHNfVkq9pK6gcBtvDc7mx7KxecjKXTnUUq0MEKq4Oka2btrVUR lhmg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s84si41028310pgs.306.2018.12.29.15.44.35; Sat, 29 Dec 2018 15:44:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727384AbeL2QlY (ORCPT + 99 others); Sat, 29 Dec 2018 11:41:24 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:45982 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726543AbeL2QlX (ORCPT ); Sat, 29 Dec 2018 11:41:23 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::cf9]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1663C14816515; Sat, 29 Dec 2018 08:41:23 -0800 (PST) Date: Sat, 29 Dec 2018 08:41:20 -0800 (PST) Message-Id: <20181229.084120.1873066963650416921.davem@davemloft.net> To: xuechaojing@huawei.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, wulike1@huawei.com, chiqijun@huawei.com, fy.wang@huawei.com, tony.qu@huawei.com, luoshaokai@huawei.com Subject: Re: =?utf-8?B?562U5aSNOg==?= [PATCH 1/1] net-next/hinic:add shutdown callback From: David Miller In-Reply-To: References: <20181228002040.1256-1-xuechaojing@huawei.com> <20181228.214905.2208487974538707696.davem@davemloft.net> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 29 Dec 2018 08:41:23 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: xuechaojing Date: Sat, 29 Dec 2018 09:20:54 +0000 > Sorry, I didn't explain this patch clearly. > if there is no shutdown callback, our board will report pcie UNF errors after restarting. > Attached is our log. I want you to remove the "dev_info()" call from your patch because it is inappropriate.