Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 29 Dec 2018 12:33:24 -1000
From:   Joey Pabalinas <joeypabalinas@gmail.com>
To:     Willy Tarreau <w@1wt.eu>
Cc:     mingo@kernel.org, paulmck@linux.vnet.ibm.com,
        rdunlap@infradead.org, linux-kernel@vger.kernel.org,
        Joey Pabalinas <joeypabalinas@gmail.com>
Subject: Re: [PATCH 3/4] rcutorture/nolibc: add a bit of documentation to
 explain how to use nolibc
Message-ID: <20181229223324.slqx3qjrmzg5g2w2@gmail.com>
Mail-Followup-To: Joey Pabalinas <joeypabalinas@gmail.com>,
        Willy Tarreau <w@1wt.eu>, mingo@kernel.org,
        paulmck@linux.vnet.ibm.com, rdunlap@infradead.org,
        linux-kernel@vger.kernel.org
References: <20181229180218.15798-1-w@1wt.eu>
 <20181229180218.15798-4-w@1wt.eu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="g4fwmgl6g5tu4vyb"
Content-Disposition: inline
In-Reply-To: <20181229180218.15798-4-w@1wt.eu>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--g4fwmgl6g5tu4vyb
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Dec 29, 2018 at 07:02:18PM +0100, Willy Tarreau wrote:
> + *   - the lower level is the arch-specific syscall() definition, consis=
ting in
> + *     assembly code in compound expressions. These are called my_syscal=
l0() to
> + *     my_syscall6() depending on the number of arguments. The MIPS
> + *     implementation is limited to 5 arguments. All input arguments are=
 cast
> + *     to a long stored in a register. These expressions always return t=
he
> + *     syscall's return value as a signed long value which is often eith=
er a
> + *     pointer or the negated errno value.
> + *
> + *   - the second level is mostly architecture-independent. It is made of
> + *     static functions called sys_<name>() which rely on my_syscallN()
> + *     depending on the syscall definition. These functions are responsi=
ble
> + *     for exposing the appropriate types for the syscall arguments (int,
> + *     pointers, etc) and for setting the appropriate return type (often=
 int).
> + *     A few of them are architecture-specific because the syscalls are =
not all
> + *     mapped exactly the same among architectures. For example, some ar=
chs do
> + *     not implement select() and need pselect6() instead, so the sys_se=
lect()
> + *     function will have to abstract this.
> + *
> + *   - the third level is the libc call definition. It exposes the lower=
 raw
> + *     sys_<name>() calls in a way that looks like what a libc usually d=
oes,
> + *     takes care of specific input values, and of setting errno upon er=
ror.
> + *     There can be minor variations compared to standard libc calls. For
> + *     example the open() call always takes 3 args here.

Shouldn't these sentences begin with a capitalized "The" for
consistency?

>  /* some archs (at least aarch64) don't expose the regular syscalls anymo=
re by
>   * default, either because they have an "_at" replacement, or because th=
ere are
>   * more modern alternatives. For now we'd rather still use them.

Also here. Shouldn't this begin with a capitalized "Some"?

--=20
Cheers,
Joey Pabalinas

--g4fwmgl6g5tu4vyb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEENpTlWU2hUK/KMvHp2rGdfm9DtVIFAlwn9jMACgkQ2rGdfm9D
tVIEFRAAmZU3CLtJRYeYkNoMBa0M28KE6K/cHn1CxONj5MnaYOJDBj8r6yfLBQxB
xbFh8Qn/cQRe2xIojA78ilZFnFKDP3HSd/4Pyy6RzALwdZ1AnxNVvo2InzIvuxXS
/MpJb1g2IGEAdVAMsvoGadbQY6Q64aHB8vJ87MRSh3DqDPu0qiNOXmkCWY0B1nGp
DxugTNz3RLkAN6R7qdh+jl8aFd9wmkW9xM609igStd8rnnO91o+wVc2+GiYdaRjt
k8k2oNfH+E2NOJw5jsJw1dgptM2ub4Pb5aYHsHe8x6KK5u3IZizA2nLSDEjWggQm
Yg2TsjE6ZUEjDJWR+ZfnD968nkV2rW9e0x/6+80CKELJFQvLooeFQwFI6e2NyyeC
MglPa+XAjlFcfVME8h04/UKGhKpDV6+nlAI1ZlUjUqBXc1GNeCXfAym5ggfuIcgr
Y6Os2yQHjAbdkQDwTMCRIywSx0wwqPkHFAzwJ55IoOlkD6kxsIheCeG3/S+/jkJ4
KOSLRKrMYExqsSK2nRBsTYUjNeGdtRcrVqHXlxj4ZnKvO2+eDiq3tqSl+wgSGrFW
/5KFfGgjoOGWVS1eG1Fx1+z/fqcaNdtf4RImi24BC4gc54qbazKlir3SFL9lxMHV
qrREv99+imyVua3mpsTeXf0y1+GJSz7mBPCxApjN1uDeXTPlLzM=
=UXKw
-----END PGP SIGNATURE-----

--g4fwmgl6g5tu4vyb--