Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 30 Dec 2018 10:49:27 +0100
From:   Jacopo Mondi <jacopo@jmondi.org>
To:     Alexey Khoroshilov <khoroshilov@ispras.ru>
Cc:     Mauro Carvalho Chehab <mchehab@kernel.org>,
        Jacopo Mondi <jacopo+renesas@jmondi.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
        ldv-project@linuxtesting.org
Subject: Re: [PATCH] media: tw9910: add missed clk_disable_unprepare() on
 failure path
Message-ID: <20181230094918.6ysahn7tr6us6uoh@uno.localdomain>
References: <1546119320-11841-1-git-send-email-khoroshilov@ispras.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="csa27tseyhrjxlu6"
Content-Disposition: inline
In-Reply-To: <1546119320-11841-1-git-send-email-khoroshilov@ispras.ru>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--csa27tseyhrjxlu6
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline

Hi Alexey,
   thanks for the patch

On Sun, Dec 30, 2018 at 12:35:20AM +0300, Alexey Khoroshilov wrote:
> If gpiod_get_optional() fails in tw9910_power_on(), clk is left undisabled.
>

Correct, thanks for spotting this.

I think pdn_gpio should also be handled if rstb_gpio fails.
What's your opinion?

Thanks
  j

> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
> ---
>  drivers/media/i2c/tw9910.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/media/i2c/tw9910.c b/drivers/media/i2c/tw9910.c
> index a54548cc4285..109770d678d2 100644
> --- a/drivers/media/i2c/tw9910.c
> +++ b/drivers/media/i2c/tw9910.c
> @@ -610,6 +610,7 @@ static int tw9910_power_on(struct tw9910_priv *priv)
>  					     GPIOD_OUT_LOW);
>  	if (IS_ERR(priv->rstb_gpio)) {
>  		dev_info(&client->dev, "Unable to get GPIO \"rstb\"");
> +		clk_disable_unprepare(priv->clk);
>  		return PTR_ERR(priv->rstb_gpio);
>  	}
>
> --
> 2.7.4
>

--csa27tseyhrjxlu6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEtcQ9SICaIIqPWDjAcjQGjxahVjwFAlwolKcACgkQcjQGjxah
VjyYNhAArW3S6a0VKHt1tOqepKIhIZkqkl9SIlfKx0RuP2ir7rN9CQllhhwnqeyH
p+7qzScVydDnk+tmTqXEqf3w0yFpgtCc3qqMjyYNkfBWtbb2O0YQCpcq4hDzHyHK
jeEinxZzUzn5T9eBwMpjEI9wFi+3fjUit4yRSN7O9kdfQRCpYjCHdQEVuqUwuf5w
8OrlMV6VhV3MARQdvbh4JAQ4ldQoUkx7cVRZ7rkL73qRb8pGTuIZAJbHO0A9mZKd
mkc6yjOga9VIBmx54MHHzRBNtMZjtqth05GOvp6oTZ1zMMZ9iGCR93x5f5+rM6+I
C1ep5Ju0KP4MGqzzfsmal2Cfp9Wq6HD0O+D1y3okwkV7YfZ63Fxz4PS3vDecS37J
qBD9eC4TsYBo/WPCCX/Xe0WfTeonpbDD8dMkTSoZ9kbwbbl8F5hzBj4mKOEFcrPc
c20Rea4WMWayE7WHmEKkHiEOwsrAdkGSBMxEmzb7rD48rCv5rXPISbTQXESKRFsM
c6egrbU2Blgl0pnh9RJjygjnpgARzPyLiPuy+CtAs8vH3Qd8+LHGadxkvqZ+1y6U
EZYkdF56iYTKq6SJDf5/OFJnKZi9++5dYrbgH7iZR19IPF1ZJblOgdmNKHeZQgRY
0UM3MbsiTNH421Uipf8Qf5AjS5G9MB5EQsCICYMBJ/HAP8XzZNE=
=xxg+
-----END PGP SIGNATURE-----

--csa27tseyhrjxlu6--