Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20181228153759.3132-1-ubizjak@gmail.com>
References: <20181228153759.3132-1-ubizjak@gmail.com>
From:   Uros Bizjak <ubizjak@gmail.com>
Date:   Sun, 30 Dec 2018 12:07:13 +0100
Message-ID: <CAFULd4apcgrNMNhkX-NsdRSi3KyHg+z+eZtdbeXAj6RYPeM7Zg@mail.gmail.com>
Subject: Re: [PATCH] x86/asm: Use CC_SET/CC_OUT in percpu_cmpxchg16b_double
To:     linux-kernel@vger.kernel.org
Cc:     Uros Bizjak <ubizjak@gmail.com>, x86@kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 12/28/18, Uros Bizjak <ubizjak@gmail.com> wrote:
> Use CC_SET(z)/CC_OUT(z) instead of explicit setz instruction.
> Using these two defines, the compiler that supports generation of
> condition code outputs from inline assembly flags generates one
> conditional jump instruction, e.g:

Unfortunatelly, the 0day kernel test robot reports:

[    1.569154] DEBUG_LOCKS_WARN_ON(unlikely(early_boot_irqs_disabled))
[    1.569287] WARNING: CPU: 0 PID: 0 at kernel/locking/lockdep.c:2803
lockdep_hardirqs_on+0xc5/0x19e

presumably due to unconditional interrupt enable in
this_cpu_cmpxchg16b_emu. I have to somehow disable X86_FATURE_CX16 and
thoroughly test the library path.

Uros.