Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181226185623.9324-1-pakki001@umn.edu>
In-Reply-To: <20181226185623.9324-1-pakki001@umn.edu>
From:   Devesh Sharma <devesh.sharma@broadcom.com>
Date:   Mon, 31 Dec 2018 11:39:32 +0530
Message-ID: <CANjDDBgEFGe3DMUvP_K7zzuqA8i0RosLwX_iRHBMxAEBx3crXg@mail.gmail.com>
Subject: Re: [PATCH] infiniband: bnxt_re: qplib: Check the return value of send_message
To:     Aditya Pakki <pakki001@umn.edu>
Cc:     kjlu@umn.edu, Selvin Xavier <selvin.xavier@broadcom.com>,
        Somnath Kotur <somnath.kotur@broadcom.com>,
        Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>,
        Doug Ledford <dledford@redhat.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        linux-rdma <linux-rdma@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Dec 27, 2018 at 12:26 AM Aditya Pakki <pakki001@umn.edu> wrote:
>
> In bnxt_qplib_map_tc2cos(), bnxt_qplib_rcfw_send_message() can return
> an error value. The fix returns the error from the latter function
> upstream.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> ---
>  drivers/infiniband/hw/bnxt_re/qplib_sp.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/hw/bnxt_re/qplib_sp.c b/drivers/infiniband/hw/bnxt_re/qplib_sp.c
> index 5216b5f844cc..adb8eae5193c 100644
> --- a/drivers/infiniband/hw/bnxt_re/qplib_sp.c
> +++ b/drivers/infiniband/hw/bnxt_re/qplib_sp.c
> @@ -778,9 +778,8 @@ int bnxt_qplib_map_tc2cos(struct bnxt_qplib_res *res, u16 *cids)
>         req.cos0 = cpu_to_le16(cids[0]);
>         req.cos1 = cpu_to_le16(cids[1]);
>
> -       bnxt_qplib_rcfw_send_message(rcfw, (void *)&req, (void *)&resp, NULL,
> -                                    0);
> -       return 0;
> +       return bnxt_qplib_rcfw_send_message(rcfw, (void *)&req, (void *)&resp,
> +                                               NULL, 0);
>  }
>
>  int bnxt_qplib_get_roce_stats(struct bnxt_qplib_rcfw *rcfw,
> --
> 2.17.1
>

Acked-By: Devesh Sharma <devesh.sharma@broadcom.com>