Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH] Revert "staging:r8188eu: use lib80211 CCMP decrypt"
To:     Michael Straube <straube.linux@gmail.com>,
        gregkh@linuxfoundation.org
Cc:     insafonov@gmail.com, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
References: <20181230183918.3888-1-straube.linux@gmail.com>
Message-ID: <efbc3a4a-ce31-8785-73c0-3d89edc66977@lwfinger.net>
Date:   Mon, 31 Dec 2018 20:17:33 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.3
MIME-Version: 1.0
In-Reply-To: <20181230183918.3888-1-straube.linux@gmail.com>
Content-Type: multipart/mixed;
 boundary="------------C1422955F8BE8DEFEB2CF955"
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

This is a multi-part message in MIME format.
--------------C1422955F8BE8DEFEB2CF955
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

On 12/30/18 12:39 PM, Michael Straube wrote:
> Commit 6bd082af7e36 ("staging:r8188eu: use lib80211 CCMP decrypt")
> is causing hardfreeze whenever the driver tries to connect to my wifi
> network. That makes the driver unusable on my system. Reverting the
> commit fixes the issue and the driver works properly.
> 
> Dec 29 19:21:17 gentoo kernel: BUG: scheduling while atomic: swapper/6/0/0x00000100

Michael,

I have verified the freezes that you see. Although I have not been able to 
capture the console dump, I think we are likely seeing the same problem.

I do have a work-around in that I have not gotten any freezes when I force 
module lib80211_crypt_ccmp to be loaded before I load module r8188eu. This clue 
was used in finding what seems to be a good fix.

I do not know anything about demand loading of modules using 
try_then_request_module(); however, I noticed that the macro actually calls 
__request_module(), which has the following comment:

  * Load a module using the user mode module loader. The function returns
  * zero on success or a negative errno code or positive exit code from
  * "modprobe" on failure. Note that a successful module load does not mean
  * the module did not then unload and exit on an error of its own. Callers
  * must check that the service they requested is now available not blindly
  * invoke it.

I note that it says "user mode module loader". Routine rtw_aes_decrypt() is 
likely inside some sort of locking, which leads to the "scheduling while atomic" 
bug that you see. As a result, I suspect that the module is not loaded, and that 
leads to the NULL dereference when the module is accessed. Please try the 
one-line patch attached, which forces lib80211 to load when r8188eu is loaded. 
With this patch, I have been connected to an AES-encrypted AP for nearly 3 hours 
with no problems.

Larry


--------------C1422955F8BE8DEFEB2CF955
Content-Type: text/plain; charset=UTF-8;
 name="patch_8188eu"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="patch_8188eu"

ZGlmZiAtLWdpdCBhL2RyaXZlcnMvc3RhZ2luZy9ydGw4MTg4ZXUvY29yZS9ydHdfc2VjdXJp
dHkuYyBiL2RyaXZlcnMvc3RhZ2luZy9ydGw4MTg4ZXUvY29yZS9ydHdfc2VjdXJpdHkuYwpp
bmRleCBmNzQwNzYzMmU4MGIuLjA1MjY1NmEyMjgyMSAxMDA2NDQKLS0tIGEvZHJpdmVycy9z
dGFnaW5nL3J0bDgxODhldS9jb3JlL3J0d19zZWN1cml0eS5jCisrKyBiL2RyaXZlcnMvc3Rh
Z2luZy9ydGw4MTg4ZXUvY29yZS9ydHdfc2VjdXJpdHkuYwpAQCAtMTI5MSw3ICsxMjkxLDcg
QEAgdTMyIHJ0d19hZXNfZGVjcnlwdChzdHJ1Y3QgYWRhcHRlciAqcGFkYXB0ZXIsIHU4ICpw
cmVjdmZyYW1lKQogCQkJc3RydWN0IHNrX2J1ZmYgKnNrYiA9ICgoc3RydWN0IHJlY3ZfZnJh
bWUgKilwcmVjdmZyYW1lKS0+cGt0OwogCQkJdm9pZCAqY3J5cHRvX3ByaXZhdGUgPSBOVUxM
OwogCQkJdTggKmtleSwgKnBmcmFtZSA9IHNrYi0+ZGF0YTsKLQkJCXN0cnVjdCBsaWI4MDIx
MV9jcnlwdG9fb3BzICpjcnlwdG9fb3BzID0gdHJ5X3RoZW5fcmVxdWVzdF9tb2R1bGUobGli
ODAyMTFfZ2V0X2NyeXB0b19vcHMoIkNDTVAiKSwgImxpYjgwMjExX2NyeXB0X2NjbXAiKTsK
KwkJCXN0cnVjdCBsaWI4MDIxMV9jcnlwdG9fb3BzICpjcnlwdG9fb3BzID0gbGliODAyMTFf
Z2V0X2NyeXB0b19vcHMoIkNDTVAiKTsKIAkJCXN0cnVjdCBzZWN1cml0eV9wcml2ICpwc2Vj
dXJpdHlwcml2ID0gJnBhZGFwdGVyLT5zZWN1cml0eXByaXY7CiAJCQljaGFyIGl2WzhdLCBp
Y3ZbOF07CiAK
--------------C1422955F8BE8DEFEB2CF955--