Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Subject: Re: [PATCH] tty/n_hdlc: fix sleep in !TASK_RUNNING state warning
From:   Paul Fulghum <paulkf@microgate.com>
In-Reply-To: <49b3b189-a51f-6a97-0e1f-bc3f2c305299@I-love.SAKURA.ne.jp>
Date:   Mon, 31 Dec 2018 19:13:34 -0800
Cc:     Arnd Bergmann <arnd@arndb.de>, Alan Cox <alan@lxorguk.ukuu.org.uk>,
        syzbot <syzbot+c244af085a0159d22879@syzkaller.appspotmail.com>,
        gregkh@linuxfoundation.org, jslaby@suse.com,
        linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com
Content-Transfer-Encoding: quoted-printable
Message-Id: <62FAC6A3-AC41-44CD-8ABC-79F404BF8CB1@microgate.com>
References: <000000000000449587057e1e6f8b@google.com>
 <49b3b189-a51f-6a97-0e1f-bc3f2c305299@I-love.SAKURA.ne.jp>
To:     Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On Dec 31, 2018, at 7:11 PM, Paul Fulghum <paulkf@microgate.com> wrote:

NAK to this patch. It causes lost wakeups in both read and write paths.

The write path does not need changing.

The read path can be fixed by setting current to TASK_RUNNING at the top =
of the if (rbuf) block so the warning is not triggered by =
copy_to_user(). If this block runs the condition is satisfied and it =
breaks out of the polling loop where it is already being set to =
TASK_RUNNING and removed from the wait queue. This particular path just =
needs to account for the copy_to_user which occurs before breaking out.

I=E2=80=99ll make a patch to do this when I have the ability to test it =
in a day or two.


> On Dec 29, 2018, at 3:48 AM, Tetsuo Handa =
<penguin-kernel@I-love.SAKURA.ne.jp> wrote:
>=20
> syzbot is hitting __might_sleep() warning [1], for commit =
1035b63d3c6fc34a
> ("n_hdlc: fix read and write locking") changed to set =
TASK_INTERRUPTIBLE
> state before calling copy_to_user(). Let's set TASK_INTERRUPTIBLE =
state
> immediately before calling schedule().
>=20
> [1] =
https://syzkaller.appspot.com/bug?id=3D17d5de7f1fcab794cb8c40032f893f52de8=
99324
>=20
> Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
> Reported-by: syzbot =
<syzbot+c244af085a0159d22879@syzkaller.appspotmail.com>
> Cc: Paul Fulghum <paulkf@microgate.com>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> ---
> drivers/tty/n_hdlc.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/tty/n_hdlc.c b/drivers/tty/n_hdlc.c
> index dabb391..7835489 100644
> --- a/drivers/tty/n_hdlc.c
> +++ b/drivers/tty/n_hdlc.c
> @@ -589,8 +589,6 @@ static ssize_t n_hdlc_tty_read(struct tty_struct =
*tty, struct file *file,
> 		if (tty_hung_up_p(file))
> 			break;
>=20
> -		set_current_state(TASK_INTERRUPTIBLE);
> -
> 		rbuf =3D n_hdlc_buf_get(&n_hdlc->rx_buf_list);
> 		if (rbuf) {
> 			if (rbuf->count > nr) {
> @@ -617,6 +615,7 @@ static ssize_t n_hdlc_tty_read(struct tty_struct =
*tty, struct file *file,
> 			break;
> 		}
>=20
> +		set_current_state(TASK_INTERRUPTIBLE);
> 		schedule();
>=20
> 		if (signal_pending(current)) {
> @@ -673,8 +672,6 @@ static ssize_t n_hdlc_tty_write(struct tty_struct =
*tty, struct file *file,
> 	add_wait_queue(&tty->write_wait, &wait);
>=20
> 	for (;;) {
> -		set_current_state(TASK_INTERRUPTIBLE);
> -=09
> 		tbuf =3D n_hdlc_buf_get(&n_hdlc->tx_free_buf_list);
> 		if (tbuf)
> 			break;
> @@ -683,6 +680,8 @@ static ssize_t n_hdlc_tty_write(struct tty_struct =
*tty, struct file *file,
> 			error =3D -EAGAIN;
> 			break;
> 		}
> +
> +		set_current_state(TASK_INTERRUPTIBLE);
> 		schedule();
> 		=09
> 		n_hdlc =3D tty2n_hdlc (tty);
> --=20
> 1.8.3.1
>=20
>=20

--
Paul Fulghum
MicroGate Systems, Ltd.
=3DCustomer Driven, by Design=3D
(512) 345-7791 x102 (Voice)
(512) 343-9046 (Fax)
Central Time Zone (GMT -5h)
www.microgate.com