Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Subject: [PATCH] tty/n_hdlc: fix __might_sleep warning
From:   Paul Fulghum <paulkf@microgate.com>
In-Reply-To: <62FAC6A3-AC41-44CD-8ABC-79F404BF8CB1@microgate.com>
Date:   Tue, 1 Jan 2019 12:28:53 -0800
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
        Arnd Bergmann <arnd@arndb.de>,
        Alan Cox <alan@lxorguk.ukuu.org.uk>,
        syzbot <syzbot+c244af085a0159d22879@syzkaller.appspotmail.com>,
        jslaby@suse.com, syzkaller-bugs@googlegroups.com
Content-Transfer-Encoding: quoted-printable
Message-Id: <F23DE81F-C976-4AED-8990-84A6ADC1BF1F@microgate.com>
References: <000000000000449587057e1e6f8b@google.com>
 <49b3b189-a51f-6a97-0e1f-bc3f2c305299@I-love.SAKURA.ne.jp>
 <62FAC6A3-AC41-44CD-8ABC-79F404BF8CB1@microgate.com>
To:     "linux-kernel@vger.kernel.org Mailing List" 
        <linux-kernel@vger.kernel.org>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Fix __might_sleep warning in tty/n_hdlc.c read due to copy_to_user call =
while current is TASK_INTERRUPTIBLE.
This is a false positive since the code path does not depend on current =
state remaining TASK_INTERRUPTIBLE.
The loop breaks out and sets TASK_RUNNING after calling copy_to_user.=20
This patch supresses the warning by setting TASK_RUNNING before calling =
copy_to_user.

[1] =
https://syzkaller.appspot.com/bug?id=3D17d5de7f1fcab794cb8c40032f893f52de8=
99324

Signed-off-by: Paul Fulghum <paulkf@microgate.com>
Reported-by: syzbot =
<syzbot+c244af085a0159d22879@syzkaller.appspotmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
=E2=80=94
--- a/drivers/tty/n_hdlc.c	2018-12-23 15:55:59.000000000 -0800
+++ b/drivers/tty/n_hdlc.c	2019-01-01 11:44:47.148153954 -0800
@@ -597,6 +597,7 @@ static ssize_t n_hdlc_tty_read(struct tt
 				/* too large for caller's buffer */
 				ret =3D -EOVERFLOW;
 			} else {
+				__set_current_state(TASK_RUNNING);
 				if (copy_to_user(buf, rbuf->buf, =
rbuf->count))
 					ret =3D -EFAULT;
 				else

=20=