Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] Revert "staging:r8188eu: use lib80211 CCMP decrypt"
To:     Michael Straube <straube.linux@gmail.com>,
        gregkh@linuxfoundation.org
Cc:     insafonov@gmail.com, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
References: <20181230183918.3888-1-straube.linux@gmail.com>
 <efbc3a4a-ce31-8785-73c0-3d89edc66977@lwfinger.net>
 <59368aca-c3d9-0563-aa83-118842834fb1@gmail.com>
From:   Larry Finger <Larry.Finger@lwfinger.net>
Message-ID: <2aab932b-b4ba-2601-06de-ca095a549fb7@lwfinger.net>
Date:   Tue, 1 Jan 2019 19:06:20 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.3
MIME-Version: 1.0
In-Reply-To: <59368aca-c3d9-0563-aa83-118842834fb1@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 1/1/19 1:31 PM, Michael Straube wrote:
> 
> I've tested your patch and it solved the issue. No freezes and dmesg looks good.
> 
> I noticed that try_then_request_module() is also used in rtw_wep_encrypt() and
> rtw_wep_decrypt(). I guess that also could cause problems?

Yes, I believe it would if anyone is still using WEP. My plan is to get rid of 
the try_then_request_module() there as well, and for completeness, I plan to 
restore usage of the lib80211 routines for TKIP as well.

Once I get a chance to test the TKIP and WEP changes, I plan to have a set of 4 
patches to switch the driver to using lib80211 routines for all 
decryption/encryption.

Larry