Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp12379052imu; Tue, 1 Jan 2019 22:24:47 -0800 (PST) X-Google-Smtp-Source: ALg8bN5rel6mrDbsPF/+UwB1gz1dINrH8tq9i0J99/rxSs7KD5sd+Nj1LKSgS34W4QjixXqhk2lH X-Received: by 2002:a17:902:14b:: with SMTP id 69mr42900719plb.52.1546410287004; Tue, 01 Jan 2019 22:24:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546410286; cv=none; d=google.com; s=arc-20160816; b=bR0cKoOkax0nDgoUo5Yex9BI/sUMO1bQTOrt3A9STE7q9r8/G12oFPdyCZR5SavwHb wJNFr4BYQQbZlKsdsuYHHCYEdKpqc0voY17/+uBPypAd7/Kx2r1BDTiy6kRnyEFUTER9 wU0eHVvqzZlCR9ag++0F7Hvp0Itrb42po7uP/IKvi1umTYSp+0kYdDGms4Ll2ZNPc9oA JeeUafqdvHQWzNG6u/YOPYKDjn0ZNSyC4XP6nsVg+XXeLj6af5Zb9DV1p0RG2uZwkQXU 42AIkqbaNzr2VjpHm1OPiLem5WJVAGQYbJH8hCKN6IkzVFZRCnOUpVWW2BSc7kS8/KXV fAsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=vLX9PiY8ElTNKZD6uSxj3ayS2VsCFFw+CYNghqS4+KI=; b=MoNcHkY46cxUJRZwA1LoGyAVShqs6OUi28tg0Sb+ZTpOd6JPn+oMZXyyRSC/j3BPMg QykMLOxLEXCKjRIiuApGYDZpql2/fi0O/kPnhsNDvv2SCSkHVUGy6Qd6AnmGdywp7x2R TKy2lj+00bB5/C+j7u/Cvn2ffhyDdwcibkzg9KOk7FhC6qWoP6AehmlSDKu9RebZEs6n sX5QgkWEkHmMHajn7e/lU94Ao7JkVNsfBO0txZibVub3KRovr+lp3rrwyKh6CCGI1nAH S//8V50nKBX7B436b+U3T9FR61n54Qka4Q4YfSXb2moIweMz8BR0VeRENs27N6ssJHdr z58A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TtCXeome; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q9si49953618pgi.89.2019.01.01.22.24.32; Tue, 01 Jan 2019 22:24:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=TtCXeome; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728547AbfABGFF (ORCPT + 99 others); Wed, 2 Jan 2019 01:05:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:58732 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727836AbfABGFF (ORCPT ); Wed, 2 Jan 2019 01:05:05 -0500 Received: from localhost (unknown [171.76.109.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BC3562089F; Wed, 2 Jan 2019 06:05:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546409104; bh=i5+Tzid5nPl2ZrJEsOWzT6avBy4GUJPyiNvxAmFr/iU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=TtCXeomeLfZ/nFgLpI+5ZG5wDuH0ANAj51T8Ku/Vfjfg+xf4fbkN5Ec7wwxbgoUIZ d24cPUdA07PPx/yxeNm5+Gm7MQyeNm3VWxNq9Og8HSq12Dzv4b44U7jv/LnuwX9OeO 7tQ6DXUFWswTz7K33MXNF5TDMg0ikcpg8D0q9UAc= Date: Wed, 2 Jan 2019 11:33:24 +0530 From: Vinod Koul To: Julia Lawall Cc: Viresh Kumar , kernel-janitors@vger.kernel.org, Andy Shevchenko , Dan Williams , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/20] dmaengine: dw: drop useless LIST_HEAD Message-ID: <20190102060324.GF7581@vkoul-mobl> References: <1545555435-24576-1-git-send-email-Julia.Lawall@lip6.fr> <1545555435-24576-13-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1545555435-24576-13-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23-12-18, 09:57, Julia Lawall wrote: > Drop LIST_HEAD where the variable it declares is never used. > > Commit ab703f818ac3 ("dmaengine: dw: lazy allocation of dma > descriptors") removed the uses, but not the declaration. > > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > identifier x; > @@ > - LIST_HEAD(x); > ... when != x > // Applied, thanks -- ~Vinod