Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp12380095imu; Tue, 1 Jan 2019 22:26:27 -0800 (PST) X-Google-Smtp-Source: ALg8bN79wi268p8LKLE4rlZVAcG1payQANMjY4EGJNqxQyfeI0FgFelfTqp01d7bnCsDRQjv5E9U X-Received: by 2002:a17:902:8d94:: with SMTP id v20mr7900656plo.194.1546410387704; Tue, 01 Jan 2019 22:26:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546410387; cv=none; d=google.com; s=arc-20160816; b=EERlDOkEG5B+PpNMY/gPL1QlOaassfHqdIv6CBJOuXrPPeD6R9zKjS9/o3vLpzLDdb I7dUMmKFd0FMs3Q6aBltMHQLQc8KNiaU+qVm0LDECn0htwQGmKOLjbj6rLutA0vVJ/Zw CGW+mwj2J+WErpxEQFUyn+y3V6W1zYIpmmMayuA+Yyp37nm4SdQEAaxWlLqKMo0/0rBY Ow4BBaTsNQq4tcJyHu4cvvHcOuj+IZlCDgr10H7BBcIRarGC29Ajz9Ds+Y5OalIE6xyb AtSnitNZfx7hlUYp+0XvAheoViTAb6EUWFGp7iY31vieWfxq4aP7wSND77jqB4JdTErf K7MA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=rAD5My1QaZg8iSnos9a1TclTrMmPgXLhcLKotpYNTWw=; b=lpBX8L+DQANqbgC0IpJ08q89bAS0mEWTDLxAUg/3mBVrVFeFXBxbcizavT12Pbg+2D BbOJ5ginsmVXwFzqSkNotd+mropWS0EQ20p9cDMOcHw1IAsoIw4fVT0eFIZMDQPWQ1uG wo2jjpsrxeMMcCluRw8xiucwDx0AzOc29/MfE2wrGOpDqLU0sJvw53iURmCmHG4aN55i ifGRLIpilxknZ3bvS0ENzDNJscIlWhEZdEL2MtxpwANHCjWauODuW4/iN2uOVk9eva2E IDOuwQX9jbq5UtuH+RtKxglWue2Di4a84+fEr4iEg/ypBhBjBCHg9M6LMPjhqsKYKBth K6eQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yeGig9o1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z22si11766092plo.202.2019.01.01.22.26.12; Tue, 01 Jan 2019 22:26:27 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yeGig9o1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728627AbfABGFn (ORCPT + 99 others); Wed, 2 Jan 2019 01:05:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:58888 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728595AbfABGFn (ORCPT ); Wed, 2 Jan 2019 01:05:43 -0500 Received: from localhost (unknown [171.76.109.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3841A2089F; Wed, 2 Jan 2019 06:05:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546409142; bh=YaTXbsrBGf3P8LzK7jPQ7RjSDxK4wJpAMlNsCAVrALQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yeGig9o1f/a0/91Zm41UkI8/lOnZswNGJ74GWg379xSC5zG3iZD04jR1dQFjjDl3J 7M7Eacqp9+hcni3LCRfbIkBGrU7VuzksuKqEhjaQS3whbrpNIX2VRM17e7xZhJRJNP gZwR0kk3leeyyhHnszqUyfQJ3/Fi/EFrpQ5CSImo= Date: Wed, 2 Jan 2019 11:34:04 +0530 From: Vinod Koul To: Julia Lawall Cc: Dan Williams , kernel-janitors@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 17/20] dmaengine: pl330: drop useless LIST_HEAD Message-ID: <20190102060404.GH7581@vkoul-mobl> References: <1545555435-24576-1-git-send-email-Julia.Lawall@lip6.fr> <1545555435-24576-18-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1545555435-24576-18-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23-12-18, 09:57, Julia Lawall wrote: > Drop LIST_HEAD where the variable it declares is never used. > > The variable has not been used since the function was introduced > in 740aa95703c5 ("dmaengine: pl330: Split device_control"). > > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > identifier x; > @@ > - LIST_HEAD(x); > ... when != x > // Applied, thanks -- ~Vinod