Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp12380104imu; Tue, 1 Jan 2019 22:26:29 -0800 (PST) X-Google-Smtp-Source: ALg8bN5NdbL3yWBpug+rbofWOEjPu/C7Ku68gpL0jvu1KfbMbkypH1A1f15peQLvUcktpRPKInUo X-Received: by 2002:a17:902:f082:: with SMTP id go2mr42416597plb.115.1546410388950; Tue, 01 Jan 2019 22:26:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546410388; cv=none; d=google.com; s=arc-20160816; b=S0csAJIqYyRhDxXCXIwOw84vLJQKJJj4uqvEYnxUVqh8FXAhHNHCoV80wYpx6btb3U qPeKfjKOZrhocQhtf0VYDY/v13njxj2WOgvte8tf/73n8QGfrzbkLJMGPKB79D0XUCWb xdR5eAhPU4msGorjjB8z2L62WnBF9zpnFcN1PGVT9rkXrobiQ2dGtFvIKFi3L0xFKGKn PhvfS2piLtdlgZ/Fq85FJ5GW2tFjYqtcXkkoEenOVLDh0FRudvBvCHReZZWCczUaMrP+ Ir55jp51eb+HrYfe1mfSDj0fF9j4s5AZbyBWdSOIt4AXt8XkozM5qRKJ2vZwrNeTqTSq UWbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=fBMyCbcIIZYCAftfkpWSZUFr1bv4B5/vT88ziqjh/RE=; b=PztUmIJcUh3Q/o7iSCdRi+g8eL/8NIQemZSvSaL7mdgrQKCbMyFj7umOVnLac25yQJ XuP7PERDUpCS/ilemvI7cK9QOEIPV05ULo2CMGZCLWxj9tQwOdXkOLf1IHXgJo3Aktam YOJBllQxZBChL/LZZdgSH0Oo1rt1ELQYMlynGzjb7+ALDN0j3Le35fxzZdr7tqo2Vdpp RS6xAEiEz0ZB2Gj2lvqx+lojUt0zNmbJ4Ogg2x/5ER9Z68BxAPNGYSr1o4ub8sAzhSzs R9K1chy+bG5bS2uySrVOADqoW/PCia1sjhz94SkxSrgxamL1QsG2DI1IgMd6spynS18v qniQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fGQ9hDfo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l66si5989237pga.151.2019.01.01.22.26.14; Tue, 01 Jan 2019 22:26:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fGQ9hDfo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728673AbfABGG3 (ORCPT + 99 others); Wed, 2 Jan 2019 01:06:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:59100 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726344AbfABGG3 (ORCPT ); Wed, 2 Jan 2019 01:06:29 -0500 Received: from localhost (unknown [171.76.109.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D259B2089F; Wed, 2 Jan 2019 06:06:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546409188; bh=BQ93DFbzP2Zxm/ldqKxh03ATtrSskB7FLnZGi8tJDKo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fGQ9hDfo/MinpeN0p5GzH2XvT7WjiBpURRQ0mFs5XruVdLUYDRxkYwHGW7xaWkkDf ZfTkFqTiNvI1v+DHEBbb/L5Kon75EbEEnnpuT4EjIfx9ysL/YBsAIuFGMay/+VK4jA Aj3U/J8aynf20oN1yZ6/LM4T+Mna1/0ICZqZOnu0= Date: Wed, 2 Jan 2019 11:34:55 +0530 From: Vinod Koul To: Julia Lawall Cc: Ludovic Desroches , kernel-janitors@vger.kernel.org, Dan Williams , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/20] dmaengine: at_hdmac: drop useless LIST_HEAD Message-ID: <20190102060455.GJ7581@vkoul-mobl> References: <1545555435-24576-1-git-send-email-Julia.Lawall@lip6.fr> <1545555435-24576-8-git-send-email-Julia.Lawall@lip6.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1545555435-24576-8-git-send-email-Julia.Lawall@lip6.fr> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23-12-18, 09:57, Julia Lawall wrote: > Drop LIST_HEAD where the variable it declares is never used. > > tmp_list has been declared since the introduction of the driver > and has never been used. The two declarations of list were > introduced with the containing functions but were also not used. > > The semantic patch that fixes this problem is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > identifier x; > @@ > - LIST_HEAD(x); > ... when != x > // Applied with Ludovic's ack, thanks -- ~Vinod