Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp12399276imu; Tue, 1 Jan 2019 23:00:21 -0800 (PST) X-Google-Smtp-Source: ALg8bN7hYyXeQ51eYqvMc2utkjgzuhhFyGIKsV3v2s7yw+jyzdyvmu5ddNOpy2RLg7+TToTBvPPZ X-Received: by 2002:a17:902:1105:: with SMTP id d5mr40954232pla.47.1546412421931; Tue, 01 Jan 2019 23:00:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546412421; cv=none; d=google.com; s=arc-20160816; b=Ydc/CnuSBXlQuE++qZ3q5Yf22YsC9C59Wgeg6cPYkwY0XUug1Ly8tzMFRaUCSng7Eg RBwXTEWQGpa3U+zgRGpQpnJuTjbMdR7h1yYxN19VJhwSk6Bnu0MCq30otD4JfwEBUmLJ 0CDvGolIx33j+pRVJ65/3yDnHUEfkRcEzw5KlYTi9h8zJo1It234LHQNRdso61zK8Nns gB+wCKQjLAE6mUk2itdxnHwjVdLeme2lZPRufk5ja7/lCCN9mdkq0XJHDtN2zXWRqeWr QJ1PMYNxStMQ67JGukHf9gVZzNC7A/Llb3qjQiWqdUWGl9KJ6Ri/7av4PupQe61tIP7G 5OAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=kfawNhuZ/w4KEAr+kf8s60daFKF0kR6UTSTXwZtFi04=; b=wXjc7neEl980fLxZxitTrdUM23ixIwJUB7t9om3seWBaPdowjwQ6PypWCoRlsQ+Rjg lPd3eg2KRr6afhI4bGdIw7X8cRpPHqgiUQl4EQuJU7+Mj4jkBjXy4/735+Oa4PCDgEDc /V+y0v2qBPxZYp8cmEyppvkDTZihuaB5CGMvkcjYqjFsUx5CKR7oFe3SYOJtfjR97e61 IqBBKFibqFF2YeuyRx3Pk9qxXZyC4cPqe7ztyJLy1BuSgTUvb5Fd8wQl0FB+T3tpurLX wtId5quqHRu9dlAA2WWdRqHzSs0ZnYDW6Vbwu6Xr8zmcqQgQeduICwUTv3Jmu1DX5TmI zKPw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g26si2052950pfe.127.2019.01.01.23.00.05; Tue, 01 Jan 2019 23:00:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728457AbfABG0J (ORCPT + 99 others); Wed, 2 Jan 2019 01:26:09 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:55771 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728184AbfABG0J (ORCPT ); Wed, 2 Jan 2019 01:26:09 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id EF04A8D10666C; Wed, 2 Jan 2019 14:26:03 +0800 (CST) Received: from huawei.com (10.175.104.208) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.408.0; Wed, 2 Jan 2019 14:25:57 +0800 From: liujian To: CC: , , Subject: [PATCH] driver: uio: fix possible memory leak in uio_open Date: Thu, 3 Jan 2019 00:26:56 +0800 Message-ID: <1546446416-40831-1-git-send-email-liujian56@huawei.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.104.208] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes: 57c5f4df0a5a ("uio: fix crash after the device is unregistered") Signed-off-by: liujian --- drivers/uio/uio.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c index 5c10fc7..bde7d7a 100644 --- a/drivers/uio/uio.c +++ b/drivers/uio/uio.c @@ -496,7 +496,7 @@ static int uio_open(struct inode *inode, struct file *filep) if (!idev->info) { mutex_unlock(&idev->info_lock); ret = -EINVAL; - goto err_alloc_listener; + goto err_infoopen; } if (idev->info && idev->info->open) @@ -508,6 +508,7 @@ static int uio_open(struct inode *inode, struct file *filep) return 0; err_infoopen: + filep->private_data = NULL; kfree(listener); err_alloc_listener: -- 2.7.4