Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp12411464imu; Tue, 1 Jan 2019 23:18:26 -0800 (PST) X-Google-Smtp-Source: ALg8bN4wFKE/WmBFdRJVaHKnJlGeV4+T5gw0Gyi/LWzK2fObz+84EQn5VozhIg4X/YDvUBe/5jDg X-Received: by 2002:a17:902:2b84:: with SMTP id l4mr42627100plb.191.1546413506898; Tue, 01 Jan 2019 23:18:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546413506; cv=none; d=google.com; s=arc-20160816; b=RHz1KpWvWoI4TpOliXoJPY14OBe8m5dAlQozW6m3gUuUvs77FCcjIWkhDzM4eZU+HA Bfrq3ZNU4TtMPcTT4l1lrcdDsfnSeV8PdFyqfe2PGzlRoPkprpihcA1py2BU4fGyJ+9u eK21jnRlWcCRcWyr7v5OtxkcSe0N7NzOEhI10/O9qJCUZjXcr1do8hZyScwjvxMwTixx N+Je/1a/rP9H1uN4URL8Ryqczx0cqvlIh321oSLmiFIouhIMR+glNAz1Xyo04Wi/M8+o L+gHF/r/K/KwR8Bvv/QfVDTFDUss2XgXMvXuLPZEANh5iKSXNCRsQivQfM2RgHfcFjPb cu4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject; bh=m9iR2SOM420EUv2hrKb1+JFrDnTPWx/4zhkA7rcoedM=; b=gmMpMtUMTK+KddIe5WfgbA3LFMhvi+SdXl4hVoSMi9MAo0fyMchOsKVYw7n4C+UuMk RCAZEwkjNEsUatkI7l8fw6XHqotrP2hK0t/l79cvl8E2Hp8eWBBj9Pe+OwbVLVrHQdDG 4swpWYBnLHRiJO/4bsauPs+vtBIuLkI4+Ez6whz8ORkuYZXbRmrvwhyLRPKLiOeRSVnW 8lRpmu3XIq1DXNLz9KBrqu12uufnXziwuDGjJpuxtSs3UzkTDEFDI6ql6QTLYTEKYsVb 06rKLoFFGCYMc5jwNWNs5W3/KVYOLnIr3faUvHR1vLs3knTVDghpoucrKOn6BS73hWrX khRg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k189si910079pgd.589.2019.01.01.23.17.59; Tue, 01 Jan 2019 23:18:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728771AbfABGsr (ORCPT + 99 others); Wed, 2 Jan 2019 01:48:47 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:44383 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727558AbfABGsr (ORCPT ); Wed, 2 Jan 2019 01:48:47 -0500 Received: by mail-wr1-f67.google.com with SMTP id z5so29481863wrt.11 for ; Tue, 01 Jan 2019 22:48:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=m9iR2SOM420EUv2hrKb1+JFrDnTPWx/4zhkA7rcoedM=; b=tzIEe8h2KjxbSGIzF/4aB/E8eN57R78UPFvTKzUOv/GwxDOo+vrWlEhw5532GIc5Dw optKarBZpi8zLtWbfyJIPtABgdUfA7Tk8WeogxcWkNPRn6I3xUVj/w226OzaivkVPJdF lV3wJP9yOGLQbmx6gR7kXYTL3bjLCNiKKGHZxCYN5GdD0evUaZdSTVHkxUzv0+h+wLyj Wg2FCnrgoh1xerMLPboBbtxfPTXJVm7+HBllt6QI6AUQlVnKSPi12XSinH+73Sfs6D2M +xFPfumHdWQAHkb0nIm4+WInl9ccxrcKFUQtPWMNM0CljRrA+uKthjcbxEnDTl65pKV7 1jmw== X-Gm-Message-State: AJcUukfcOyAgenrz5zuVKFzK9mVlX8ygINrm1H6KNrhL5XOGtcHyF93D QxANSfXWQB3SKMglHzf46AEXvvdu X-Received: by 2002:adf:9d08:: with SMTP id k8mr39591821wre.203.1546411724933; Tue, 01 Jan 2019 22:48:44 -0800 (PST) Received: from [192.168.1.104] (185-219-167-241-static.vivo.cz. [185.219.167.241]) by smtp.gmail.com with ESMTPSA id e16sm44050780wrn.72.2019.01.01.22.48.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Jan 2019 22:48:43 -0800 (PST) Subject: Re: [PATCH] n_tty: update comment for WAKEUP_CHARS define To: Valentin Vidic , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org References: <20181229124829.3745-1-Valentin.Vidic@CARNet.hr> From: Jiri Slaby Openpgp: preference=signencrypt Autocrypt: addr=jslaby@suse.cz; prefer-encrypt=mutual; keydata= mQINBE6S54YBEACzzjLwDUbU5elY4GTg/NdotjA0jyyJtYI86wdKraekbNE0bC4zV+ryvH4j rrcDwGs6tFVrAHvdHeIdI07s1iIx5R/ndcHwt4fvI8CL5PzPmn5J+h0WERR5rFprRh6axhOk rSD5CwQl19fm4AJCS6A9GJtOoiLpWn2/IbogPc71jQVrupZYYx51rAaHZ0D2KYK/uhfc6neJ i0WqPlbtIlIrpvWxckucNu6ZwXjFY0f3qIRg3Vqh5QxPkojGsq9tXVFVLEkSVz6FoqCHrUTx wr+aw6qqQVgvT/McQtsI0S66uIkQjzPUrgAEtWUv76rM4ekqL9stHyvTGw0Fjsualwb0Gwdx ReTZzMgheAyoy/umIOKrSEpWouVoBt5FFSZUyjuDdlPPYyPav+hpI6ggmCTld3u2hyiHji2H cDpcLM2LMhlHBipu80s9anNeZhCANDhbC5E+NZmuwgzHBcan8WC7xsPXPaiZSIm7TKaVoOcL 9tE5aN3jQmIlrT7ZUX52Ff/hSdx/JKDP3YMNtt4B0cH6ejIjtqTd+Ge8sSttsnNM0CQUkXps w98jwz+Lxw/bKMr3NSnnFpUZaxwji3BC9vYyxKMAwNelBCHEgS/OAa3EJoTfuYOK6wT6nadm YqYjwYbZE5V/SwzMbpWu7Jwlvuwyfo5mh7w5iMfnZE+vHFwp/wARAQABtBtKaXJpIFNsYWJ5 IDxqc2xhYnlAc3VzZS5jej6JAjgEEwECACIFAk6S6NgCGwMGCwkIBwMCBhUIAgkKCwQWAgMB Ah4BAheAAAoJEL0lsQQGtHBJgDsP/j9wh0vzWXsOPO3rDpHjeC3BT5DKwjVN/KtP7uZttlkB duReCYMTZGzSrmK27QhCflZ7Tw0Naq4FtmQSH8dkqVFugirhlCOGSnDYiZAAubjTrNLTqf7e 5poQxE8mmniH/Asg4KufD9bpxSIi7gYIzaY3hqvYbVF1vYwaMTujojlixvesf0AFlE4x8WKs wpk43fmo0ZLcwObTnC3Hl1JBsPujCVY8t4E7zmLm7kOB+8EHaHiRZ4fFDWweuTzRDIJtVmrH LWvRDAYg+IH3SoxtdJe28xD9KoJw4jOX1URuzIU6dklQAnsKVqxz/rpp1+UVV6Ky6OBEFuoR 613qxHCFuPbkRdpKmHyE0UzmniJgMif3v0zm/+1A/VIxpyN74cgwxjhxhj/XZWN/LnFuER1W zTHcwaQNjq/I62AiPec5KgxtDeV+VllpKmFOtJ194nm9QM9oDSRBMzrG/2AY/6GgOdZ0+qe+ 4BpXyt8TmqkWHIsVpE7I5zVDgKE/YTyhDuqYUaWMoI19bUlBBUQfdgdgSKRMJX4vE72dl8BZ +/ONKWECTQ0hYntShkmdczcUEsWjtIwZvFOqgGDbev46skyakWyod6vSbOJtEHmEq04NegUD al3W7Y/FKSO8NqcfrsRNFWHZ3bZ2Q5X0tR6fc6gnZkNEtOm5fcWLY+NVz4HLaKrJuQINBE6S 54YBEADPnA1iy/lr3PXC4QNjl2f4DJruzW2Co37YdVMjrgXeXpiDvneEXxTNNlxUyLeDMcIQ K8obCkEHAOIkDZXZG8nr4mKzyloy040V0+XA9paVs6/ice5l+yJ1eSTs9UKvj/pyVmCAY1Co SNN7sfPaefAmIpduGacp9heXF+1Pop2PJSSAcCzwZ3PWdAJ/w1Z1Dg/tMCHGFZ2QCg4iFzg5 Bqk4N34WcG24vigIbRzxTNnxsNlU1H+tiB81fngUp2pszzgXNV7CWCkaNxRzXi7kvH+MFHu2 1m/TuujzxSv0ZHqjV+mpJBQX/VX62da0xCgMidrqn9RCNaJWJxDZOPtNCAWvgWrxkPFFvXRl t52z637jleVFL257EkMI+u6UnawUKopa+Tf+R/c+1Qg0NHYbiTbbw0pU39olBQaoJN7JpZ99 T1GIlT6zD9FeI2tIvarTv0wdNa0308l00bas+d6juXRrGIpYiTuWlJofLMFaaLYCuP+e4d8x rGlzvTxoJ5wHanilSE2hUy2NSEoPj7W+CqJYojo6wTJkFEiVbZFFzKwjAnrjwxh6O9/V3O+Z XB5RrjN8hAf/4bSo8qa2y3i39cuMT8k3nhec4P9M7UWTSmYnIBJsclDQRx5wSh0Mc9Y/psx9 B42WbV4xrtiiydfBtO6tH6c9mT5Ng+d1sN/VTSPyfQARAQABiQIfBBgBAgAJBQJOkueGAhsM AAoJEL0lsQQGtHBJN7UQAIDvgxaW8iGuEZZ36XFtewH56WYvVUefs6+Pep9ox/9ZXcETv0vk DUgPKnQAajG/ViOATWqADYHINAEuNvTKtLWmlipAI5JBgE+5g9UOT4i69OmP/is3a/dHlFZ3 qjNk1EEGyvioeycJhla0RjakKw5PoETbypxsBTXk5EyrSdD/I2Hez9YGW/RcI/WC8Y4Z/7FS ITZhASwaCOzy/vX2yC6iTx4AMFt+a6Z6uH/xGE8pG5NbGtd02r+m7SfuEDoG3Hs1iMGecPyV XxCVvSV6dwRQFc0UOZ1a6ywwCWfGOYqFnJvfSbUiCMV8bfRSWhnNQYLIuSv/nckyi8CzCYIg c21cfBvnwiSfWLZTTj1oWyj5a0PPgGOdgGoIvVjYXul3yXYeYOqbYjiC5t99JpEeIFupxIGV ciMk6t3pDrq7n7Vi/faqT+c4vnjazJi0UMfYnnAzYBa9+NkfW0w5W9Uy7kW/v7SffH/2yFiK 9HKkJqkN9xYEYaxtfl5pelF8idoxMZpTvCZY7jhnl2IemZCBMs6s338wS12Qro5WEAxV6cjD VSdmcD5l9plhKGLmgVNCTe8DPv81oDn9s0cIRLg9wNnDtj8aIiH8lBHwfUkpn32iv0uMV6Ae sLxhDWfOR4N+wu1gzXWgLel4drkCJcuYK5IL1qaZDcuGR8RPo3jbFO7Y Message-ID: <7e91df3a-d38b-fda4-b64f-4d47f4949623@suse.cz> Date: Wed, 2 Jan 2019 07:48:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 MIME-Version: 1.0 In-Reply-To: <20181229124829.3745-1-Valentin.Vidic@CARNet.hr> Content-Type: text/plain; charset=iso-8859-2 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29. 12. 18, 13:48, Valentin Vidic wrote: > Give a better descriptions of what WAKEUP_CHARS represents. > > Signed-off-by: Valentin Vidic I am not a native speaker, but this is much better than the current text. Acked-by: Jiri Slaby BTW this text is copy&pasted from/to all the other WAKEUP_CHARS locations. Care to fix them all? > --- > drivers/tty/n_tty.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c > index 3ad460219fd6..1dfbd45746da 100644 > --- a/drivers/tty/n_tty.c > +++ b/drivers/tty/n_tty.c > @@ -50,8 +50,10 @@ > #include > #include > > - > -/* number of characters left in xmit buffer before select has we have room */ > +/* > + * Until this number of characters is queued in the xmit buffer, select will > + * return "we have room for writes". > + */ > #define WAKEUP_CHARS 256 > > /* > thanks, -- js suse labs