Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH net-next] net: hns3: Config NIC port speed same as that of
 optical module
To:     dann frazier <dann.frazier@canonical.com>,
        Salil Mehta <salil.mehta@huawei.com>
CC:     <davem@davemloft.net>, <yisen.zhuang@huawei.com>,
        <mehta.salil@opnsrc.net>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linuxarm@huawei.com>
References: <20181126184300.24964-1-salil.mehta@huawei.com>
 <20190101012205.GA22494@xps13.dannf>
From:   "lipeng (Y)" <lipeng321@huawei.com>
Message-ID: <aadad75b-a3fe-8bf1-77ce-14d3375ce4fd@huawei.com>
Date:   Wed, 2 Jan 2019 20:45:36 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.2
MIME-Version: 1.0
In-Reply-To: <20190101012205.GA22494@xps13.dannf>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2019/1/1 9:22, dann frazier wrote:
> On Mon, Nov 26, 2018 at 06:43:00PM +0000, Salil Mehta wrote:
>> From: Peng Li <lipeng321@huawei.com>
>>
>> Port 0/1 of HiP08 supports 10G and 25G. This patch adds a
>> change to configure NIC port speed same as that of  optical
>> module(SFP/QFSP). Driver gets the optical module speed and
>> sets NIC port speed accordingly.
> Hi,
>
> I'm getting the following errors in dmesg about every 1s on a D06:
>
> [  766.761823] hns3 0000:bd:00.0: get sfp speed failed -5
> [  767.785823] hns3 0000:bd:00.0: get sfp speed failed -5
> [  768.809820] hns3 0000:bd:00.0: get sfp speed failed -5
> [  769.833818] hns3 0000:bd:00.0: get sfp speed failed -5
>
> Reverting this patch fixes the issue.
>
>   -dann
Hi,dann,

Thanks for your test and report.

This patch needs to match new fireware verison ,
And  it  does some work to  be Compatible with older versions.

Can you show me more information？
can you  use "ethtool -i ethx" to get the fireware version ,
and shows me  some other message about hns3?

Thanks

>
> .
>