Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] Revert "staging:r8188eu: use lib80211 CCMP decrypt"
To:     Larry Finger <Larry.Finger@lwfinger.net>,
        Michael Straube <straube.linux@gmail.com>,
        gregkh@linuxfoundation.org
Cc:     devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
References: <20181230183918.3888-1-straube.linux@gmail.com>
 <efbc3a4a-ce31-8785-73c0-3d89edc66977@lwfinger.net>
 <59368aca-c3d9-0563-aa83-118842834fb1@gmail.com>
 <2aab932b-b4ba-2601-06de-ca095a549fb7@lwfinger.net>
From:   Ivan Safonov <insafonov@gmail.com>
Message-ID: <721d7c62-5119-f52a-6d5f-c3138654d0ae@gmail.com>
Date:   Wed, 2 Jan 2019 22:35:35 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <2aab932b-b4ba-2601-06de-ca095a549fb7@lwfinger.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 1/2/19 4:06 AM, Larry Finger wrote:
> On 1/1/19 1:31 PM, Michael Straube wrote:
>>
>> I've tested your patch and it solved the issue. No freezes and dmesg 
>> looks good.
>>
>> I noticed that try_then_request_module() is also used in 
>> rtw_wep_encrypt() and
>> rtw_wep_decrypt(). I guess that also could cause problems?
> 
> Yes, I believe it would if anyone is still using WEP. My plan is to get 
> rid of the try_then_request_module() there as well, and for 
> completeness, I plan to restore usage of the lib80211 routines for TKIP 
> as well.

Patch "load lib80211 crypto ops from interruptible context" ( 
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-August/124851.html 
) is a preparation to replace
     crypto_ops = try_then_request_module(lib80211_get_crypto_ops(*), 
"lib80211_crypt_*");
with
     (struct crypto_algorithm).ops

> 
> Once I get a chance to test the TKIP and WEP changes, I plan to have a 
> set of 4 patches to switch the driver to using lib80211 routines for all 
> decryption/encryption.


There are four other patches to use lib80211:
use lib80211 CCMP decrypt ( 
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-February/116533.html 
)
Use lib80211 to encrypt (WEP) tx frames ( 
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-June/122642.html 
)
Use lib80211 to encrypt (TKIP) tx frames ( 
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-July/123249.html 
)
Use lib80211 to encrypt (CCMP) tx frames ( 
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-July/123250.html 
)

They all crash when try_then_request_module() called.

> 
> Larry
> 
>