Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp159430imu; Wed, 2 Jan 2019 16:38:30 -0800 (PST) X-Google-Smtp-Source: ALg8bN6Unw9p3W3jVaunZcnDDtOmnZRVnsFY16l8g5KTuhhTSfJ1QC2hgXRvyBxPt6/Qxod7roCi X-Received: by 2002:a17:902:e20b:: with SMTP id ce11mr43884789plb.251.1546475910165; Wed, 02 Jan 2019 16:38:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546475910; cv=none; d=google.com; s=arc-20160816; b=ZCbqoNwmKSq+Gq4m8+OYwogCfgbKeH19xQMyYDMzM3gV0m1T1PxGyy7/sBP60Ck7TS dkQ0DOAeyqUKUjvI5TzjrRanY0cDgiDnk2vivvOA5NUIQeXJ3vli5NPKKSCDLPPFgJui zvgLleMgHGDzoFavCzFNmrLXNbfbgi3Mllt6FrA1THbDoG4Hy5nfhoe+G7428SUFW+eD yhhdFqJK0AvIW09/4q3oZ8MoJzX3/Zr/R8mRJTN2mxbwhxZT1x/OS8oaLF3liWdoDXse /MAXnl4/MJcJMpSAQqGeNOX8Tk7GHOI3cD1QFoF485jEqLvRt3ifnggMeMIiXAJTFLMo JzSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=M4IGlqEQFNqwliRsSyTfnKKOspsRl2QEciHUCHKHBN0=; b=xlaaTXwGfMPIDlt4JEP0owBrG06/7Y6X7L9AQ21ep5pVlDhJz4MauUImhS8K3KJJ1K G9SYpdGyEV6ayb9edvA/hbFTgsgC56Rl8PidYqPAMz/JiBqMJgSufhzpZ7SocpHq9rpv Gx8oLrLfXQG5VF/Te0CZVCuS7gqW1YpMjILLxzqj7DhcXhMpxOsPpzWGaXkaY7sF+5AZ QjwAJqU5iXGCIBD2iLMdGQbC5iD1Tn5jJApXwitrJymlbSou8uWJTXMpn41tNGRmH9eG kjFCKSzOBs6bin40/J7g7I/l+eEnUjZgBdW/kAyORVpN/N+WhTZC6gkoqtiXveJxYl3a Wvxw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=mIeAx4XV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r207si5445205pfc.179.2019.01.02.16.38.15; Wed, 02 Jan 2019 16:38:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=mIeAx4XV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728616AbfABVAc (ORCPT + 99 others); Wed, 2 Jan 2019 16:00:32 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:54506 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726116AbfABVAb (ORCPT ); Wed, 2 Jan 2019 16:00:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=M4IGlqEQFNqwliRsSyTfnKKOspsRl2QEciHUCHKHBN0=; b=mIeAx4XVHfAq1tTMDZX8ChgGK kAxwG2LXSgH6Wm6fsEETnxI6IlDSIePpmkA7ns1A8K823CvsVsHYSxnUB8QfOrqgIBqJM4KVFslHk nwJ+Vt30zxTIv3iZU27h7W75GbjIGoqKl3XksGTd0xd6alAOyb+Yaj1p7L46p/96fXy14n8yY5ElO SKqBGLBv3j71+qDvoBOVHjrXfCnj/wTGscOhZ3LKCEnbPdMeD+L2K8/fpY1AWddSKfnqPv62015sO tGsuHjrT9OC5VUqRPd+Yhq3Zs6aRBwjs50rKDQctY9vWrxWUtFRdliQs4CdjjfyF10lhV2nwKl6z9 a5qqLWuJA==; Received: from willy by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gencm-0005xD-EQ; Wed, 02 Jan 2019 21:00:24 +0000 Date: Wed, 2 Jan 2019 13:00:24 -0800 From: Matthew Wilcox To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, Jason Wang , Alan Stern , Andrea Parri , Will Deacon , Peter Zijlstra , Boqun Feng , Nicholas Piggin , David Howells , Jade Alglave , Luc Maranget , "Paul E. McKenney" , Akira Yokosawa , Daniel Lustig , linux-arch@vger.kernel.org, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Arnd Bergmann , Luc Van Oostenryck , linux-doc@vger.kernel.org, linux-alpha@vger.kernel.org, linux-sparse@vger.kernel.org Subject: Re: [PATCH RFC 3/4] barriers: convert a control to a data dependency Message-ID: <20190102210024.GJ6310@bombadil.infradead.org> References: <20190102205715.14054-1-mst@redhat.com> <20190102205715.14054-4-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190102205715.14054-4-mst@redhat.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 02, 2019 at 03:57:58PM -0500, Michael S. Tsirkin wrote: > @@ -875,6 +893,8 @@ to the CPU containing it. See the section on "Multicopy atomicity" > for more information. > > > + > + > In summary: > > (*) Control dependencies can order prior loads against later stores. Was this hunk intentional?