Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Wed, 02 Jan 2019 21:57:00 +0100
From:   Danilo Krummrich <danilokrummrich@dk-develop.de>
To:     Jack Stocker <jackstocker.93@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Kai-Heng Feng <kai.heng.feng@canonical.com>,
        Seth Forshee <seth.forshee@canonical.com>,
        Thadeu Lima de Souza Cascardo <cascardo@canonical.com>,
        Harry Pan <harry.pan@intel.com>,
        Kamil Lulko <kamilx.lulko@intel.com>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Add USB_QUIRK_DELAY_CTRL_MSG quirk for Corsair K70 RGB
In-Reply-To: <1546454264-11561-1-git-send-email-jackstocker.93@gmail.com>
References: <1546454264-11561-1-git-send-email-jackstocker.93@gmail.com>
Message-ID: <68e03db778525f1d26d72a683bc0e0e2@dk-develop.de>
User-Agent: Roundcube Webmail/1.3.4
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

You're referring to this patch
cb88a0588717 ("usb: quirks: add control message delay for 1b1c:1b20")
I guess. Maybe you want to name it explicitly for better reference.

Acked-by: Danilo Krummrich <danilokrummrich@dk-develop.de>


On 2019-01-02 19:37, Jack Stocker wrote:
> To match the Corsair Strafe RGB, the Corsair K70 RGB also requires
> USB_QUIRK_DELAY_CTRL_MSG to completely resolve boot connection issues
> discussed here: https://github.com/ckb-next/ckb-next/issues/42.
> Otherwise roughly 1 in 10 boots the keyboard will fail to be detected.
> 
> Signed-off-by: Jack Stocker <jackstocker.93@gmail.com>
> ---
>  drivers/usb/core/quirks.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
> index 7909262..4a9267d 100644
> --- a/drivers/usb/core/quirks.c
> +++ b/drivers/usb/core/quirks.c
> @@ -377,7 +377,8 @@ static const struct usb_device_id usb_quirk_list[] 
> = {
>  			USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
> 
>  	/* Corsair K70 RGB */
> -	{ USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT },
> +	{ USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT |
> +	  USB_QUIRK_DELAY_CTRL_MSG },
> 
>  	/* Corsair Strafe RGB */
>  	{ USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT |