Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp165753imu; Wed, 2 Jan 2019 16:49:40 -0800 (PST) X-Google-Smtp-Source: ALg8bN7caro2JMyfD/svFvttUs2zgs779PoJOOmko8jxqHx4iVgqYP8e++FyCUCiJs8rtu/On2AV X-Received: by 2002:a63:a41:: with SMTP id z1mr15217286pgk.117.1546476580506; Wed, 02 Jan 2019 16:49:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546476580; cv=none; d=google.com; s=arc-20160816; b=yXPhCrTvoWbvNepgvv25ZCDB9bqYzV4KEAwzBheRyxWgcV+MWVGKITFY0eW478VyP/ mwHKVhVe+gvGhrvuF3z9SESm+f/YkVNtCuv4vKvyFmS1ZuTBzTgsvBpwHZjA3atMVY1d 5nnh+tx7gT9yzBn9VG9HpZGvp9hVxZZXqyC3UszpICXCSD9rDKqBM1+H6eJkeuatgTEh 52tesokml6bvbNK2eWIItpqoEztq6QXmyDH/JH3DPIA+E5CtgL2Iwy0Qu42XazmQFM56 z5DgKDK3J3lHXd/ZASy0osIgqT74aGWb8TNoS7QSRFsuKQzYMpH6PnPNQShawbMVsM6D OomQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=52IjSl6R3JslFa37tzvvJrfRb4WnsdCBjSmuvS3Gu1Q=; b=loVOQ/6eP3x1rPFmCj1HBHIsvasERgymdfdczEO3TRdtGQ2V0sykN8W5iMGUPCLn6v h4Rx/UOBrR49ATh0/EkvE7B4Ykmm3e2LL635Bs1FMdNluAhsTZwmrap+vKymNsXfV2+8 tlH4XnYAcw9Xbr8ZL0GVXXGLuYvmf9y5PK/jULyXkwExbPcnBgMLt5GGurR0p7BAMlp9 RGdC/ZH0rvzcsJDj4Lfzdfjk+/4QuAGyepyMENtR+snGFgJg+ysh8OBzi+GE9AC2kKJX lwOgnvR/XSepLT2vnSzNcSYVLCqeW59mCe7cp3Fy9KhdsZN2RS12d2mnQnPvlXAjl2qD dE0g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p14si51263545pfi.12.2019.01.02.16.49.25; Wed, 02 Jan 2019 16:49:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729087AbfABVYW (ORCPT + 99 others); Wed, 2 Jan 2019 16:24:22 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44632 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727139AbfABVYW (ORCPT ); Wed, 2 Jan 2019 16:24:22 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C6225C049D7F; Wed, 2 Jan 2019 21:24:20 +0000 (UTC) Received: from redhat.com (ovpn-120-148.rdu2.redhat.com [10.10.120.148]) by smtp.corp.redhat.com (Postfix) with SMTP id 58D2F5C230; Wed, 2 Jan 2019 21:24:16 +0000 (UTC) Date: Wed, 2 Jan 2019 16:24:15 -0500 From: "Michael S. Tsirkin" To: Matthew Wilcox Cc: linux-kernel@vger.kernel.org, Jason Wang , Alan Stern , Andrea Parri , Will Deacon , Peter Zijlstra , Boqun Feng , Nicholas Piggin , David Howells , Jade Alglave , Luc Maranget , "Paul E. McKenney" , Akira Yokosawa , Daniel Lustig , linux-arch@vger.kernel.org, netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, Jonathan Corbet , Richard Henderson , Ivan Kokshaysky , Matt Turner , Arnd Bergmann , Luc Van Oostenryck , linux-doc@vger.kernel.org, linux-alpha@vger.kernel.org, linux-sparse@vger.kernel.org Subject: Re: [PATCH RFC 3/4] barriers: convert a control to a data dependency Message-ID: <20190102162400-mutt-send-email-mst@kernel.org> References: <20190102205715.14054-1-mst@redhat.com> <20190102205715.14054-4-mst@redhat.com> <20190102210024.GJ6310@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190102210024.GJ6310@bombadil.infradead.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Wed, 02 Jan 2019 21:24:21 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 02, 2019 at 01:00:24PM -0800, Matthew Wilcox wrote: > On Wed, Jan 02, 2019 at 03:57:58PM -0500, Michael S. Tsirkin wrote: > > @@ -875,6 +893,8 @@ to the CPU containing it. See the section on "Multicopy atomicity" > > for more information. > > > > > > + > > + > > In summary: > > > > (*) Control dependencies can order prior loads against later stores. > > Was this hunk intentional? Nope, thanks for catching this. -- MST