Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp478467imu; Thu, 3 Jan 2019 01:18:05 -0800 (PST) X-Google-Smtp-Source: ALg8bN5y4X08L/45qlAMFCM0IQgzZAoq5AVRU1exosHZVV30gROdjl7qu+FQSbBMD+j2RKVAB+YM X-Received: by 2002:a17:902:24d:: with SMTP id 71mr44989239plc.225.1546507085132; Thu, 03 Jan 2019 01:18:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546507085; cv=none; d=google.com; s=arc-20160816; b=HhdQt9a8YEQ1k00fww90lwXzpb7uS5DmQ6IJ8sRbhcpJcITonloHoE+PhUu9H5sbCi E1ho8LMxBShsjh6Srh2eK2zHeJ2ZM7CLQdjKj239NAVXXoNgDki18P43gMztuQuMLkiy kwdgUKNgB4kAdgQ9IlRlB1f5qpQxfM424pcQATxedmTzpxu9y5QBrJF6i+QonvT9lYhe 1aZzonHamaTdnd7lqYunH+cDXv2zmPkpwxrg1DQAO1ir3BrZ77Tllq4f/gJNntI2r7W1 BG78Sou+TKFeV4RCXctL3VSNVgA48QbTLJ+XFSkxQG9OD02ZP3aGMLC23lmf5jXXgplT 9/eA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=wD3XC5clJgBcb8qj6+QFlJOKL54hcbtfhGqHXTkeYKQ=; b=UwGwE9KcV8PsUGl0q2YfDppkkyfrmkLB2xVXmdqY3uJP025Bau0xOKSzSzMskDhsWd ZRcrLrgVCyerXCk8FRPKsw60qIbSvzIfdtIGQUi3wCpS7xqvN3gBWUU0sucob2++Gamy 2KXbnpfDOeH2l/h3++gBpuZedQ/bBSbhUfysDWpR9730psiPAHUn2aPgKO75GX6Azomg JwtXLYGuTVFdCEx3rP5kGWDpcH54WnsfSd0N9nbCjCC/lx90VEC9vMcQx1XO01amtFel ruoMcI3SfKXMfVA3mcylnV1xdl31iVUyq0+GJw1B31f9ocUFYP0zw15fQMJHMCbQRRZe O4zA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DlebsdW5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x23si49627520pln.100.2019.01.03.01.17.50; Thu, 03 Jan 2019 01:18:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DlebsdW5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729477AbfACEs4 (ORCPT + 99 others); Wed, 2 Jan 2019 23:48:56 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:41360 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729358AbfACEsz (ORCPT ); Wed, 2 Jan 2019 23:48:55 -0500 Received: by mail-pl1-f193.google.com with SMTP id u6so15381717plm.8 for ; Wed, 02 Jan 2019 20:48:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=wD3XC5clJgBcb8qj6+QFlJOKL54hcbtfhGqHXTkeYKQ=; b=DlebsdW5lff+RPbGDS2SLByu/C1tjDsxWGxidpo1iP89m+Wnjz9mYRADF390OWvb1w O/JyjlVafxkMq240QYceRnXncgvmZNNM7/qrOsaGahRQxKIV+MhiQyJ0CYvmUkxF5bXm f+Lv7vyy0k2KjKUUm2Vl4VnHs2JsR6dgrmd2U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=wD3XC5clJgBcb8qj6+QFlJOKL54hcbtfhGqHXTkeYKQ=; b=t0AgVSOOrcVTnW2/NnWE7Jmer3qV173z4qLpVam2tzc1HfrhSj1d0ypL3T9EAxjJmB E3QQNyGXfQpbTR8F7QSs7GbtRGJv/65UzITWD2ZB7LQvjebgblRgXIm1ntkfTpqtKXA/ lH9HgcYnJXnIVHdYWVAO7cGqJ5uzpJKvqUOyFjlWlnLhrV1kJvsp/Sn78z8NsWekYHCd 0+SJ+tvPEb1XIvY566sP3Ueg6SH1gAs/ns3lwsg9WTE6EYhx6puv6Z3HF1T4Hm0TkAgL /KLVmBpK3w3yljEp67We5Te1NnfZd6psS4ZVx8fGc8LYVEY6mzgQFKipSkqedZA9Hw/i DoeQ== X-Gm-Message-State: AJcUukcfisN/7Gj78bTQhQ8ANIbW1dASBz65VxDeCCdjtG007rJHgIx9 2MMsGDKdWo2qUxDLJ5r6HsSx7g== X-Received: by 2002:a17:902:1008:: with SMTP id b8mr44348614pla.252.1546490934801; Wed, 02 Jan 2019 20:48:54 -0800 (PST) Received: from localhost ([122.166.131.155]) by smtp.gmail.com with ESMTPSA id h134sm108167206pfe.27.2019.01.02.20.48.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Jan 2019 20:48:54 -0800 (PST) Date: Thu, 3 Jan 2019 10:18:52 +0530 From: Viresh Kumar To: Henry Chen Cc: Viresh Kumar , Stephen Boyd , Rob Herring , Matthias Brugger , Ulf Hansson , Mark Rutland , Fan Chen , Weiyi Lu , James Liao , Kees Cook , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [RFC RESEND PATCH 0/7] Add driver for dvfsrc and add support for active state of scpsys on mt8183 Message-ID: <20190103044852.l7sxfqeqnxx2xbp5@vireshk-i7> References: <1546438198-1677-1-git-send-email-henryc.chen@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1546438198-1677-1-git-send-email-henryc.chen@mediatek.com> User-Agent: NeoMutt/20180323-120-3dd1ac Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02-01-19, 22:09, Henry Chen wrote: > The patchsets add support for MediaTek hardware module named DVFSRC > (dynamic voltage and frequency scaling resource collector). The DVFSRC is > a HW module which is used to collect all the requests from both software > and hardware and turn into the decision of minimum operating voltage and > minimum DRAM frequency to fulfill those requests. > > So, This series is to implement the dvfsrc driver to collect all the > requests of operating voltage or DRAM bandwidth from other device drivers > likes GPU/Camera through 2 frameworks basically: > > 1. PM_QOS_MEMORY_BANDWIDTH from PM QOS: to aggregate the bandwidth > requirements from different clients > 2. Active state management of power domains[1]: to handle the operating > voltage opp requirement from different power domains Honestly speaking I wasn't sure if anyone apart from Qcom will ever use this feature when I wrote it first and I am quite surprised and happy to see your patches. They are mostly very neat and clean patches and I don't have complaints with most of them. Lets see what comments others provide on them. Thanks. -- viresh