Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3] driver: uio: fix possible memory leak in uio_open
To:     liujian <liujian56@huawei.com>, gregkh@linuxfoundation.org
Cc:     linux-kernel@vger.kernel.org
References: <1546525702-11264-1-git-send-email-liujian56@huawei.com>
From:   Xiubo Li <xiubli@redhat.com>
Message-ID: <eed703d7-094f-4e6a-2948-e3ff82fad93d@redhat.com>
Date:   Thu, 3 Jan 2019 12:48:32 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <1546525702-11264-1-git-send-email-liujian56@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2019/1/3 22:28, liujian wrote:
> Fixes: 57c5f4df0a5a ("uio: fix crash after the device is unregistered")
> Signed-off-by: liujian <liujian56@huawei.com>
> ---
> v1->v2:
> rename the "err_infoopen" to "err_idev_info"
> v2->3:
> put the extra info after the "--"

Looks good to me.

Thanks.
BRs


>   drivers/uio/uio.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
> index 5c10fc7..aab3520 100644
> --- a/drivers/uio/uio.c
> +++ b/drivers/uio/uio.c
> @@ -496,18 +496,19 @@ static int uio_open(struct inode *inode, struct file *filep)
>   	if (!idev->info) {
>   		mutex_unlock(&idev->info_lock);
>   		ret = -EINVAL;
> -		goto err_alloc_listener;
> +		goto err_idev_info;
>   	}
>   
>   	if (idev->info && idev->info->open)
>   		ret = idev->info->open(idev->info, inode);
>   	mutex_unlock(&idev->info_lock);
>   	if (ret)
> -		goto err_infoopen;
> +		goto err_idev_info;
>   
>   	return 0;
>   
> -err_infoopen:
> +err_idev_info:
> +	filep->private_data = NULL;
>   	kfree(listener);
>   
>   err_alloc_listener: