Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp511563imu; Thu, 3 Jan 2019 02:04:22 -0800 (PST) X-Google-Smtp-Source: AFSGD/VON1eBPpCoOcMJUFBIYGPLZ1q8005XVQpOsQYK1hsmvEAH+nPGEKflV5KXdIUGIZS0qkBE X-Received: by 2002:a62:7c47:: with SMTP id x68mr48200203pfc.209.1546509861995; Thu, 03 Jan 2019 02:04:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546509861; cv=none; d=google.com; s=arc-20160816; b=pqXAfyhtvmxMvF01TT6s/ScKp0cycyJcxnmN0FXc/euZPGaayhpKWv2K5c1x+c0FTZ Sj+QGkESN6CgEPCYNx46JltVvCfqr+n1D8saVsh1fEsRvnzir5Dwfb+OF56eZOwNMlb0 PxOILb7rNl3nPzwvyRQy/EFuqXe98HVD6/Aoasai7gqzXg7gVCxcpso4NI1DF2oheZG3 u3M2QzN11qBNp8HOkP3g9eJIg9YNs3JpZcwwSVmGtBSP7KRwkEmd2G8SSTy3VjFGoXhZ PEWnlN4z6Am4C41+sanMs2vd/DBQ6FeMxblrMezHo19GcomP6nuuktwvhSzODHO3CA/2 TPnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:message-id:in-reply-to:mime-version :references:subject:cc:to:from:date; bh=Za84EcHxOlqqDhLUg+WrwFV/TK6x/BFldAqmv7i88bQ=; b=WWvuM0RaIEsG6LOPB/frRsYIWIFTO7Zf4ABZef+thaHEdLkE12RsEXh85CHVWjvOFW vmaUNG1WnJkWah18kbtlQLxxi9LIiEihvJG/xQZ+cnIB7HHNP18abOwygBTw4ZRg9tXu riZe9lc5v4Ay/G1lcp5Ken89+R/SVnzSDbouYkzdc9nvMs8r8TcmgqRRN2MOqSm1h34M MGgnJIncUIlpumm+4X+SrczVA31x4LI0pSx5iqjwXC9wmJzTTWRxm4O9f+o2N9EOu3P0 9DAJ7FsLkKLy0QoJaSnJzFPlym6u94TI2zRXQKxiwtOlWToMGG2KEUrFHwPXwLxRbjyi FxHA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c13si2449329pgi.531.2019.01.03.02.03.48; Thu, 03 Jan 2019 02:04:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730081AbfACHhB (ORCPT + 99 others); Thu, 3 Jan 2019 02:37:01 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:57734 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726036AbfACHhB (ORCPT ); Thu, 3 Jan 2019 02:37:01 -0500 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.22/8.16.0.22) with SMTP id x037Xvas038387 for ; Thu, 3 Jan 2019 02:37:00 -0500 Received: from e06smtp04.uk.ibm.com (e06smtp04.uk.ibm.com [195.75.94.100]) by mx0b-001b2d01.pphosted.com with ESMTP id 2psdtngp2p-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 03 Jan 2019 02:36:59 -0500 Received: from localhost by e06smtp04.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 3 Jan 2019 07:36:58 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp04.uk.ibm.com (192.168.101.134) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 3 Jan 2019 07:36:55 -0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x037asvY37683312 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 3 Jan 2019 07:36:54 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7E96D4C04A; Thu, 3 Jan 2019 07:36:54 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 43EC24C046; Thu, 3 Jan 2019 07:36:54 +0000 (GMT) Received: from osiris (unknown [9.152.212.95]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Thu, 3 Jan 2019 07:36:54 +0000 (GMT) Date: Thu, 3 Jan 2019 08:36:52 +0100 From: Heiko Carstens To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Marek , Martin Schwidefsky , Hendrik Brueckner Subject: Re: [PATCH] kbuild: use assignment instead of define ... endef for filechk_* rules References: <1546478214-20394-1-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 In-Reply-To: <1546478214-20394-1-git-send-email-yamada.masahiro@socionext.com> X-TM-AS-GCONF: 00 x-cbid: 19010307-0016-0000-0000-0000023EDB57 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19010307-0017-0000-0000-00003297E2DF Message-Id: <20190103073652.GA3957@osiris> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit Content-Disposition: inline X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-01-03_03:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=636 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901030068 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 03, 2019 at 10:16:54AM +0900, Masahiro Yamada wrote: > You do not have to use define ... endef for filechk_* rules. > > For simple cases, the use of assignment looks cleaner, IMHO. > > I updated the usage for scripts/Kbuild.include in case somebody > misunderstands the 'define ... endif' is the requirement. > > Signed-off-by: Masahiro Yamada > --- > > Kbuild | 4 +--- > Makefile | 3 +-- > arch/s390/kernel/syscalls/Makefile | 12 +++--------- > arch/s390/tools/Makefile | 7 ++----- > scripts/Kbuild.include | 8 ++++---- > scripts/kconfig/Makefile | 4 +--- > 6 files changed, 12 insertions(+), 26 deletions(-) For the s390 bits: Acked-by: Heiko Carstens