Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp553782imu; Thu, 3 Jan 2019 02:58:10 -0800 (PST) X-Google-Smtp-Source: AFSGD/VlSziJ5ZlkR5HtmszWtRhmfYgnqQcv6bFv14I7lWbqX43Md0+YTrhEaRSDILewTIgu3rJy X-Received: by 2002:a62:3006:: with SMTP id w6mr48203428pfw.258.1546513090583; Thu, 03 Jan 2019 02:58:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546513090; cv=none; d=google.com; s=arc-20160816; b=xubGmrdWjKHBOLCLEjMdXebJNVFSRK/NJQjS9wtTh5f1LV4XOEyMuc1ztU23NRxf0X HB7a9dpjnk+MYMOJUNfzstu7rofmK3fLEHBY0oJbmhjrG+Y1wKEmDpf0WqR9kKVxgS1y 4qBfybcs2OcckOuY4MCScgw37iOGK62FlYZ1fiDbka9Ozxx0cg+VO5JYDlDLS+legiI9 Z9iW/9P6fyOKwyoxQ1WaHrc6dA3YH7ZLIQoSmTtkIjS304CCY0fvEUbxdp0NbEeruxTB AJfuP4NLr060VX4X4MbN5s6GuhR8yBBoIQmzor8kYDqZLxUDk07ZlEtWisiZmzNVkkJy 7X7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=N1HCgu/9K4V4ycQY5lpDdUrvXqrbs6vliV6vgmhMQeo=; b=Rpf45xgeVZj+6nl4Zgn1/JMiG2w00XfEgozlWqDtafi8uVN2hvu7ELt+PF0SoFdckX Kvd/XdH5YTMpM6br2Rw9B408KsxC/qmZn++auBOEO/HPdgMwsOTA5uW0ryEYaUjIT7vT mHf/didQHpgvnly0Cu3FPyn7M9AYILiAmAuswXjhQgh4L31vRZUYcM1T54JW56vM/CYl IkXf5hWYwiUjgJiRLw+eDIuwCjhz14hNtuR4u5ve+Tz4wSjS/uZMIz5a8i24v5SlCwKo o54ZVd6wP6rbcl00ezhOwfcWNYqydA24gBnd7WUUk+JCsHFaBLgcyKo7zhIgh7a/5Ah6 ODuA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=hjeN1LTi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p3si9255340pgi.0.2019.01.03.02.57.55; Thu, 03 Jan 2019 02:58:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=hjeN1LTi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729032AbfACICe (ORCPT + 99 others); Thu, 3 Jan 2019 03:02:34 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:41138 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726799AbfACICd (ORCPT ); Thu, 3 Jan 2019 03:02:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=N1HCgu/9K4V4ycQY5lpDdUrvXqrbs6vliV6vgmhMQeo=; b=hjeN1LTitYs39NSSyarC9ltuw HFa26YaNUPGl69BWXTqAy1ra1FET2JcwwpFduj/ngNKgTdogVbl8096ZAydzf42oUhUnad9iUGcWK fqV6jVhdMtqOsm0e0hYCRGWcexaFL/xwXS7xzfGw3axYGZ1WFiA/SQ/YOzcdjDJR4b5aw27Nfvmcz 7MlkaqzeKiQXxj8BYt3HexMDUqs7WyGRppJZkX+XMiNgUeyGb5ql1ShALbbW0Slr26EMHCkLdIyav /bhD8fu/JihREDIoQ46d2cHnT6js43FqXqJtAjQBYzCsBJkacGWHvT3YC/5KoMLX2JSLhhL6p//9C Jo6jshKwg==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gexxV-00061C-NC; Thu, 03 Jan 2019 08:02:29 +0000 Date: Thu, 3 Jan 2019 00:02:29 -0800 From: Christoph Hellwig To: Finn Thain Cc: Arnd Bergmann , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v8 05/25] char/nvram: Adopt arch_nvram_ops Message-ID: <20190103080229.GB11147@infradead.org> References: <66ed571883695314ace53080df8f6dfb132a8b4d.1545784679.git.fthain@telegraphics.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <66ed571883695314ace53080df8f6dfb132a8b4d.1545784679.git.fthain@telegraphics.com.au> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + > +const struct nvram_ops arch_nvram_ops = { > + .read_byte = nvram_read_byte, > + .write_byte = nvram_write_byte, > + .get_size = nvram_get_size, > +}; > +EXPORT_SYMBOL(arch_nvram_ops); I think something this internal should always be EXPORT_SYMBOL_GPL.