Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: RFC: gpio: mmio: add support for 3 direction regs
To:     "Fried, Ramon" <ramon.fried@linux.intel.com>,
        <linus.walleij@linaro.org>, <bgolaszewski@baylibre.com>,
        <linux-gpio@vger.kernel.org>
References: <32edfd70-95dc-26a1-2ea6-143344cb2384@linux.intel.com>
CC:     <linux-kernel@vger.kernel.org>,
        <vladimir.kondratiev@linux.intel.com>
From:   Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Message-ID: <ca7c1b99-4166-652b-aa53-8272aa66eb73@mentor.com>
Date:   Thu, 3 Jan 2019 10:07:11 +0200
User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101
 Icedove/45.2.0
MIME-Version: 1.0
In-Reply-To: <32edfd70-95dc-26a1-2ea6-143344cb2384@linux.intel.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Ramon,

On 01/03/2019 09:36 AM, Fried, Ramon wrote:
> Hi.
> 
> I'm working on a driver for STA2X11 GPIO controller who seems to fit
> best to the generic mmio driver,

I hope you have seen the existing driver drivers/gpio/gpio-sta2x11.c

> the only problem I have is with the dir register case. The STA2X11
> has 3 registers for dir, one for data, one for set and one for
> clear. The generic-mmio driver has support for this fashion for the
> dat & set & clear registers but not for dirout/dirin registers.
> 
> I wonder if support for this is generic enough to deserve a patch, if
> so I'm willing to quickly add this support, if not, adding a flag
> such as below, will allow partly using the generic mmio driver only
> for set/get and the direction can be handled outside the driver.
> 

If gpio-mmio fits well, then it might be simpler to set a flag
BGPIOF_UNREADABLE_REG_DIR, then call bgpio_init() and then overwrite
.direction_input, .direction_output and .get_direction callbacks,
as a reference you can take a look at gpio-74xx-mmio.c

--
Best wishes,
Vladimir