Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp564571imu; Thu, 3 Jan 2019 03:09:05 -0800 (PST) X-Google-Smtp-Source: AFSGD/UwRtyYU/LnSTi1vQh52HZqC9rr2AECX96Tg+zJVPLI2c7FNY7FbjpVLBA+Qan0+QQHycm/ X-Received: by 2002:a62:4e83:: with SMTP id c125mr48237232pfb.101.1546513745711; Thu, 03 Jan 2019 03:09:05 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1546513745; cv=pass; d=google.com; s=arc-20160816; b=bzZWivi5oAQ2tnqWLj0lqUt5yXZlWFkhTYI2xqbhZDPpCvH3SgoHKN/IZTjOp+kRow d45uSgoMdraCgE+vrPxP5+xZjFn9IKZYZaAWByMhjSnX8zTFxV/869eNOHLbCrotZVIX cvMyrqQoBqOQhKYSws1X+KMg9xJqNysZZDddVXwMSvWhk7ELIgcAgCWRWKryPvk2cNWS IM7JZRQByxLaZgn3mhb/+/Ljovy5wylCLCRmhO4zha2wM1K9lE8ognmkvpHboRhH+Uxy MFgxUaSwMTLrOsrZt6vcSjfen9n/oMgDHjfI+Pzii0tZLmoXou1ha41cmIcUXxXJ76AS 1bIA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:domainkey-signature; bh=le5j2hLw5GH/PW3GIzsYH2jGxnhrLnZ93bpxcuJQ8Vk=; b=zwfhUV3+y4Huy83l3yruQ7VznHJS5Ch7V1E9CjF4rD/7ov1KXLW+tPxvPCfNZcq4DJ vQo5r+bRmhtCkmi2cTVaHKa4RoNby/sVvcXHuLiYsQj3vFqQDVk7o+mpDsRZ/NdqVH6f ecteANiM6wrS0rAbqslp2QQaSrGambZI3Qi3WyKEs+Yq9JSwar00XtzQS3wZw9oVnRc6 6Ol7Vh1uwzTBmRqzKSfVdLqFnS7AAbu0kqfeRFsgsjC9iucptGLxrk7t9u+UAP8J3ltN CbAIHKTzHWyEEV82F31d7vMqN4st9nwKSAKQA4FIJNgzaDB60QXJa+S2R0uvSDV6kSUR XkPA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@zoho.com header.s=default header.b=T2WHc9eN; arc=pass (i=1 spf=pass spfdomain=zoho.com dkim=pass dkdomain=zoho.com dmarc=pass fromdomain=zoho.com>); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=zoho.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x5si53117499pgq.535.2019.01.03.03.08.50; Thu, 03 Jan 2019 03:09:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@zoho.com header.s=default header.b=T2WHc9eN; arc=pass (i=1 spf=pass spfdomain=zoho.com dkim=pass dkdomain=zoho.com dmarc=pass fromdomain=zoho.com>); spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=zoho.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728618AbfACIee (ORCPT + 99 others); Thu, 3 Jan 2019 03:34:34 -0500 Received: from sender-pp-092.zoho.com ([135.84.80.237]:25489 "EHLO sender-pp-092.zoho.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726191AbfACIee (ORCPT ); Thu, 3 Jan 2019 03:34:34 -0500 ARC-Seal: i=1; a=rsa-sha256; t=1546504469; cv=none; d=zoho.com; s=zohoarc; b=hsxd+IG5siAOer5zevSylQWsq2wWd4MRRGMxHdvIT8gxysGbN89zWlNuguxxwAB7vSvQT8Swftah/RU3AKOatA5Dfpso0sj/K2ErkopBVgTlmUoG8+BbPCk5qbrxs55DyPSHnFQSTFsGK1Ab5xPVLbIdXHrzGqDV3ZPoVUjiLJw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1546504469; h=Cc:Date:From:Message-ID:Subject:To:ARC-Authentication-Results; bh=le5j2hLw5GH/PW3GIzsYH2jGxnhrLnZ93bpxcuJQ8Vk=; b=bgzQoR2e33NTBTdP++mJYyT9hbII2LigLCaQ4scS/L88kgDzOqunSDaktmjgyG6hdKCNMGrmW6qzTM6FCxMSGW6gU/nSaP2fdZnN7bvPWWCGeuCSXKQERgfF7kfUbxI2yupBZurBEMfbkp7aQv4D8l8Vbk//20ct3yOJ47B9LVc= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass header.i=zoho.com; spf=pass smtp.mailfrom=yehs2007@zoho.com; dmarc=pass header.from= header.from= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=zapps768; d=zoho.com; h=from:to:cc:subject:date:message-id; b=IVqTgtIQWkhml9e6aCtyxZ/ZGW59gawrVaNgwpEcYp1eBBKIhTsBtdIH8EW8UM1IgmgrF8cAnPo7 1isxdU3kMojauQ8TQkIaqfYj4JBQhDTI95HwM6Q6l80ZY2GX6A/F DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1546504469; s=default; d=zoho.com; i=yehs2007@zoho.com; h=From:To:Cc:Subject:Date:Message-Id; l=897; bh=le5j2hLw5GH/PW3GIzsYH2jGxnhrLnZ93bpxcuJQ8Vk=; b=T2WHc9eNBILJ8eTxQZXmeoJMTTgu9DQB4ZJV9NatfHFjIZB0+dYkoFYPqUGscA6C PSs03WiaY0Ic2GX0HzhYpGRj2VdtLfCprbVZKNNWIT8TGdLoWITgCPhQ9M+yrBcFB7u dBib/CmGw4TkCr74f3bOFOc0bHMF4b3qpsXv6SZg= Received: from YEHS1XR956R00D1.lenovo.com (106.38.1.115 [106.38.1.115]) by mx.zohomail.com with SMTPS id 1546504468117807.9374932010533; Thu, 3 Jan 2019 00:34:28 -0800 (PST) From: Huaisheng Ye To: snitzer@redhat.com Cc: agk@redhat.com, hch@lst.de, dm-devel@redhat.com, linux-kernel@vger.kernel.org, chengnt@lenovo.com, Huaisheng Ye Subject: [PATCH 2/2] dm-writecache: get rid of memory_data flush to writecache_flush_entry Date: Thu, 3 Jan 2019 16:34:20 +0800 Message-Id: <20190103083420.8444-1-yehs2007@zoho.com> X-Mailer: git-send-email 2.17.0.windows.1 X-ZohoMailClient: External Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Huaisheng Ye writecache_flush_region only works when SSD mode. If wc->pmem_mode sets, writecache_flush_region doesn't need to be called in writecache_flush_entry. Signed-off-by: Huaisheng Ye --- drivers/md/dm-writecache.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/md/dm-writecache.c b/drivers/md/dm-writecache.c index 2d8e0c0..c69317c 100644 --- a/drivers/md/dm-writecache.c +++ b/drivers/md/dm-writecache.c @@ -688,8 +688,6 @@ static void writecache_poison_lists(struct dm_writecache *wc) static void writecache_flush_entry(struct dm_writecache *wc, struct wc_entry *e) { writecache_flush_region(wc, memory_entry(wc, e)); - if (WC_MODE_PMEM(wc)) - writecache_flush_region(wc, memory_data(wc, e)); } static bool writecache_entry_is_committed(struct dm_writecache *wc, struct wc_entry *e) -- 1.8.3.1