Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 3 Jan 2019 13:47:40 +0100
From:   Petr Mladek <pmladek@suse.com>
To:     Josh Poimboeuf <jpoimboe@redhat.com>
Cc:     Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
        Jason Baron <jbaron@akamai.com>,
        Joe Lawrence <joe.lawrence@redhat.com>,
        Evgenii Shatokhin <eshatokhin@virtuozzo.com>,
        live-patching@vger.kernel.org, linux-kernel@vger.kernel.org,
        Jessica Yu <jeyu@kernel.org>
Subject: Re: [PATCH v14 07/11] livepatch: Add atomic replace
Message-ID: <20190103124740.s3mpgmjw4no4qr6f@pathway.suse.cz>
References: <20181129094431.7801-1-pmladek@suse.com>
 <20181129094431.7801-8-pmladek@suse.com>
 <20181213225528.ies3kxjjtzl6dmd3@treble>
 <20181217152741.2i2trzjk5rmofgc3@pathway.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181217152741.2i2trzjk5rmofgc3@pathway.suse.cz>
User-Agent: NeoMutt/20170421 (1.8.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon 2018-12-17 16:27:41, Petr Mladek wrote:
> On Thu 2018-12-13 16:55:28, Josh Poimboeuf wrote:
> > On Thu, Nov 29, 2018 at 10:44:27AM +0100, Petr Mladek wrote:
> > Side note, it would probably be useful to have a klp_for_each_patch()
> > helper.
> 
> Will do.

Hmm, there are two possibilities:

1) #define klp_for_each_patch(patch)	\
	list_for_each_entry(patch, &klp_patches, list)

2) #define klp_for_each_patch(patches, patch)	\
	list_for_each_entry(patch, &patches, list)

Problems:

1st variant would need to declare klp_patches in
include/linux/livepatch.h. Josh did not like even
kernel/livepatch/core.h.

2nd variant looks ugly to me.


Alternative solution would be to move all klp_for_each*()
definitions from include/linux/livepatch.h to kernel/livepatch/core.h.
But there might be some users. I wonder if we use these
macros when preparing the cumulative patches.


As any solution looks controversial, I would prefer to postpone this change
after this patchset is accepted.

Best Regards,
Petr