Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Luck, Tony" <tony.luck@intel.com>
To:     liaoweixiong <liaoweixiong@allwinnertech.com>,
        Kees Cook <keescook@chromium.org>,
        Anton Vorontsov <anton@enomsg.org>,
        Colin Cross <ccross@android.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [RFC v4 0/3] pstore/rom: new support logger for block devices
Thread-Topic: [RFC v4 0/3] pstore/rom: new support logger for block devices
Thread-Index: AQHUozhqO1w/2T4wnE2emvMOu7brUqWdyBJA
Date:   Thu, 3 Jan 2019 17:18:49 +0000
Message-ID: <3908561D78D1C84285E8C5FCA982C28F7D4B623C@ORSMSX110.amr.corp.intel.com>
References: <1546501533-1855-1-git-send-email-liaoweixiong@allwinnertech.com>
In-Reply-To: <1546501533-1855-1-git-send-email-liaoweixiong@allwinnertech.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 11.0.400.15
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

I'm curious why you call this "pstore/rom" rather than the more descriptive "pstore/block".

It looks to be a really good idea.

I think you need to document how the "write" function for the block device must be written.
Since pstore calls this at "panic" time, the write path:

+ Cannot allocate any memory
+ Must be polled, not interrupt driven
+ Cannot take any locks that may be held by regular code
+ ... perhaps other restrictions that I can't think of right now

The memory allocation restriction is likely easy to get around. Just allocate anything
you need at pstore "init" time rather than waiting until the panic.

-Tony