Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 3 Jan 2019 10:41:32 -0700
From:   dann frazier <dann.frazier@canonical.com>
To:     "lipeng (Y)" <lipeng321@huawei.com>
Cc:     Salil Mehta <salil.mehta@huawei.com>, davem@davemloft.net,
        yisen.zhuang@huawei.com, mehta.salil@opnsrc.net,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        linuxarm@huawei.com
Subject: Re: [PATCH net-next] net: hns3: Config NIC port speed same as that
 of optical module
Message-ID: <20190103174132.GA19859@xps13.dannf>
References: <20181126184300.24964-1-salil.mehta@huawei.com>
 <20190101012205.GA22494@xps13.dannf>
 <aadad75b-a3fe-8bf1-77ce-14d3375ce4fd@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <aadad75b-a3fe-8bf1-77ce-14d3375ce4fd@huawei.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jan 02, 2019 at 08:45:36PM +0800, lipeng (Y) wrote:
> 
> 
> On 2019/1/1 9:22, dann frazier wrote:
> > On Mon, Nov 26, 2018 at 06:43:00PM +0000, Salil Mehta wrote:
> > > From: Peng Li <lipeng321@huawei.com>
> > > 
> > > Port 0/1 of HiP08 supports 10G and 25G. This patch adds a
> > > change to configure NIC port speed same as that of  optical
> > > module(SFP/QFSP). Driver gets the optical module speed and
> > > sets NIC port speed accordingly.
> > Hi,
> > 
> > I'm getting the following errors in dmesg about every 1s on a D06:
> > 
> > [  766.761823] hns3 0000:bd:00.0: get sfp speed failed -5
> > [  767.785823] hns3 0000:bd:00.0: get sfp speed failed -5
> > [  768.809820] hns3 0000:bd:00.0: get sfp speed failed -5
> > [  769.833818] hns3 0000:bd:00.0: get sfp speed failed -5
> > 
> > Reverting this patch fixes the issue.
> > 
> >   -dann
> Hi,dann,
> 
> Thanks for your test and report.
> 
> This patch needs to match new fireware verison ,
> And  it  does some work to  be Compatible with older versions.

I did upgrade to the latest available firmware (20181213-b20), but the
problem persisted. Maybe the necessary firmware is not yet released?

> Can you show me more information？
> can you  use "ethtool -i ethx" to get the fireware version ,
> and shows me  some other message about hns3?

Sure: 

$ sudo ethtool -i enp125s0f2
driver: hns3
version: 4.20.0+ SMP mod_unload aarch64
firmware-version: 0xb0311019
expansion-rom-version: 
bus-info: 0000:7d:00.2
supports-statistics: yes
supports-test: yes
supports-eeprom-access: no
supports-register-dump: yes
supports-priv-flags: no

  -dann