Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Reply-To: dgilbert@interlog.com
Subject: Re: [PATCH] scsi: associate bio write hint with WRITE CDB
To:     Randall Huang <ihhuang@abmail.org>,
        Christoph Hellwig <hch@infradead.org>
Cc:     huangrandall@google.com, jejb@linux.vnet.ibm.com,
        martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20181226041504.66283-1-huangrandall@google.com>
 <20190103075133.GA5141@infradead.org> <20190103094755.GA96532@google.com>
From:   Douglas Gilbert <dgilbert@interlog.com>
Message-ID: <e5bc96cd-1b48-3b7e-706f-4cbbd1a040a4@interlog.com>
Date:   Thu, 3 Jan 2019 16:00:13 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <20190103094755.GA96532@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-CA
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2019-01-03 4:47 a.m., Randall Huang wrote:
> On Wed, Jan 02, 2019 at 11:51:33PM -0800, Christoph Hellwig wrote:
>> On Wed, Dec 26, 2018 at 12:15:04PM +0800, Randall Huang wrote:
>>> In SPC-3, WRITE(10)/(16) support grouping function.
>>> Let's associate bio write hint with group number for
>>> enabling StreamID or Turbo Write feature.
>>>
>>> Signed-off-by: Randall Huang <huangrandall@google.com>
>>> ---
>>>   drivers/scsi/sd.c | 14 ++++++++++++--
>>>   1 file changed, 12 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c
>>> index 4b49cb67617e..28bfa9ed2b54 100644
>>> --- a/drivers/scsi/sd.c
>>> +++ b/drivers/scsi/sd.c
>>> @@ -1201,7 +1201,12 @@ static int sd_setup_read_write_cmnd(struct scsi_cmnd *SCpnt)
>>>   		SCpnt->cmnd[11] = (unsigned char) (this_count >> 16) & 0xff;
>>>   		SCpnt->cmnd[12] = (unsigned char) (this_count >> 8) & 0xff;
>>>   		SCpnt->cmnd[13] = (unsigned char) this_count & 0xff;
>>> -		SCpnt->cmnd[14] = SCpnt->cmnd[15] = 0;
>>> +		if (rq_data_dir(rq) == WRITE) {
>>> +			SCpnt->cmnd[14] = rq->bio->bi_write_hint & 0x3f;
>>> +		} else {
>>> +			SCpnt->cmnd[14] = 0;
>>> +		}
>>
>> No need for braces here.
> Already send a new version
>>
>> But what I'm more worried about is devices not recognizing the feature
>> throwing up on the field.  Can you check what SBC version first
>> references these or come up with some other decently smart conditional?
> My reference is SCSI Block Commands – 3 (SBC-3) Revision 25.
> Section 5.32 WRITE (10) and 5.34 WRITE (16)
> 
>> Maybe Martin has a good idea, too.
> 

That is the GROUP NUMBER field. Also found in READ(16) at the same
location within its cdb. The proposed code deserves at least an
explanatory comment.

Since it is relatively recent, perhaps the above should only be done iff:
    - the REPORT SUPPORTED OPERATION CODES (RSOC) command is supported, and
    - in the RSOC entry for WRITE(16), the CDB USAGE DATA field (a bit mask)
      indicates the GROUP NUMBER field is supported

That check can be done once, at disk attachment time where there is already
code to fetch RSOC.


Is there a bi_read_hint ? If not then the bi_write_hint should also be applied
to READ(16). Makes that variable naming look pretty silly though.

Doug Gilbert