Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-PHdr: =?us-ascii?q?9a23=3AYo0aJx9syPN0H/9uRHKM819IXTAuvvDOBiVQ1KB4?=
 =?us-ascii?q?2+gcTK2v8tzYMVDF4r011RmVBdWds6oMotGVmpioYXYH75eFvSJKW713fDhBt/?=
 =?us-ascii?q?8rmRc9CtWOE0zxIa2iRSU7GMNfSA0tpCnjYgBaF8nkelLdvGC54yIMFRXjLwp1?=
 =?us-ascii?q?Ifn+FpLPg8it2O2+557ebx9UiDahfLh/MAi4oQLNu8cMnIBsMLwxyhzHontJf+?=
 =?us-ascii?q?RZ22ZlLk+Nkhj/+8m94odt/zxftPw9+cFAV776f7kjQrxDEDsmKWE169b1uhTF?=
 =?us-ascii?q?UACC+2ETUmQSkhpPHgjF8BT3VYr/vyfmquZw3jSRMNboRr4oRzut86ZrSAfpiC?=
 =?us-ascii?q?gZMT457HrXgdF0gK5CvR6tuwBzz4vSbYGQNfp+ZbjdfdIcRWpOQ81fSTVPCZ6y?=
 =?us-ascii?q?b4sOEeUBOftXpJT5q1YAsReyAA+hD/7txDBVnH/7xa003fo8Hw/I3wIuGMkDvG?=
 =?us-ascii?q?jIoNjvKKsfS/y5wLXOwD7eb/1WwzD96I3Qfx8joPGNXLJwcdfWyUIyEA7EjlSR?=
 =?us-ascii?q?qYz/MDOUyugBr2aW4vF9Ve2zkW4rsR9+rSWyxso1jITCm4Ebykjc+Cln3Io4Ic?=
 =?us-ascii?q?e0RU17bNK+Dpdcqi6XO5FrTs4mQGxkoDs2x7wCtJKhYiQHxpQqywTBZ/GGaYSF?=
 =?us-ascii?q?4B3uWeCMKjlinn1lYqiwhxOq/Eilze3zS9e73U5RripAjtnMrncN1wHP6sSfSv?=
 =?us-ascii?q?ty4EOh2TGX2gDW8O5EIEQ0mbPDK54l37I8j5QTvVnHEyL1gkn2g6iWdkIr+uis?=
 =?us-ascii?q?9evreKnpppiZN4NsiwH+NLohmtCnDOgmLgQDW3KX9Oe82bH540H1XbpHgucrnq?=
 =?us-ascii?q?Tds53WPcEbqbS4Aw9R3IYj8RG/DzK+3dUYnHgHLEhKeBObg4T1NVzDO+34Auul?=
 =?us-ascii?q?g1i2jjhk2u3GMqX7AprRNnjDjKvhfbFl5k5YyQozy81f5p1NBrECPv3zQEnxu8?=
 =?us-ascii?q?LcDhIiLQy0zPjoCM9n2oMdR22PGKmZP73WsVOS4eIvOeaMN8c7ojH4fskk9f7z?=
 =?us-ascii?q?ijdtiE0ddKjxhcA/dXuiWPlqPhPKMjLXnt4dHDJS7UIFR+vwhQjHDmZe?=
From:   Yizhuo <yzhai003@ucr.edu>
Cc:     csong@cs.ucr.edu, zhiyunq@cs.ucr.edu, Yizhuo <yzhai003@ucr.edu>,
        Bard Liao <bardliao@realtek.com>,
        Oder Chiou <oder_chiou@realtek.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH] Variable "val" in function rt274_i2c_probe() could be uninitialized
Date:   Thu,  3 Jan 2019 13:59:12 -0800
Message-Id: <20190103215912.6071-1-yzhai003@ucr.edu>
To:     unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Inside function rt274_i2c_probe(), if regmap_read() function
returns -EINVAL, then local variable "val" leaves uninitialized
but used in if statement. This is potentially unsafe.

Signed-off-by: Yizhuo <yzhai003@ucr.edu>
---
 sound/soc/codecs/rt274.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/sound/soc/codecs/rt274.c b/sound/soc/codecs/rt274.c
index 8f92e5c4dd9d..cd048df76232 100644
--- a/sound/soc/codecs/rt274.c
+++ b/sound/soc/codecs/rt274.c
@@ -1128,8 +1128,11 @@ static int rt274_i2c_probe(struct i2c_client *i2c,
 		return ret;
 	}
 
-	regmap_read(rt274->regmap,
+	ret = regmap_read(rt274->regmap,
 		RT274_GET_PARAM(AC_NODE_ROOT, AC_PAR_VENDOR_ID), &val);
+	if (ret)
+		return ret;
+
 	if (val != RT274_VENDOR_ID) {
 		dev_err(&i2c->dev,
 			"Device with ID register %#x is not rt274\n", val);
-- 
2.17.1