Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 1/2 v4] kdump: add the vmcoreinfo documentation
To:     Kazuhito Hagio <k-hagio@ab.jp.nec.com>
Cc:     "bhe@redhat.com" <bhe@redhat.com>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "kexec@lists.infradead.org" <kexec@lists.infradead.org>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "dyoung@redhat.com" <dyoung@redhat.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20181220054044.30738-1-lijiang@redhat.com>
 <20181220054044.30738-2-lijiang@redhat.com>
 <4AE2DC15AC0B8543882A74EA0D43DBEC035656E1@BPXM09GP.gisp.nec.co.jp>
From:   lijiang <lijiang@redhat.com>
Message-ID: <bf26e868-9dfd-5344-df56-df8ff0442df0@redhat.com>
Date:   Fri, 4 Jan 2019 10:28:20 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <4AE2DC15AC0B8543882A74EA0D43DBEC035656E1@BPXM09GP.gisp.nec.co.jp>
Content-Type: text/plain; charset=iso-2022-jp
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

在 2019年01月04日 03:28, Kazuhito Hagio 写道:
> Hi Lianbo,
> 
> -----Original Message-----
>> +=======================
>> +What is the VMCOREINFO?
>> +=======================
>> +
>> +VMCOREINFO is a special ELF note section. It contains various
>> +information from the kernel like structure size, page size, symbol
>> +values, field offsets, etc. These data are packed into an ELF note
>> +section and used by user-space tools like crash and makedumpfile to
>> +analyze a kernel's memory layout.
>> +
>> +To dump the VMCOREINFO contents, one can do:
>> +
>> +# makedumpfile -g VMCOREINFO -x vmlinux
> 
> again, this command does not dump the VMCOREINFO in ELF note section.
> It converts the vmlinux's debug infomation into a VMCOREINFO-like data.
> So I don't think this command is suitable to introduce here.
> 

Thank you, Kazu.

As you mentioned, makedumpfile in 'devel' branch can print VMCOREINFO in /proc/kcore,
can i add the following command to this document?

#makedumpfile --mem-usage /proc/kcore -D

>> +PG_lru|PG_private|PG_swapcache|PG_swapbacked|PG_slab|
>> +PG_hwpoision|PG_head_mask
>> +-----------------------------------------------------
>> +
>> +Page attributes. These flags are used to filter free pages.
> 
> Some of these are not used to filter *free* pages, so
> 
> ... used to filter various unnecessary pages.
> 

Great. I will modify it in next post.

And also merge the 'PG_buddy' and 'PG_offline'  into the PG_* flag here.

Many thanks.

Lianbo

>> +PAGE_BUDDY_MAPCOUNT_VALUE or ~PG_buddy
>> +--------------------------------------
> 
> then, this can be merged into the one above?
> 
>> +======
>> +x86_64
>> +======
> ...
>> +PAGE_OFFLINE_MAPCOUNT_VALUE(~PG_offline)
>> +----------------------------------------
> 
> This looks not only for x86_64, and also can be merged into
> the PG_* flags?
> 
> Thank you for your effort!
> Kazu
> 
>