Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp362019imu; Thu, 3 Jan 2019 22:12:08 -0800 (PST) X-Google-Smtp-Source: ALg8bN7Ae2OmU0RR+jjD/vkBgunxVVSv3QMD4rYydILQ8wWV6k9J2lmaigQMaP48/Kf65797SmPR X-Received: by 2002:a63:cf02:: with SMTP id j2mr558177pgg.113.1546582328547; Thu, 03 Jan 2019 22:12:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546582328; cv=none; d=google.com; s=arc-20160816; b=M+bpb+fSkHBUBR1vmhe+3cyu+2jtnuEmx8JuLizXJgGpbQQTh/XChezsRfGao01Uwe jY+wM4hRcW0OjJRwFE4vC/E7m75S4p361H+3R9DmZP0PA3ejMfKwdF9vb8PKWTN6AUl9 Cc8fT850CiUQvqnX8tAhKSEZEwgaSHlQzSO1Rnv2AaB0dybDbR2w7sepZtPvtvxA1rEL zJn+sMVbx+c5kMpl7UDv4Zs5dsVA2utkASs4iMS9m9AWTM5y5zSZ5T5+SNLgiDfX/zq7 3f2d1dtXqJLDVu2g5Bhh79bAe1+W9BaGtQq+CYMkzdca35XxopHO72LoD6YAUNMzVEKj 868w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=lnZyZxInsEGzw3p+CHzSj/KoRA1xvwNXjnGuZgXYi7w=; b=vRq24o5nbsQq9wukqvdZxdpR7wthUSopfIvrdQ2zwuXphp0ZdRhbpGfk6ySuu/NYoC rio1iX+Be2na8srChEmLImJzeeGxlExxVuM91Ho5nSdrV3JTr/FI8i+avF5z6Uo6ezsU wLZFv70K7S2MC681sQthGESzv3MM0LmBIG5pFXhhWrTNaqCHo0tvyF3tT356Mi7/0Qx1 JZMWVE2V0IX1hHHzHepgfiXMXqE+7sx4Sg7EQKJeBl+9V+oB80PovQMp84kjdbe3XO43 z9vzCraA5Q0zwmimPoY2t1jeWscyxCElb2blGGRFbwYMQeJfCWZa5p+qpxTd1+eW0wbz ge/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=L4Ifof17; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q8si4864438pli.284.2019.01.03.22.11.53; Thu, 03 Jan 2019 22:12:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=L4Ifof17; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726728AbfADC6m (ORCPT + 99 others); Thu, 3 Jan 2019 21:58:42 -0500 Received: from mail-yw1-f65.google.com ([209.85.161.65]:33163 "EHLO mail-yw1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726418AbfADC6m (ORCPT ); Thu, 3 Jan 2019 21:58:42 -0500 Received: by mail-yw1-f65.google.com with SMTP id p65so12904611ywe.0; Thu, 03 Jan 2019 18:58:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lnZyZxInsEGzw3p+CHzSj/KoRA1xvwNXjnGuZgXYi7w=; b=L4Ifof17nm6xvC3XORaZeQ1faFZUC8b2yS4lCzUyfN/2LV/Ob0Ig2f6da1cVmbaGOb aygrZpYqYCaxIFG2Dc1yMnz09BFnMk9ISS5sd1M7Zl2x5/XLnKDVfuEjXaxCUAA+Gc75 TjR5VCCbkf8TyKmEaVZsA/Ajweu8nwALF/AjjjOOmlPVwm/wU6HrXVslwP8efInc3RpX 7uZCHZ1J3dYk9/2DswIf3Ed55wdDgmpJPr3PGDqMg24l1psgL03cTgWozodg60wWt72e 3znvkJahNhVH5xEdcjbBFR09/EyoMkbZjIDWY6knd1/2n6NOfmsnOCJjEZraoOOG06Ao 9Rgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lnZyZxInsEGzw3p+CHzSj/KoRA1xvwNXjnGuZgXYi7w=; b=Lj3ApC0q6xVtza/Z7WW3ufY+yxDaooz6Sx+N4MY4vzYUYOQQ/os5uNYgfwM/QF/NMO iNDDmvVy2hj9ce5QgK/9f92pLTIMy38laqxkIPDX/AY04DIe5aUdZLgVIWxu0DpgjeK7 IewH/Wb9QOaqgJXMTj8LivtWuTedxZoaY64i/wpAl1i/Zns2rmq9tM3TXBpsKmyrP7EB 52Q7+M8zkbbBrDw+aIu+q5VwbumYIj8w6ShECjxStcpb/k8Ejqqc8mHMaaZRw54DOFyA 46FlQhVqKoDxyoj1Y2td6P0c9+8VAD00W/c0cEdU1Z5ME/+HyNnIAH8YWTvb7LL4PQVG wAiQ== X-Gm-Message-State: AA+aEWajc4jmlkBm3h4Q6MSK3e1GvlYoZCHQpGI9eYuJ8NAvXgg+TWSa Sv8D3bkqIcBDz/u4eZNeNFUZxRZ7nMgHD3ob/jU= X-Received: by 2002:a0d:ea81:: with SMTP id t123mr50777073ywe.496.1546570721432; Thu, 03 Jan 2019 18:58:41 -0800 (PST) MIME-Version: 1.0 References: <1546442912-20818-1-git-send-email-firoz.khan@linaro.org> <1546442912-20818-2-git-send-email-firoz.khan@linaro.org> In-Reply-To: <1546442912-20818-2-git-send-email-firoz.khan@linaro.org> From: Max Filippov Date: Thu, 3 Jan 2019 18:58:30 -0800 Message-ID: Subject: Re: [PATCH 1/2] xtensa: remove nargs from __SYSCALL To: Firoz Khan Cc: Chris Zankel , Dominik Brodowski , linux-xtensa@linux-xtensa.org, Greg Kroah-Hartman , Philippe Ombredanne , Thomas Gleixner , Kate Stewart , y2038@lists.linaro.org, LKML , Linux-Arch , Arnd Bergmann , Deepa Dinamani , marcin.juszkiewicz@linaro.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 2, 2019 at 7:29 AM Firoz Khan wrote: > > The __SYSCALL macro's arguments are system call number, > system call entry name and number of arguments for the > system call. > > Argument- nargs in __SYSCALL(nr, entry, nargs) is neither > calculated nor used anywhere. So it would be better to > keep the implementaion as __SYSCALL(nr, entry). This will > unifies the implementation with some other architetures > too. Perhaps "This will help unify the implementation with other architectures"? > Signed-off-by: Firoz Khan > --- > arch/xtensa/kernel/syscall.c | 2 +- > arch/xtensa/kernel/syscalls/syscalltbl.sh | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/xtensa/kernel/syscall.c b/arch/xtensa/kernel/syscall.c > index 2c415fc..0665339 100644 > --- a/arch/xtensa/kernel/syscall.c > +++ b/arch/xtensa/kernel/syscall.c > @@ -31,7 +31,7 @@ > syscall_t sys_call_table[__NR_syscalls] /* FIXME __cacheline_aligned */= { > [0 ... __NR_syscalls - 1] = (syscall_t)&sys_ni_syscall, > > -#define __SYSCALL(nr, entry, nargs)[nr] = (syscall_t)entry, > +#define __SYSCALL(nr, entry)[nr] = (syscall_t)entry, > #include > #undef __SYSCALL > }; > diff --git a/arch/xtensa/kernel/syscalls/syscalltbl.sh b/arch/xtensa/kernel/syscalls/syscalltbl.sh > index 85d78d9..904b8e6 100644 > --- a/arch/xtensa/kernel/syscalls/syscalltbl.sh > +++ b/arch/xtensa/kernel/syscalls/syscalltbl.sh > @@ -13,10 +13,10 @@ emit() { > t_entry="$3" > > while [ $t_nxt -lt $t_nr ]; do > - printf "__SYSCALL(%s, sys_ni_syscall, )\n" "${t_nxt}" > + printf "__SYSCALL(%s,sys_ni_syscall)\n" "${t_nxt}" Please add space after the comma. > t_nxt=$((t_nxt+1)) > done > - printf "__SYSCALL(%s, %s, )\n" "${t_nxt}" "${t_entry}" > + printf "__SYSCALL(%s,%s)\n" "${t_nxt}" "${t_entry}" Ditto. > } > > grep -E "^[0-9A-Fa-fXx]+[[:space:]]+${my_abis}" "$in" | sort -n | ( > -- > 1.9.1 With the above changes: Acked-by: Max Filippov -- Thanks. -- Max