Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp533153imu; Fri, 4 Jan 2019 02:29:04 -0800 (PST) X-Google-Smtp-Source: ALg8bN4kyubcO4wVy1L/8dmOBIfut+FtPcoOuNBzpMg6/RlTZpNqFULxpYY7gsGdEIowp+9sC3Vh X-Received: by 2002:a17:902:45:: with SMTP id 63mr48619385pla.272.1546597744572; Fri, 04 Jan 2019 02:29:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546597744; cv=none; d=google.com; s=arc-20160816; b=GBP1IeYIkOqKhB/Pq/fqG+TVRjKT/ZTBRf/p7zzhvri77Y6NYAEupY6RrRR4z+8Gj8 yMBQeHE7/Umqq1XtIAEZvTFqErChmOfGg+d76wtxWQFQyhgC9oTgbtROtxP83Bbb5I8j /WtDIROBnrc3Lcg+LlIw/1rCroCQKtmaloBshiG6kmy3JYAeHqHHZR61DmlepS6BLDO+ lsi4kT2c6C7IKOB+A3CZ+b5O70eQQxFI90APDw1Avial7/hOXXi0+ODzKU7N4QkstQsP 73mqVm2idJVMbm8XUsPgP8M8/gXg3iHVo27EgppAnvyU/Dqqo1az+40l9YcKnD1GZ99A sVuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=rro8edKkspDsyyMgwTCAKGZP90S23S8Mpy2HGaolC+U=; b=FXTwiT+2TTRHxamRkOdJbfEHTEswkYsVcWHBhAICCwrFp6NvvfNncnGYAosuxK+XYI FScHRATNvO5dO3JxYu+VUsszeV1tnbEDDC2xWIvcGTjVpEl+j6+R7FSQduETWzQK0woU AHEVz5Fs8z3/lF9V/WunbrfHd7SNEvAN9dg9LXSxeJMIluwV4CT7BVLHZZ5XLYJI14c+ OUzxe8hmlu6FdkJq0XP4nBhEiEjORDfjRxK/qJAzoabMuJoF7pCncfhNI0SVd/hcQMvb H/gecY3e7Ygz629KlTYRZQ+5PwMBahHVFSRcUq6pzGDrogYHxA9vt3SoB+XSj4N4z7Cn /ekA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=v54FwiM+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u27si9616896pfa.103.2019.01.04.02.28.49; Fri, 04 Jan 2019 02:29:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=v54FwiM+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727261AbfADJIq (ORCPT + 99 others); Fri, 4 Jan 2019 04:08:46 -0500 Received: from mail-ed1-f67.google.com ([209.85.208.67]:34789 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725913AbfADJIq (ORCPT ); Fri, 4 Jan 2019 04:08:46 -0500 Received: by mail-ed1-f67.google.com with SMTP id b3so31276169ede.1 for ; Fri, 04 Jan 2019 01:08:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=rro8edKkspDsyyMgwTCAKGZP90S23S8Mpy2HGaolC+U=; b=v54FwiM+HJcwereFzem42m0Q+PUWYc4Qmcn7F742Drr8zKDSFetWKWaIS8mNrC4hCd JA0z4EdreTPJSu9d/t9SMUCZFh+XNi2hD0eQNk/fqiis9v3HXjE72gbSDszWY/cPlvIB w5vnVZHNn4AbopXwoWVJocDQVE76agb8d1OHVujkRpnhvcpWinQ0vR2/JhVDYy+UeeTv /jewQ02JTz0ueomyhWOqlOxdk6s4ztjabHbM1mluh5SEurEtF53+yBn/Hrke2iS1XERy E/8AvLWa7Cni+3LCcHr9KiqbFjPHOUK2W89RxNZ9ojWRERkGI9pMKE4REJVTe3fm/4ny /KEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=rro8edKkspDsyyMgwTCAKGZP90S23S8Mpy2HGaolC+U=; b=ovEZbu9e3sGnbzgMvVUQrHUnwXctFEaE9XE5sWGstTBIzdFlsxzTIYePpEmwQg0uiq 0/KJXRwHnm1auo6Tczd+y1FwJObyiz1mi9I97ElaTsiMCHc88HElJx3DwNy1w/8hCwti o7YEKW/JlHBCgSvhfEJd43GocokhR4PlJ4fpF6gJ77viykcug/A0Zm1MqNXABRMMpMhI UCtGV1V3KTX/z0hyTVDDAkbDaz3RrWI8B8oiMd+ylK466Rt8kJYksIM8NFcLA2z08CEY nQqSQ52gm/W4F2FdW52UMpy2fBdCxHV1Mh4wYlxZFiq/yhVcoIv4JpquSPKFSW45Pu3d s9aw== X-Gm-Message-State: AA+aEWbrTZcoTq6eiukB/WNqCf5lQNkmV/bU3+47UXls6o7opC8xYh/Q F7RU1VX78Tr5ur6ZDC8t423E5Q== X-Received: by 2002:a17:906:f04:: with SMTP id z4-v6mr38740333eji.106.1546592924349; Fri, 04 Jan 2019 01:08:44 -0800 (PST) Received: from localhost.localdomain ([51.15.160.169]) by smtp.googlemail.com with ESMTPSA id o37sm24706587edc.32.2019.01.04.01.08.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 04 Jan 2019 01:08:43 -0800 (PST) From: Corentin Labbe To: bhelgaas@google.com, khilman@baylibre.com, lorenzo.pieralisi@arm.com Cc: linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, Corentin Labbe Subject: [PATCH] PCI: amlogic: fix build failure due to missing linux/gpio/consumer.h header Date: Fri, 4 Jan 2019 09:08:37 +0000 Message-Id: <1546592917-27846-1-git-send-email-clabbe@baylibre.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When building on x86, I got the following build failure: drivers/pci/controller/dwc/pci-meson.c: In function ‘meson_pcie_assert_reset’: drivers/pci/controller/dwc/pci-meson.c:290:2: error: implicit declaration of function ‘gpiod_set_value_cansleep’; did you mean ‘gpio_set_value_cansleep’? [-Werror=implicit-function-declaration] gpiod_set_value_cansleep(mp->reset_gpio, 0); ^~~~~~~~~~~~~~~~~~~~~~~~ gpio_set_value_cansleep drivers/pci/controller/dwc/pci-meson.c: In function ‘meson_pcie_probe’: drivers/pci/controller/dwc/pci-meson.c:540:19: error: implicit declaration of function ‘devm_gpiod_get’; did you mean ‘devm_gpio_free’? [-Werror=implicit-function-declaration] mp->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); ^~~~~~~~~~~~~~ devm_gpio_free drivers/pci/controller/dwc/pci-meson.c:540:48: error: ‘GPIOD_OUT_LOW’ undeclared (first use in this function); did you mean ‘GPIOF_INIT_LOW’? mp->reset_gpio = devm_gpiod_get(dev, "reset", GPIOD_OUT_LOW); ^~~~~~~~~~~~~ GPIOF_INIT_LOW This is due to the missing linux/gpio/consumer.h header Signed-off-by: Corentin Labbe --- drivers/pci/controller/dwc/pci-meson.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/pci/controller/dwc/pci-meson.c b/drivers/pci/controller/dwc/pci-meson.c index 241ebe0c4505..e35e9eaa50ee 100644 --- a/drivers/pci/controller/dwc/pci-meson.c +++ b/drivers/pci/controller/dwc/pci-meson.c @@ -8,6 +8,7 @@ #include #include +#include #include #include #include -- 2.19.2