Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp714889imu; Fri, 4 Jan 2019 05:58:48 -0800 (PST) X-Google-Smtp-Source: ALg8bN597ofNxrOF0cOesRpoZoeLZ7kSykghPpD1YcYb8ij7cnxGnCQZ1GG2gpdG84Npyc2tagee X-Received: by 2002:a17:902:4523:: with SMTP id m32mr50913376pld.53.1546610328265; Fri, 04 Jan 2019 05:58:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546610328; cv=none; d=google.com; s=arc-20160816; b=xniHR5Ms9Cx+vHu/0/7IULv/+Y/RoIc5Yuk82sO0v1xDwFsgnB621CNKhSwmblYj8s Pq6j1uuTh6E1tmmN9z725SUA/3rufv2rNAtXH+6QM4a5JIRElp9BbotfJo60tyFVpeo1 xNc3r8fElNgYVNScepNFQ0tvsYxgWDVktv/0jCnx12ltK77tJagtTj/hpCvZPqJJGXJw ugKYtJylIekI7E2tUfmEoCmiSEjSUTtGVbev3V8EBIjpUxUBrH3PULr2Nv8nOlpBAYSv UQCmw7Crw2bgsRzRiUCeMrmLbAwxNqojDynyufZFs6Fo3WsGyfxFoVxOAs9sLGe7jny3 Fb9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=O+/jdQcbC4Y3zvrZhuOaDfrBkZxC2eABBHF3kSYBxts=; b=yD/87iS1ExhlMcz8V3V9/XLGXwSazLDrGYc+Rg0as1viCdPOD/icBL6Ke43JTVdzkC tp0tgxTIN7b+0+OSpmqicxLki2jzsccCRnix/9dumffQI6sLt+vpmOo4flTc4LxxRu2u qYSvM7udL6C37nC0PU9nZifAfEpSMBroXdceBFvC1SsWC+McCI3ufKrmrtazqHBac/IA CDwWLMqE3dFtdlOQe6pYr5kzej5ra0riYjK0SDzjd+DA9ybhFTFCRtWQoW/XSJLBsnbz NAEKMfdOpUuNOMgzAgUYSAEhQzvfEs2cMFFLwQG4LoENpPjdHPdrGZ6XddcX8I9IT+X3 g1RA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p4si7509822pgm.342.2019.01.04.05.58.17; Fri, 04 Jan 2019 05:58:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728149AbfADMEn (ORCPT + 99 others); Fri, 4 Jan 2019 07:04:43 -0500 Received: from mail.cn.fujitsu.com ([183.91.158.132]:54829 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726135AbfADMEm (ORCPT ); Fri, 4 Jan 2019 07:04:42 -0500 X-IronPort-AV: E=Sophos;i="5.56,438,1539619200"; d="scan'208";a="51282912" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 04 Jan 2019 20:04:40 +0800 Received: from G08CNEXCHPEKD02.g08.fujitsu.local (unknown [10.167.33.83]) by cn.fujitsu.com (Postfix) with ESMTP id 574344B7D68F; Fri, 4 Jan 2019 20:04:42 +0800 (CST) Received: from TSAO.g08.fujitsu.local (10.167.226.60) by G08CNEXCHPEKD02.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 4 Jan 2019 20:04:40 +0800 From: Cao jin To: , , , CC: , Subject: [PATCH] x86/boot: comments cleanup & indentation fix Date: Fri, 4 Jan 2019 20:04:28 +0800 Message-ID: <20190104120428.26847-1-caoj.fnst@cn.fujitsu.com> X-Mailer: git-send-email 2.17.2 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.167.226.60] X-yoursite-MailScanner-ID: 574344B7D68F.AAB64 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: caoj.fnst@cn.fujitsu.com X-Spam-Status: No Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org No real code modification, just cleanup: 1. remove redundant comments which have already appeared above 2. comments improvement: "aligned to a 2M boundary" --> "aligned up to CONFIG_PHYSICAL_ALIGN boundary" 3. typo fix: uncompression --> decompression 4. indentation fix in linker script: spaces -> tab Signed-off-by: Cao jin --- arch/x86/boot/compressed/head_64.S | 13 +++++-------- arch/x86/boot/compressed/vmlinux.lds.S | 4 ++-- 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/arch/x86/boot/compressed/head_64.S b/arch/x86/boot/compressed/head_64.S index 64037895b085..58f6a467f1fa 100644 --- a/arch/x86/boot/compressed/head_64.S +++ b/arch/x86/boot/compressed/head_64.S @@ -90,9 +90,6 @@ ENTRY(startup_32) jnz no_longmode /* - * Compute the delta between where we were compiled to run at - * and where the code will actually run at. - * * %ebp contains the address we are loaded at by the boot loader and %ebx * contains the address where we should move the kernel image temporarily * for safe in-place decompression. @@ -272,12 +269,12 @@ ENTRY(startup_64) /* * Compute the decompressed kernel start address. It is where - * we were loaded at aligned to a 2M boundary. %rbp contains the - * decompressed kernel start address. + * we were loaded at aligned up to CONFIG_PHYSICAL_ALIGN boundary. + * %rbp contains the decompressed kernel start address. * * If it is a relocatable kernel then decompress and run the kernel - * from load address aligned to 2MB addr, otherwise decompress and - * run the kernel from LOAD_PHYSICAL_ADDR + * from load address aligned up to CONFIG_PHYSICAL_ALIGN, otherwise + * decompress and run the kernel from LOAD_PHYSICAL_ADDR * * We cannot rely on the calculation done in 32-bit mode, since we * may have been invoked via the 64-bit entry point. @@ -525,7 +522,7 @@ relocated: */ pushq %rsi /* Save the real mode argument */ movq %rsi, %rdi /* real mode address */ - leaq boot_heap(%rip), %rsi /* malloc area for uncompression */ + leaq boot_heap(%rip), %rsi /* malloc area for decompression */ leaq input_data(%rip), %rdx /* input_data */ movl $z_input_len, %ecx /* input_len */ movq %rbp, %r8 /* output target address */ diff --git a/arch/x86/boot/compressed/vmlinux.lds.S b/arch/x86/boot/compressed/vmlinux.lds.S index f491bbde8493..c07c8aba0755 100644 --- a/arch/x86/boot/compressed/vmlinux.lds.S +++ b/arch/x86/boot/compressed/vmlinux.lds.S @@ -64,8 +64,8 @@ SECTIONS _ebss = .; } #ifdef CONFIG_X86_64 - . = ALIGN(PAGE_SIZE); - .pgtable : { + . = ALIGN(PAGE_SIZE); + .pgtable : { _pgtable = . ; *(.pgtable) _epgtable = . ; -- 2.17.0