Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp880670imu; Fri, 4 Jan 2019 08:50:44 -0800 (PST) X-Google-Smtp-Source: AFSGD/V7/idO+tkIrP3K4eXx5Qfk8lhKFGZBDUIImfrMn6xFg/ewgblZyrdllshuX010cDu0wDjd X-Received: by 2002:a62:5e41:: with SMTP id s62mr52396314pfb.232.1546620644285; Fri, 04 Jan 2019 08:50:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546620644; cv=none; d=google.com; s=arc-20160816; b=SkF2HugOP13khMwD3s2sDdDbPBVxGROAnH9DcfVo6kQOUGL4cBDtvG1bpK+GwrXWIl D3tyX8+BmdHtY57Zlozzmiu8Bb0zqMR1xHkeBhHTnUZb43eY2APFg1ZS/TronGNQ7tYC AN2hWP6LrEMtGXmpxHiu3OEbwTYj/fk616jTK2DuFQUMXUQW3d5OXGDUL9pDgMjM14xq LKK2lh87tjn2joUs6u2SfgqARS+ZD0IdfahchKZC9J8Bcb47S1icLlR+GOkY8t1ivbTL pjRQsCF1P6uu5CfkI4ZQyVAtmCqvGpYkUDw/sZ63r8u0QupR9e1UIesglBmTXmOgzeuG McKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature; bh=e0fBSdAO5PjtDC0wVBHORxbqwBWBFdz5+Jgee6FFlAc=; b=rRf4ajeBwyHWKqoJgUaDzJjPW5dy/nH6hUzuhkY5NpMZFb92k66FJLKk4k3hAQP+Ng xu1mvgqyNQr+FuYL7m9XmSnNGueVv4MJ+23CxzzXVYH+bCOkUhc3+gI5cO8ZPVOx9mnX MCsw9H1QFevtk7xbLGCix4+rivy6p9Ukpjf3vg/pAhNN8fJdwnk4/eeat7Jo+9DyxbsY WaFJnP5G/dvIWQm+vOumdT0egmJn02uL3mTb/MW8V5tgB6K2plVyBxf0XzlK36HdYvMG gVZE/hHKEwTraifdhS4LBj/ADNvaad5pz90uujwDozxMoZQwI52GHQkLvQE9UhxzBSMm fkCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=jAC0nW3q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h1si10400821plt.44.2019.01.04.08.50.29; Fri, 04 Jan 2019 08:50:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=jAC0nW3q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727446AbfADOBM (ORCPT + 99 others); Fri, 4 Jan 2019 09:01:12 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:53080 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726262AbfADOBM (ORCPT ); Fri, 4 Jan 2019 09:01:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=e0fBSdAO5PjtDC0wVBHORxbqwBWBFdz5+Jgee6FFlAc=; b=jAC0nW3qmKwo /y+6GTXsu2HW7lARoEw/dqOzStWKw/6fDg1oUF+YFTJ7Lt/G9BoGK6FqosnEa74Hp9PN5eHJeQxTw 5h06xiA+O1KfDrvSRWlsQg+2g0q8aRH7mkVWAJNHvta6VXuQIMU7EZpIHp6gFC0aV/3TeIoUr0UbB vc224=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1gfQ26-0001P7-GJ; Fri, 04 Jan 2019 14:01:06 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 0C1F611270A3; Fri, 4 Jan 2019 14:01:06 +0000 (GMT) From: Mark Brown To: Katsuhiro Suzuki Cc: Mark Brown , Mark Brown , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org Subject: Applied "ASoC: rockchip: add workaround for silence of rk3288 ACODEC" to the asoc tree In-Reply-To: <20181220153636.5213-2-katsuhiro@katsuster.net> X-Patchwork-Hint: ignore Message-Id: <20190104140106.0C1F611270A3@debutante.sirena.org.uk> Date: Fri, 4 Jan 2019 14:01:06 +0000 (GMT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch ASoC: rockchip: add workaround for silence of rk3288 ACODEC has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From f5758544d98c8bec7793aeea28928f5e8bd45d47 Mon Sep 17 00:00:00 2001 From: Katsuhiro Suzuki Date: Fri, 21 Dec 2018 00:36:36 +0900 Subject: [PATCH] ASoC: rockchip: add workaround for silence of rk3288 ACODEC This patch adds reset and precharge in shutdown of PCM device. ACODEC goes to silence if we change Fs to 44.1kHz from 48kHz. This workaround seems to work but I don't know this workaround is correct sequence or not for ACODEC. Signed-off-by: Katsuhiro Suzuki Signed-off-by: Mark Brown --- sound/soc/codecs/rk3328_codec.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/rk3328_codec.c b/sound/soc/codecs/rk3328_codec.c index 71f3fc2d970c..f3442a2283ea 100644 --- a/sound/soc/codecs/rk3328_codec.c +++ b/sound/soc/codecs/rk3328_codec.c @@ -261,9 +261,12 @@ static int rk3328_codec_close_playback(struct rk3328_codec_priv *rk3328) mdelay(1); } + /* Workaround for silence when changed Fs 48 -> 44.1kHz */ + rk3328_codec_reset(rk3328); + regmap_update_bits(rk3328->regmap, DAC_PRECHARGE_CTRL, DAC_CHARGE_CURRENT_ALL_MASK, - DAC_CHARGE_CURRENT_I); + DAC_CHARGE_CURRENT_ALL_ON); return 0; } -- 2.20.1