Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp971534imu; Fri, 4 Jan 2019 10:27:45 -0800 (PST) X-Google-Smtp-Source: ALg8bN7c5KUlYRCHh2hNUphqWcRoaq9k0Uux/y4IKBZlNWQXS4EinfDIalpPLPn77zpcNTlS/Jwp X-Received: by 2002:a63:3507:: with SMTP id c7mr2544596pga.315.1546626465565; Fri, 04 Jan 2019 10:27:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546626465; cv=none; d=google.com; s=arc-20160816; b=jmOdRnddppxg0kb4MPW02a4manMQxmUExPStBthdo7kVuqQE35DlHZ9yRwZwp+ybgG lQrrL/4o05/t9EpmJgRDY9HQpFfwp7B57FXGz9rIdZ7hQP4a96mT3MBmvZjsV5FaUUDz qzFkeD1cQXeiLTLoseOHCO9mUMhjAYoo/iMnk8vWovFVypLkWvP+bE/6Ugj5938Huccv R2q6LHIBQ1nSEK+R3WYVLDhj+styK4C7jMrF1wNL9+Up5Jl7uuyT+BVVJkFsh6zB3JtV YtpOQCEQ+r0pdhPWgX0MaOUdua5dkjukWuQ9L2x2mEd0wZws3lubGxXqtJ7IIBLlZiup +2rQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature; bh=e0fBSdAO5PjtDC0wVBHORxbqwBWBFdz5+Jgee6FFlAc=; b=en2Gyv+dcnPXidBx4xBmo+MfbM4beZjg1WmlCke7hBmyTW3hdE0Q3oKPlmmHBGlkKc Zey3V76T0jwZ6xYbncUt6s6xQdWcutOcFx/pHa9213XSL4CdcJQ/URvzmY+1DVvJfeKx oimnZ1MSPVSVmJbbFYJTHV6jwue0MQWTeA3xVQ2OCF4JPWmbB5J6msMWXkI1QU8ksoWb IFS8S6OkKxPOoQIcHEyS5CVCCOpUl9ixgdmmZM7y4+M3RfDEbwRk+6BbwZWJBel60RBi nwb+LnmjekKDoCICHbqwRgcRHBN+P2g6Zsy07FSMVCmd9TOCT4YJe1iEId0vL1D99RC8 1e1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=o+9M8zE+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id be11si52909127plb.134.2019.01.04.10.27.30; Fri, 04 Jan 2019 10:27:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=o+9M8zE+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728593AbfADRJO (ORCPT + 99 others); Fri, 4 Jan 2019 12:09:14 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:58956 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727790AbfADRJO (ORCPT ); Fri, 4 Jan 2019 12:09:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=e0fBSdAO5PjtDC0wVBHORxbqwBWBFdz5+Jgee6FFlAc=; b=o+9M8zE+cDGl p30WLc0yGdUOAw+oZUYUpecTzjVHTQRpoIOBV0ofXK3Ao4hFuqeJU0uTDoLNREDYW7yk7pP3EOY1S kXMF01ynX0J1XKhxGpnUWoa9uhAsaXfuSeGShk8uBSjKUb89ow0ARsB2MO2p244aCYH6+BNf5+Rl2 ZudqI=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1gfSy5-0001pQ-3L; Fri, 04 Jan 2019 17:09:09 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 7DD6F11270A3; Fri, 4 Jan 2019 17:09:08 +0000 (GMT) From: Mark Brown To: Katsuhiro Suzuki Cc: Mark Brown , Mark Brown , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org Subject: Applied "ASoC: rockchip: add workaround for silence of rk3288 ACODEC" to the asoc tree In-Reply-To: <20181220153636.5213-2-katsuhiro@katsuster.net> X-Patchwork-Hint: ignore Message-Id: <20190104170908.7DD6F11270A3@debutante.sirena.org.uk> Date: Fri, 4 Jan 2019 17:09:08 +0000 (GMT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch ASoC: rockchip: add workaround for silence of rk3288 ACODEC has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From f5758544d98c8bec7793aeea28928f5e8bd45d47 Mon Sep 17 00:00:00 2001 From: Katsuhiro Suzuki Date: Fri, 21 Dec 2018 00:36:36 +0900 Subject: [PATCH] ASoC: rockchip: add workaround for silence of rk3288 ACODEC This patch adds reset and precharge in shutdown of PCM device. ACODEC goes to silence if we change Fs to 44.1kHz from 48kHz. This workaround seems to work but I don't know this workaround is correct sequence or not for ACODEC. Signed-off-by: Katsuhiro Suzuki Signed-off-by: Mark Brown --- sound/soc/codecs/rk3328_codec.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/rk3328_codec.c b/sound/soc/codecs/rk3328_codec.c index 71f3fc2d970c..f3442a2283ea 100644 --- a/sound/soc/codecs/rk3328_codec.c +++ b/sound/soc/codecs/rk3328_codec.c @@ -261,9 +261,12 @@ static int rk3328_codec_close_playback(struct rk3328_codec_priv *rk3328) mdelay(1); } + /* Workaround for silence when changed Fs 48 -> 44.1kHz */ + rk3328_codec_reset(rk3328); + regmap_update_bits(rk3328->regmap, DAC_PRECHARGE_CTRL, DAC_CHARGE_CURRENT_ALL_MASK, - DAC_CHARGE_CURRENT_I); + DAC_CHARGE_CURRENT_ALL_ON); return 0; } -- 2.20.1