Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v14 3/3] pps: pps-gpio pps-echo implementation
To:     Tom Burkart <tom@aussec.com>,
        Linux kernel mailing list <linux-kernel@vger.kernel.org>
Cc:     Ricardo Martins <rasm@fe.up.pt>,
        James Nuss <jamesnuss@nanometrics.ca>,
        Lukas Senger <lukas@fridolin.com>
References: <20181230083333.27210-1-tom@aussec.com>
 <20181230083333.27210-2-tom@aussec.com>
 <20181230083333.27210-3-tom@aussec.com>
 <20181230083333.27210-4-tom@aussec.com>
From:   Rodolfo Giometti <giometti@enneenne.com>
Message-ID: <5eba2cc4-75fa-e1dc-8a86-68f1221d5e78@enneenne.com>
Date:   Fri, 4 Jan 2019 18:16:17 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <20181230083333.27210-4-tom@aussec.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 30/12/2018 09:33, Tom Burkart wrote:
> This patch implements the pps echo functionality for pps-gpio, that
> sysfs claims is available already.
> 
> Configuration is done via device tree bindings.
> 
> This patch was originally written by Lukas Senger as part of a masters
> thesis project and modified for inclusion into the linux kernel by Tom
> Burkart.

[snip]

> +static void pps_gpio_echo(struct pps_device *pps, int event, void *data)
> +{
> +	/* add_timer() needs to write into info->echo_timer */
> +	struct pps_gpio_device_data *info;
> +
> +	info = data;

Maybe you can write as below and saving two lines and having better readability:

struct pps_gpio_device_data *info = data;

> +	switch (event) {
> +	case PPS_CAPTUREASSERT:
> +		if (pps->params.mode & PPS_ECHOASSERT)
> +			gpiod_set_value(info->echo_pin, 1);
> +		break;
> +
> +	case PPS_CAPTURECLEAR:
> +		if (pps->params.mode & PPS_ECHOCLEAR)
> +			gpiod_set_value(info->echo_pin, 1);
> +		break;
> +	}
> +
> +	/* fire the timer */
> +	if (info->pps->params.mode & (PPS_ECHOASSERT | PPS_ECHOCLEAR)) {
> +		info->echo_timer.expires = jiffies + info->echo_timeout;
> +		add_timer(&info->echo_timer);
> +	}
> +}

I think is better firing the timer if and only if we set the echo GPIO otherwise 
it's useless...

Ciao,

Rodolfo

-- 
GNU/Linux Solutions                  e-mail: giometti@enneenne.com
Linux Device Driver                          giometti@linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti