Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-PHdr: =?us-ascii?q?9a23=3Aw7izihIN8uc4j6eNYdmcpTZWNBhigK39O0sv0rFi?=
 =?us-ascii?q?tYgRIv7xwZ3uMQTl6Ol3ixeRBMOHs6IC07KempujcFRI2YyGvnEGfc4EfD4+ou?=
 =?us-ascii?q?JSoTYdBtWYA1bwNv/gYn9yNs1DUFh44yPzahANS47xaFLIv3K98yMZFAnhOgpp?=
 =?us-ascii?q?POT1HZPZg9iq2+yo9JDffwZFiCChbb9uMR67sRjfus4KjIV4N60/0AHJonxGe+?=
 =?us-ascii?q?RXwWNnO1eelAvi68mz4ZBu7T1et+ou+MBcX6r6eb84TaFDAzQ9L281/szrugLd?=
 =?us-ascii?q?QgaJ+3ART38ZkhtMAwjC8RH6QpL8uTb0u+ZhxCWXO9D9QKsqUjq+8ahkVB7oiD?=
 =?us-ascii?q?8GNzEn9mHXltdwh79frB64uhBz35LYbISTOfp7f6PdZsgaRWtHXsZeSidPHJqy?=
 =?us-ascii?q?ZJYBD+oAI+lYq5TyrEYKoRawGQWgAeXiwSJKiHDrx603y+QvHx/b0gIuHNwAt2?=
 =?us-ascii?q?/ZoMnpOKoITey41rXEwSnFYvhL2Tn98o/IchU5rP6OXLJxcMrRyVQoFwjYiViR?=
 =?us-ascii?q?qY3kPzOP2eQMr2SX8+RtWPmyi2E7sQF9uCagydoxioTQgI8e11PK9T1hzYorOd?=
 =?us-ascii?q?G1TFR3bN2kHZdKqS2WKoR7Ttk/T2xsuis20qAKtJ+/cSQQ1pgqyR7SZ+aZf4WJ?=
 =?us-ascii?q?+B7uVumcLDFlj3x/Yr2/nQy98U24x+35Ucm7zUhFozJektnJqnANzxvT6tWbSv?=
 =?us-ascii?q?dl/keuxzKP1wfL5+FBO080lK7bJ4c5wr40i5YfqErDEjLylUj0lqOWeUIk+u+n?=
 =?us-ascii?q?6+TjfLrqvIOTN4hxig3mM6QunNKwAfggPwQQQ2SW/f6w2b7j8EHjXrlGk/I7nr?=
 =?us-ascii?q?PEvJ3eJ8kXvqu5DBVU0oYn5Ra/FTCm0NEAkHgHLVNFeAiIj4n1N13SLv31Fuq/?=
 =?us-ascii?q?jEi2kDtx2f/JI6DhDo3XLnffiLfhYap960lExQo3zNBf4Y9UC74YLPLwREDxrt?=
 =?us-ascii?q?rYAQE9MwGv3ebnB8ty1pkEVWKMHKCZKqXSvkGM5u41JOmMfoAV637TMf8gss/v?=
 =?us-ascii?q?n38knhdJbLup1JpPMCuQA/98ZUiVfCy/0Z86DW4Ws19mH6TRg1qYXGsWOC6/?=
From:   Yizhuo <yzhai003@ucr.edu>
Cc:     csong@cs.ucr.edu, zhiyunq@cs.ucr.edu, Yizhuo <yzhai003@ucr.edu>,
        Bard Liao <bardliao@realtek.com>,
        Oder Chiou <oder_chiou@realtek.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH] ASoC: rt274: Variable "buf" in function rt274_jack_detect() could be uninitialized
Date:   Fri,  4 Jan 2019 12:27:08 -0800
Message-Id: <20190104202708.14759-1-yzhai003@ucr.edu>
To:     unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

In function rt274_jack_detect(), local variable "buf" could
be uninitialized if function regmap_read() returns -EINVAL.
However, it will be used to calculate "hp" and "mic" and
make their value unpredictable while those value are used
in the caller. This is potentially unsafe.

Signed-off-by: Yizhuo <yzhai003@ucr.edu>
---
 sound/soc/codecs/rt274.c | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/rt274.c b/sound/soc/codecs/rt274.c
index cd048df76232..a2c1a6df8df6 100644
--- a/sound/soc/codecs/rt274.c
+++ b/sound/soc/codecs/rt274.c
@@ -353,6 +353,7 @@ static void rt274_index_sync(struct snd_soc_codec *codec)
 static int rt274_jack_detect(struct rt274_priv *rt274, bool *hp, bool *mic)
 {
 	unsigned int buf;
+	int ret = 0;
 
 	*hp = false;
 	*mic = false;
@@ -360,9 +361,15 @@ static int rt274_jack_detect(struct rt274_priv *rt274, bool *hp, bool *mic)
 	if (!rt274->codec)
 		return -EINVAL;
 
-	regmap_read(rt274->regmap, RT274_GET_HP_SENSE, &buf);
+	ret = regmap_read(rt274->regmap, RT274_GET_HP_SENSE, &buf);
+	if (ret)
+		return ret;
+
 	*hp = buf & 0x80000000;
-	regmap_read(rt274->regmap, RT274_GET_MIC_SENSE, &buf);
+	ret = regmap_read(rt274->regmap, RT274_GET_MIC_SENSE, &buf);
+	if (ret)
+		return ret;
+
 	*mic = buf & 0x80000000;
 
 	pr_debug("*hp = %d *mic = %d\n", *hp, *mic);
-- 
2.17.1