Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-PHdr: =?us-ascii?q?9a23=3AsDl4/RwCy+W1MrzXCy+O+j09IxM/srCxBDY+r6Qd?=
 =?us-ascii?q?1OIUIJqq85mqBkHD//Il1AaPAd2Lraocw8Pt8InYEVQa5piAtH1QOLdtbDQizf?=
 =?us-ascii?q?ssogo7HcSeAlf6JvO5JwYzHcBFSUM3tyrjaRsdF8nxfUDdrWOv5jAOBBr/KRB1?=
 =?us-ascii?q?JuPoEYLOksi7ze+/94HQbglSmDaxfa55IQmrownWqsQYm5ZpJLwryhvOrHtIeu?=
 =?us-ascii?q?BWyn1tKFmOgRvy5dq+8YB6/ShItP0v68BPUaPhf6QlVrNYFygpM3o05MLwqxbO?=
 =?us-ascii?q?SxaE62YGXWUXlhpIBBXF7A3/U5zsvCb2qvZx1S+HNsDtU7s6RSqt4LtqSB/wiS?=
 =?us-ascii?q?cIKTg58H3MisdtiK5XuQ+tqwBjz4LRZoyVMft+frjGfdMbQ2pBUdtaWTJYDIih?=
 =?us-ascii?q?YYsPDvQOPeJFoILgo1cDoweyCQyqCejyyDFHm2X20LU63eo/DA/I0g8uEdUVvX?=
 =?us-ascii?q?jIsNn4LrseXPqpwKXUyzjIcvNY2S366IjNah0uo/CMXLNwccrMzkkkCgTIj1WR?=
 =?us-ascii?q?qIzlJTyV1/gBv3SV4ud7SOKgl3QnpxtvrTey28chk4/EjZ8WxFDc7Sh13po5KN?=
 =?us-ascii?q?miREN4YdOoCoVcuzyaOodsX88vR2NltD4nxrAHvZO3ZjYGxZonyhLFdfCKcpKE?=
 =?us-ascii?q?7xDsWeuXPDx2nmhqeKiliBa36UWgz+r8WdSq31tStSpFl8XMtmgK1xzO9siLUv?=
 =?us-ascii?q?t98Vml2TaIzw3T7/tLIUEwlabCM54hzaM8moMdsUjeGiL7ml/6jKCRdkUj9eio?=
 =?us-ascii?q?7/robq/6qZ+bMo94kgD+MqIwlcyjGek0LBQCUmyB9em/1LDv51P1TKhKg/Esj6?=
 =?us-ascii?q?XUtJLXKdwepqGjAg9V1ogj6wy4DzejyNkZnXgGLFJfdxKGk4TlJ1/DLevlDfij?=
 =?us-ascii?q?mVSgiilkyO3bPrH5GJXCMmDDkKv9fbZ680NczAszzdZC55NbE70BI+z8WlX3tN?=
 =?us-ascii?q?PGCh80KBK0w+n5B9VnzI8eWnyAArWfMKzMtV+E/OUvI/ODZNxdliz6Lq0U5uzu?=
 =?us-ascii?q?kHhxzU4PfaCohcNMQG2zBLJrL1jPMimkucsIDWpf5ll2d+ftklDXFGELag=3D?=
 =?us-ascii?q?=3D?=
From:   Yizhuo <yzhai003@ucr.edu>
Cc:     csong@cs.ucr.edu, zhiyunq@cs.ucr.edu, Yizhuo <yzhai003@ucr.edu>,
        Bard Liao <bardliao@realtek.com>,
        Oder Chiou <oder_chiou@realtek.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH] ASoC: rt298: Variable "val" and "buf" in rt298_jack_detect() could be uninitialized
Date:   Fri,  4 Jan 2019 13:52:53 -0800
Message-Id: <20190104215253.16278-1-yzhai003@ucr.edu>
To:     unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

In function rt298_jack_detect(), local variable "val" and "buf"
are supposed to get initialized by regmap_read(). However, they
 could be leave uninitialized if regmap_read() returns -EINVAL.
Those two variables are used in control flow or update the argument,
which could lead to undefined behavior and thus unsafe.

Signed-off-by: Yizhuo <yzhai003@ucr.edu>
---
 sound/soc/codecs/rt298.c | 24 ++++++++++++++++++------
 1 file changed, 18 insertions(+), 6 deletions(-)

diff --git a/sound/soc/codecs/rt298.c b/sound/soc/codecs/rt298.c
index ce963768449f..7f74349c17f3 100644
--- a/sound/soc/codecs/rt298.c
+++ b/sound/soc/codecs/rt298.c
@@ -223,6 +223,7 @@ static int rt298_jack_detect(struct rt298_priv *rt298, bool *hp, bool *mic)
 {
 	struct snd_soc_dapm_context *dapm;
 	unsigned int val, buf;
+	int ret = 0;
 
 	*hp = false;
 	*mic = false;
@@ -233,7 +234,10 @@ static int rt298_jack_detect(struct rt298_priv *rt298, bool *hp, bool *mic)
 	dapm = snd_soc_codec_get_dapm(rt298->codec);
 
 	if (rt298->pdata.cbj_en) {
-		regmap_read(rt298->regmap, RT298_GET_HP_SENSE, &buf);
+		ret = regmap_read(rt298->regmap, RT298_GET_HP_SENSE, &buf);
+		if (ret)
+			return ret;
+
 		*hp = buf & 0x80000000;
 		if (*hp == rt298->is_hp_in)
 			return -1;
@@ -260,16 +264,19 @@ static int rt298_jack_detect(struct rt298_priv *rt298, bool *hp, bool *mic)
 			regmap_update_bits(rt298->regmap,
 				RT298_CBJ_CTRL1, 0xfcc0, 0xd400);
 			msleep(300);
-			regmap_read(rt298->regmap, RT298_CBJ_CTRL2, &val);
-
+			ret = regmap_read(rt298->regmap, RT298_CBJ_CTRL2, &val);
+			if (ret)
+				return ret;
 			if (0x0070 == (val & 0x0070)) {
 				*mic = true;
 			} else {
 				regmap_update_bits(rt298->regmap,
 					RT298_CBJ_CTRL1, 0xfcc0, 0xe400);
 				msleep(300);
-				regmap_read(rt298->regmap,
+				ret = regmap_read(rt298->regmap,
 					RT298_CBJ_CTRL2, &val);
+				if (ret)
+					return ret;
 				if (0x0070 == (val & 0x0070))
 					*mic = true;
 				else
@@ -285,9 +292,14 @@ static int rt298_jack_detect(struct rt298_priv *rt298, bool *hp, bool *mic)
 				RT298_CBJ_CTRL1, 0x0400, 0x0000);
 		}
 	} else {
-		regmap_read(rt298->regmap, RT298_GET_HP_SENSE, &buf);
+		ret = regmap_read(rt298->regmap, RT298_GET_HP_SENSE, &buf);
+		if (ret)
+			return ret;
+
 		*hp = buf & 0x80000000;
-		regmap_read(rt298->regmap, RT298_GET_MIC1_SENSE, &buf);
+		ret = regmap_read(rt298->regmap, RT298_GET_MIC1_SENSE, &buf);
+		if (ret)
+			return ret;
 		*mic = buf & 0x80000000;
 	}
 
-- 
2.17.1