Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1497035imu; Sat, 5 Jan 2019 00:05:10 -0800 (PST) X-Google-Smtp-Source: AFSGD/UYZyc6pXiOsOoOodUGM90TpAaYqsO86sIv5vyrDqLEKuMfEy9Ct0V1RM/Cnhq+OVbZOPD0 X-Received: by 2002:a62:6303:: with SMTP id x3mr56973356pfb.110.1546675510379; Sat, 05 Jan 2019 00:05:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546675510; cv=none; d=google.com; s=arc-20160816; b=IrYgtvRANliLhSsRHaqF1BFKMTIT7ESw+t2S2RD/6epXx/WtGUTe4MvTS/Zn8juvz8 DLREpmIoa+bdkcDXjV3v50Y1ctLa5AzWbJVZJh2cPE05sxJwZWArikIofNjLAmVHWBhJ 65HIZv6UT9g9p20ZrcUbRlKqaGHMkwiWQzFZBx2e82QrTuQmqSfJ9YSSiXEwT72Zs+TB 4CXXOcJrIrYdhziiw5p5BoRytteJ8B70nn4Q/ngRdNN6v85lEJRKzqwNfSBNf4lA6cj4 NqONMVqZQX+Esj3LO/7bkuaPeljd5zaCq9LYyKWDAUd7eHVTVPwKGZrbzxgJq56u2Kvn Ss3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=pdY7+J1zFjVI4F5NLSq2Xse777ie57ZXMaqkc6dWXhY=; b=BTK53fBVJeJ6Bf126jd0Ry4K3NZrODqf1QBoi3tFisoeBMS/dIseqg8XkU4ub+QrXr HUc4ZWhvPrPYyQ9naOwWUdxVK0WtgqAAaBuu7HL0UJrGS4t8P6JkH4x4ywzRT9Pm+2W9 3VzjAHluOIGRErF++urvdbOxlommYLIvHgfuKkzz4RehzOiaUCzXkIuhPK3iklwsbBhX KwVRYKWYktctjqObP3orOrEzD8josyAE5mN4sv8ZsvBg0oG1RvMBcO/nAzJGZO/4B1iM /SzmZoA3vw2HAZbwKwaL/xacEZwmu47smSaqCejEubPDadyS06P1GmOzdlOlrugAp4ks zqLA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=CSq9IoeT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a11si4417987pln.78.2019.01.05.00.04.55; Sat, 05 Jan 2019 00:05:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=CSq9IoeT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726273AbfAEIBU (ORCPT + 99 others); Sat, 5 Jan 2019 03:01:20 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:48834 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726102AbfAEIBT (ORCPT ); Sat, 5 Jan 2019 03:01:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=pdY7+J1zFjVI4F5NLSq2Xse777ie57ZXMaqkc6dWXhY=; b=CSq9IoeTI/9V3DjENlmz/TXZri GV0BSCbACPV2zuwuHTmvCvR9u2XOw+mOL9UpksvbjpSbxllj/WNa9pFWZrshmi3twf73jDSrDKSkr R6X4emLmuDnqQLlIq6Wz94jhVJC76t+kqWXfBPlAHvkNLHTKv/QaHB8QsovBAMwT1Qp+qPM5YEyCq 2SGmCmNs9nAcf8fQ8et6OB1+RNTKbdatMG5toa1Suxro1yVCLW/A+kN4j0pXvBF9mxOX4YVHXVX1e REkPxCbjpu111cjIH7UOqKF/uj6yh3LWcGr7DyoWQuoxxltoEEMi3mLdx4tqYzol84GoiqAyHTsQe tRs/KvXQ==; Received: from 089144213048.atnat0022.highway.a1.net ([89.144.213.48] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1gfgtS-0000JI-2t; Sat, 05 Jan 2019 08:01:18 +0000 From: Christoph Hellwig To: thellstrom@vmware.com Cc: linux-graphics-maintainer@vmware.com, dri-devel@lists.freedesktop.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] drm/vmwgfx: remove CONFIG_INTEL_IOMMU ifdefs Date: Sat, 5 Jan 2019 09:01:06 +0100 Message-Id: <20190105080108.14837-3-hch@lst.de> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190105080108.14837-1-hch@lst.de> References: <20190105080108.14837-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org intel_iommu_enabled is defined as always false for !CONFIG_INTEL_IOMMU, so remove the ifdefs around it. Signed-off-by: Christoph Hellwig --- drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c index 69e325b2d954..236052ad233c 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c @@ -567,12 +567,10 @@ static int vmw_dma_select_mode(struct vmw_private *dev_priv) [vmw_dma_map_bind] = "Giving up DMA mappings early."}; const struct dma_map_ops *dma_ops = get_dma_ops(dev_priv->dev->dev); -#ifdef CONFIG_INTEL_IOMMU if (intel_iommu_enabled) { dev_priv->map_mode = vmw_dma_map_populate; goto out_fixup; } -#endif if (!(vmw_force_iommu || vmw_force_coherent)) { dev_priv->map_mode = vmw_dma_phys; @@ -589,9 +587,7 @@ static int vmw_dma_select_mode(struct vmw_private *dev_priv) dev_priv->map_mode = vmw_dma_map_populate; #endif -#ifdef CONFIG_INTEL_IOMMU out_fixup: -#endif if (dev_priv->map_mode == vmw_dma_map_populate && vmw_restrict_iommu) dev_priv->map_mode = vmw_dma_map_bind; @@ -599,13 +595,6 @@ static int vmw_dma_select_mode(struct vmw_private *dev_priv) if (vmw_force_coherent) dev_priv->map_mode = vmw_dma_alloc_coherent; -#if !defined(CONFIG_SWIOTLB) && !defined(CONFIG_INTEL_IOMMU) - /* - * No coherent page pool - */ - if (dev_priv->map_mode == vmw_dma_alloc_coherent) - return -EINVAL; -#endif DRM_INFO("DMA map mode: %s\n", names[dev_priv->map_mode]); return 0; @@ -619,7 +608,6 @@ static int vmw_dma_select_mode(struct vmw_private *dev_priv) * With 32-bit we can only handle 32 bit PFNs. Optionally set that * restriction also for 64-bit systems. */ -#ifdef CONFIG_INTEL_IOMMU static int vmw_dma_masks(struct vmw_private *dev_priv) { struct drm_device *dev = dev_priv->dev; @@ -631,12 +619,6 @@ static int vmw_dma_masks(struct vmw_private *dev_priv) } return 0; } -#else -static int vmw_dma_masks(struct vmw_private *dev_priv) -{ - return 0; -} -#endif static int vmw_driver_load(struct drm_device *dev, unsigned long chipset) { -- 2.20.1