Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190104193029.GA15903@jordon-HP-15-Notebook-PC>
In-Reply-To: <20190104193029.GA15903@jordon-HP-15-Notebook-PC>
From:   Ilya Dryomov <idryomov@gmail.com>
Date:   Sat, 5 Jan 2019 11:58:19 +0100
Message-ID: <CAOi1vP_bgMmQyvm2Gd-oBY5kTZuQBMvj0xKyyzDecvhUfypXDw@mail.gmail.com>
Subject: Re: [PATCH] fs/ceph/addr.c: Convert to use vmf_error()
To:     Souptick Joarder <jrdr.linux@gmail.com>
Cc:     "Yan, Zheng" <zyan@redhat.com>, Sage Weil <sage@redhat.com>,
        Ceph Development <ceph-devel@vger.kernel.org>,
        linux-kernel@vger.kernel.org, willy@infradead.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jan 4, 2019 at 8:26 PM Souptick Joarder <jrdr.linux@gmail.com> wrote:
>
> This code is converted to use vmf_error().
>
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
>  fs/ceph/addr.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> index 8eade7a..fa2a85d 100644
> --- a/fs/ceph/addr.c
> +++ b/fs/ceph/addr.c
> @@ -1495,10 +1495,7 @@ static vm_fault_t ceph_filemap_fault(struct vm_fault *vmf)
>                 if (err < 0 || off >= i_size_read(inode)) {
>                         unlock_page(page);
>                         put_page(page);
> -                       if (err == -ENOMEM)
> -                               ret = VM_FAULT_OOM;
> -                       else
> -                               ret = VM_FAULT_SIGBUS;
> +                       ret = vmf_error(err);
>                         goto out_inline;
>                 }
>                 if (err < PAGE_SIZE)

Applied.

Thanks,

                Ilya