Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1766281imu; Sat, 5 Jan 2019 06:36:33 -0800 (PST) X-Google-Smtp-Source: ALg8bN5COVOUeXBGFIISlYgfc7Dovahg6VAm+6kuF+TBlOtjRfemnkUFYbQUEykIMq9yRnbyK+4b X-Received: by 2002:a17:902:48:: with SMTP id 66mr53208088pla.68.1546698993505; Sat, 05 Jan 2019 06:36:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546698993; cv=none; d=google.com; s=arc-20160816; b=LHkO8EDKDI+ARkr1hmDsgZpZKSzO3EN8VM5EQIEQn5qZNnevdsMv/fvVZ8Yfd+TERq pvjlzG0lC0A8Jk2zDFebPhNUrdjStkGXXXGJwocHTd5e5QIvtVzs9mqTBoX8gbfNSQh2 sBrMGZDkM8Bnu/uuiw8EDQHZzMxAI8+CFMwb4TS62dqxhswfjJDj+VVVX5sUz3LeFfq+ d2pjsH2arQCBIYSDjVMW3Y7e4rmb26JDVCoh5PsvANizxMcdYZI5chPcRZWol5nSn7kb dltwyjNCcAq2CNOto+fy8tJRcwehLtU3sxkivHtNF3qCW783r9G/FWWtvuWHEqT0tIbQ u83Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=EIGukw7/b+bliOANdXjKLxPJTcNUBwpQB6vhJjCE1pA=; b=aWTL9wLW3ege/Xpk+leqw58cy5v0u8kSLmqrAtu+/Hwx3iZ5mcsEWGkZUAXcs9OmtR 6KyBxbCtM6lY1Lx9WAjeip/rq2B2IO8aaLz228aQ3dIBzkiu6ShN5whHlUgxOiEGWDnX udXjLh0OKCDf1EGmt+U1yGRZK8oY8O6Xl/3lyKX1GLtlw+9qcurSBqNcqbxwcDHBMPQU I/TXZ7/kR5KLryMoZkhIZReU4NhYnrKilOGN72EBWsdBHpzgKvAuxNru8/tmH1YbaFjm n4mk0zxzAMeHBCaySAxX0pF9RKvkk3zG+Yq0YjH4lfE2XsiFQHemaTN0MR6IA50zNF3y MqkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vpo4GHdy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a12si1708085pgk.291.2019.01.05.06.36.05; Sat, 05 Jan 2019 06:36:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vpo4GHdy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726252AbfAEOeJ (ORCPT + 99 others); Sat, 5 Jan 2019 09:34:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:51364 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726200AbfAEOeI (ORCPT ); Sat, 5 Jan 2019 09:34:08 -0500 Received: from localhost (unknown [188.89.135.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 81C4C2070C; Sat, 5 Jan 2019 14:34:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546698848; bh=2Yt3aLQvhCwyZRK7UGozQ6BWvDaMWB8O3gC0gVbqeCE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=vpo4GHdyljJFUZACWWb4YfVT7EBPWGTlPOnwW5cmlWcJoj23msWl4rqNaCnh9DGwZ TNwssq5yT9xCpsgYTUzjPwY+Wh2yISK2j0fmfJF00Ta8JQQJfa2zjIzWHBsGtnACQA IPwPxwqFDvTorUiIRPoVf+8wskWKHPfm6dyaa7us= Date: Sat, 5 Jan 2019 15:34:04 +0100 From: Greg KH To: Roman Kiryanov Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: misc: goldfish_address_space: add a driver Message-ID: <20190105143404.GB22044@kroah.com> References: <20190104021311.38194-1-rkir@google.com> <20190105085429.GB13941@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 05, 2019 at 01:43:55AM -0800, Roman Kiryanov wrote: > > Why isn't this in drivers/platform/goldfish/ ? > > I was not sure where to put, but this driver is not a platform one, it > is a pci one. You are controlling a "platform" device, the goldfish platform. What makes this different from any of the other goldfish platform drivers in that directory other than you are triggering off of a virtual pci device? thanks, greg k-h