Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1768279imu; Sat, 5 Jan 2019 06:39:18 -0800 (PST) X-Google-Smtp-Source: AFSGD/WaHil8gVPyxiloQLuuppceVJ3h57XtDawemgCHBTWIqo9uKiTiPVa2aJ3u9faB7SO0XnDW X-Received: by 2002:a62:5793:: with SMTP id i19mr56750112pfj.49.1546699158078; Sat, 05 Jan 2019 06:39:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546699158; cv=none; d=google.com; s=arc-20160816; b=G1Deo7aNvxaHS+LKW7IrVffp9ePdwCaQmKGmbBDqpOMpdPXYdYCUC1El64TCqW/9rR VuyIqss10jazSe4mQ/CtLz7whiTPt3F2G4Oqp1kINTWe8f/mfrbM/8s62SJkKAqAh0N6 32IQLq0X1r2ftBRRebhMBYKvPmcMBm4E2KGNGw/TDtm5ikLza1JYagRfUU2ER43oHnV1 YoRGLQ6QeKCS37SjrIaWIsbGlicymFTyVpii3skd+3GTpe1we9oo+j1uj/vYHTMVDhJ9 hs2Mr5rGY2XV+Ngiksj5MjG+o747XED6L8KE1JThGjwmAsYZLomEUEjrSq1AE2X8Nwnk QAow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=hs1YbUNfABqtQhjiKfGMBb5kjjXc+s4NV3Ny8D27Cts=; b=qbh3mSBg67XISaI1j67Cho90R8Rx77m18UmrjkBlBqXKN3H+hTXjIysjlIJxQel2kX WHUyHd10b93z8E+iGFzhLwxk9U8VruGuuWtl7aqcTrs9GQOTW023K3805CHvx5/sqSLf 2UOqHtSb3i2DNljRGEwKB6OtGIC9Fjzhhy0RBqMOACsTs77cMiGkpYTiiJX5p2ATeK7e VpturJuYwz/j98crKPHXRF+DVAcCikuIVHOn2KP1iZIydDkvudaHguHGrL5ZWIuumxTE WylXxI6XDJR/xKHrteH3iGjf0jg2RgZ3qvbuVyBJAIW7B4YrZubB1faDzEX96QLmQUnw DU0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uqc+Johz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j22si14084848pfi.252.2019.01.05.06.39.02; Sat, 05 Jan 2019 06:39:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uqc+Johz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726310AbfAEOfn (ORCPT + 99 others); Sat, 5 Jan 2019 09:35:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:51856 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726200AbfAEOfn (ORCPT ); Sat, 5 Jan 2019 09:35:43 -0500 Received: from localhost (unknown [188.89.135.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2D7042070C; Sat, 5 Jan 2019 14:35:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546698942; bh=uoBB13R0SCbsoP4GZH+Zbs4CuqBNVabu3jUdeKyEBV0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uqc+Johznnr9QjQYJZDy7QwM3Fh03CDzixgBnm7T4AT7ofJ6fV6nFAOiSFKTbAtSz ubmBAA6yBfO6s2UCKu2gHxQUTgqNM8gK4fuxFLoQYwtxJomZe7ieKg+0izi1NncCAb qy4ejvP8Eucyq+8iJzTm1Mv7uwrjAXXU024DY7Mg= Date: Sat, 5 Jan 2019 15:35:39 +0100 From: Greg KH To: saranya.gopal@intel.com Cc: kernel@kolivas.org, pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, tiwai@suse.de, felipe.balbi@linux.intel.com Subject: Re: [PATCH] usbcore: Select only first configuration for non-UAC3 compliant devices Message-ID: <20190105143539.GC22044@kroah.com> References: <1546696957-28294-1-git-send-email-saranya.gopal@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1546696957-28294-1-git-send-email-saranya.gopal@intel.com> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 05, 2019 at 07:32:37PM +0530, saranya.gopal@intel.com wrote: > From: Saranya Gopal > > In most of the UAC1 and UAC2 audio devices, the first > configuration is most often the best configuration. > However, with recent patch to support UAC3 configuration, > second configuration was unintentionally chosen for > some of the UAC1/2 devices that had more than one > configuration. This was because of the existing check > after the audio config check which selected any config > which had a non-vendor class. This patch fixes this issue. > > Fixes: f13912d (Select UAC3 configuration for audio if present) That should read: Fixes: f13912d3f014 ("usbcore: Select UAC3 configuration for audio if present") Please use the full commit name and more sha1 numbers :) thanks, greg k-h