Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1948247imu; Sat, 5 Jan 2019 10:34:38 -0800 (PST) X-Google-Smtp-Source: ALg8bN6ORsKYBqJKL+XuDX0Q9d4RmUBVEFiETRO1DhCtS2SPF9Gz24csVXTBhlTc6fMpgbFpQ5ep X-Received: by 2002:a17:902:5a0b:: with SMTP id q11mr13244874pli.186.1546713278748; Sat, 05 Jan 2019 10:34:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546713278; cv=none; d=google.com; s=arc-20160816; b=Rv4YfV1buhAhw0UpJHclaD1EIvvOlhNm8TyU4qZhL3CvQEeP+FxCOTUzooX6o8qNFT kQxoesuXTdLy1+EhWanf14W6Gm2n8xK7eFKXKuXtCk4SZaib/1TN1O42FZ7ESfC/kqQd qo8miSLtDGeFiQIBj1gi5Pry14hFVSC1hSRg8wEN5hZlst12tDQ67eJAW+RDh2H/JtYW k/smvvtH0x0AZ624nudE6M8W45BB5cFiQpKuLa6ox3F5OFumWAG08Mj5Nd0YTDy2IN68 imr6Jac4nxl5POHUsnq0JqfYMosVjgvpAGccWswiiaUg5y3caCL/T2+njcrftBs9CD7A qxbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=yoeqyHwLRyj0XxRP2JozaVZZKFEFmQHRr3xoTdRjREQ=; b=Ym+R23IwKLI+xs0si1Qh/Molv5ANVKRkceGRzXj2CK6gTXr00MYxCepL19w0z4aBDQ 9HtPNYBzrqD1S1aXrtdWm25Foq2HRwLtu8/7Jcec8DjrDTkyC8+zcLagehpRxgWo3y2p FadcdzXugLiKRmSqwesx6uMHb91zqrMXrfME3HullAyYzVQNQkFOTfPwiqLEpfiPZSV8 oaQAT9zOP1EEFFFoUzXhs4JDPWbXccLUnPvPTN+axXaBvc21mCKl8YO8yAhKSiY9g8g8 1qcdn5xNvwQLrzhsmMGyLjyJabH/IpfWQe5Bp0rRbuGRP1Ld6QCHMKnuGZ+UrbBQ+/HQ CleA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b131si44796682pga.394.2019.01.05.10.34.23; Sat, 05 Jan 2019 10:34:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726509AbfAEScF (ORCPT + 99 others); Sat, 5 Jan 2019 13:32:05 -0500 Received: from kozue.soulik.info ([108.61.200.231]:40252 "EHLO kozue.soulik.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726303AbfAEScF (ORCPT ); Sat, 5 Jan 2019 13:32:05 -0500 Received: from misaki.sumomo.pri (unknown [IPv6:2001:470:b30d:2:c604:15ff:0:a00]) by kozue.soulik.info (Postfix) with ESMTPA id 38166101784; Sun, 6 Jan 2019 03:32:42 +0900 (JST) From: Randy Li To: linux-rockchip@lists.infradead.org Cc: Randy Li , nicolas.dufresne@collabora.com, myy@miouyouyou.fr, paul.kocialkowski@bootlin.com, mchehab@kernel.org, linux-media@vger.kernel.org, hverkuil@xs4all.nl, heiko@sntech.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/4] staging: video: rockchip: fixup for upstream Date: Sun, 6 Jan 2019 02:31:48 +0800 Message-Id: <20190105183150.20266-3-ayaka@soulik.info> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190105183150.20266-1-ayaka@soulik.info> References: <20190105183150.20266-1-ayaka@soulik.info> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixing those deprecated function from vendor kernel. Removing those features don't exist in upstream kernel. Signed-off-by: Randy Li --- drivers/staging/rockchip-mpp/mpp_dev_common.c | 12 ++++++------ drivers/staging/rockchip-mpp/mpp_dev_common.h | 2 +- drivers/staging/rockchip-mpp/mpp_dev_rkvdec.c | 7 +++---- drivers/staging/rockchip-mpp/mpp_dev_vdpu1.c | 5 ++--- drivers/staging/rockchip-mpp/mpp_dev_vdpu2.c | 5 ++--- drivers/staging/rockchip-mpp/mpp_dev_vepu1.c | 5 ++--- drivers/staging/rockchip-mpp/mpp_dev_vepu2.c | 5 ++--- 7 files changed, 18 insertions(+), 23 deletions(-) diff --git a/drivers/staging/rockchip-mpp/mpp_dev_common.c b/drivers/staging/rockchip-mpp/mpp_dev_common.c index 159aa5d244ce..9a257c254d4d 100644 --- a/drivers/staging/rockchip-mpp/mpp_dev_common.c +++ b/drivers/staging/rockchip-mpp/mpp_dev_common.c @@ -937,18 +937,18 @@ EXPORT_SYMBOL(mpp_dev_read); void mpp_debug_time_record(struct mpp_task *task) { if (unlikely(debug & DEBUG_TIMING) && task) - do_gettimeofday(&task->start); + getboottime64(&task->start); } EXPORT_SYMBOL(mpp_debug_time_record); void mpp_debug_time_diff(struct mpp_task *task) { - struct timeval end; + struct timespec64 end; - do_gettimeofday(&end); - mpp_debug(DEBUG_TIMING, "time: %ld us\n", - (end.tv_sec - task->start.tv_sec) * 1000000 + - (end.tv_usec - task->start.tv_usec)); + getboottime64(&end); + mpp_debug(DEBUG_TIMING, "time: %lld ms\n", + (end.tv_sec - task->start.tv_sec) * 1000 + + (end.tv_nsec - task->start.tv_nsec) / 1000000); } EXPORT_SYMBOL(mpp_debug_time_diff); diff --git a/drivers/staging/rockchip-mpp/mpp_dev_common.h b/drivers/staging/rockchip-mpp/mpp_dev_common.h index 8a7dc7444dc3..76d53ec2c452 100644 --- a/drivers/staging/rockchip-mpp/mpp_dev_common.h +++ b/drivers/staging/rockchip-mpp/mpp_dev_common.h @@ -124,7 +124,7 @@ struct mpp_task { struct work_struct work; /* record context running start time */ - struct timeval start; + struct timespec64 start; }; /* diff --git a/drivers/staging/rockchip-mpp/mpp_dev_rkvdec.c b/drivers/staging/rockchip-mpp/mpp_dev_rkvdec.c index a3da27cfc10e..44d76eba901f 100644 --- a/drivers/staging/rockchip-mpp/mpp_dev_rkvdec.c +++ b/drivers/staging/rockchip-mpp/mpp_dev_rkvdec.c @@ -19,10 +19,10 @@ #include #include #include -#include #include #include #include +#include #include "mpp_debug.h" #include "mpp_dev_common.h" @@ -230,8 +230,7 @@ static int fill_scaling_list_pps(struct rkvdec_task *task, int fd, int offset, return -ENOENT; } - ret = dma_buf_begin_cpu_access(dmabuf, 0, dmabuf->size, - DMA_FROM_DEVICE); + ret = dma_buf_begin_cpu_access(dmabuf, DMA_FROM_DEVICE); if (ret) { dev_err(dev, "can't access the pps buffer\n"); goto done; @@ -277,7 +276,7 @@ static int fill_scaling_list_pps(struct rkvdec_task *task, int fd, int offset, done: dma_buf_vunmap(dmabuf, vaddr); - dma_buf_end_cpu_access(dmabuf, 0, dmabuf->size, DMA_FROM_DEVICE); + dma_buf_end_cpu_access(dmabuf, DMA_FROM_DEVICE); dma_buf_put(dmabuf); return ret; diff --git a/drivers/staging/rockchip-mpp/mpp_dev_vdpu1.c b/drivers/staging/rockchip-mpp/mpp_dev_vdpu1.c index 4371a1a6080b..63ffd79bfe83 100644 --- a/drivers/staging/rockchip-mpp/mpp_dev_vdpu1.c +++ b/drivers/staging/rockchip-mpp/mpp_dev_vdpu1.c @@ -460,9 +460,8 @@ static int rockchip_mpp_rkvdpu_assign_reset(struct rockchip_rkvdpu_dev *dec_dev) { struct rockchip_mpp_dev *mpp_dev = &dec_dev->mpp_dev; - /* TODO: use devm_reset_control_get_share() instead */ - dec_dev->rst_a = devm_reset_control_get(mpp_dev->dev, "video_a"); - dec_dev->rst_h = devm_reset_control_get(mpp_dev->dev, "video_h"); + dec_dev->rst_a = devm_reset_control_get_shared(mpp_dev->dev, "video_a"); + dec_dev->rst_h = devm_reset_control_get_shared(mpp_dev->dev, "video_h"); if (IS_ERR_OR_NULL(dec_dev->rst_a)) { mpp_err("No aclk reset resource define\n"); diff --git a/drivers/staging/rockchip-mpp/mpp_dev_vdpu2.c b/drivers/staging/rockchip-mpp/mpp_dev_vdpu2.c index b131790f72a3..5789c8940543 100644 --- a/drivers/staging/rockchip-mpp/mpp_dev_vdpu2.c +++ b/drivers/staging/rockchip-mpp/mpp_dev_vdpu2.c @@ -428,9 +428,8 @@ static int rockchip_mpp_rkvdpu_assign_reset(struct rockchip_rkvdpu_dev *dec_dev) { struct rockchip_mpp_dev *mpp_dev = &dec_dev->mpp_dev; - /* TODO: use devm_reset_control_get_share() instead */ - dec_dev->rst_a = devm_reset_control_get(mpp_dev->dev, "video_a"); - dec_dev->rst_h = devm_reset_control_get(mpp_dev->dev, "video_h"); + dec_dev->rst_a = devm_reset_control_get_shared(mpp_dev->dev, "video_a"); + dec_dev->rst_h = devm_reset_control_get_shared(mpp_dev->dev, "video_h"); if (IS_ERR_OR_NULL(dec_dev->rst_a)) { mpp_err("No aclk reset resource define\n"); diff --git a/drivers/staging/rockchip-mpp/mpp_dev_vepu1.c b/drivers/staging/rockchip-mpp/mpp_dev_vepu1.c index 64619092c792..ebe8174e931e 100644 --- a/drivers/staging/rockchip-mpp/mpp_dev_vepu1.c +++ b/drivers/staging/rockchip-mpp/mpp_dev_vepu1.c @@ -330,9 +330,8 @@ static int rockchip_mpp_rkvepu_assign_reset(struct rockchip_rkvepu_dev *enc_dev) { struct rockchip_mpp_dev *mpp_dev = &enc_dev->mpp_dev; - /* TODO: use devm_reset_control_get_share() instead */ - enc_dev->rst_a = devm_reset_control_get(mpp_dev->dev, "video_a"); - enc_dev->rst_h = devm_reset_control_get(mpp_dev->dev, "video_h"); + enc_dev->rst_a = devm_reset_control_get_shared(mpp_dev->dev, "video_a"); + enc_dev->rst_h = devm_reset_control_get_shared(mpp_dev->dev, "video_h"); if (IS_ERR_OR_NULL(enc_dev->rst_a)) { mpp_err("No aclk reset resource define\n"); diff --git a/drivers/staging/rockchip-mpp/mpp_dev_vepu2.c b/drivers/staging/rockchip-mpp/mpp_dev_vepu2.c index 48ec401145d5..889aaccf25c5 100644 --- a/drivers/staging/rockchip-mpp/mpp_dev_vepu2.c +++ b/drivers/staging/rockchip-mpp/mpp_dev_vepu2.c @@ -327,9 +327,8 @@ static int rockchip_mpp_rkvepu_assign_reset(struct rockchip_rkvepu_dev *enc_dev) { struct rockchip_mpp_dev *mpp_dev = &enc_dev->mpp_dev; - /* TODO: use devm_reset_control_get_share() instead */ - enc_dev->rst_a = devm_reset_control_get(mpp_dev->dev, "video_a"); - enc_dev->rst_h = devm_reset_control_get(mpp_dev->dev, "video_h"); + enc_dev->rst_a = devm_reset_control_get_shared(mpp_dev->dev, "video_a"); + enc_dev->rst_h = devm_reset_control_get_shared(mpp_dev->dev, "video_h"); if (IS_ERR_OR_NULL(enc_dev->rst_a)) { mpp_err("No aclk reset resource define\n"); -- 2.20.1