Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190105091025.GA28917@localhost.localdomain> <61a272a5-3c6f-4e69-2ce9-b7c58b427750@lwfinger.net>
In-Reply-To: <61a272a5-3c6f-4e69-2ce9-b7c58b427750@lwfinger.net>
From:   =?UTF-8?Q?J=C3=BAlius_Milan?= <jmilan.dev@gmail.com>
Date:   Sun, 6 Jan 2019 08:18:53 +0100
Message-ID: <CAP=P++DRiM8Rb8vg9hBJ-N2uhfL0Rrj+njYwgZW80yQZ4jQH4g@mail.gmail.com>
Subject: Re: [PATCH v2] staging: wilc1000: fix cast to restricted __le32
To:     Larry Finger <Larry.Finger@lwfinger.net>
Cc:     linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
        linux-wireless@vger.kernel.org, gregkh@linuxfoundation.org,
        ajay.kathat@microchip.com, adham.abozaeid@microchip.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Thank you for your review Larry

> Before you send V3

Oh, v3 was already sent a few moments before your message.

> Before you send V3, are you sure this is the correct fix? As "frame_type" is
> input as u16, it seems to me that the frame_type member of struct wilc_reg_frame
> should be __le16, not __le32.

Yes, I am confident about it.
The frame_type member of struct wilc_reg_frame contains in some cases
32 bit value
as you can see in function wilc_wlan_cfg_set_wid.
Cast to 32 bits is also safe, due to resultant endianness.

Julius