Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Peter Chen <peter.chen@nxp.com>
To:     Aditya Pakki <pakki001@umn.edu>
CC:     "kjlu@umn.edu" <kjlu@umn.edu>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] [V2] usb: chipidea: add a check for the availability of
 next child
Thread-Topic: [PATCH] [V2] usb: chipidea: add a check for the availability of
 next child
Thread-Index: AQHUpQ+TvMZ2Zb2MoUKiuDq+XSXKFKWjELow
Date:   Mon, 7 Jan 2019 02:06:51 +0000
Message-ID: <VI1PR04MB53275100F04E35501B2786D18B890@VI1PR04MB5327.eurprd04.prod.outlook.com>
References: <20190105155847.3091-1-pakki001@umn.edu>
In-Reply-To: <20190105155847.3091-1-pakki001@umn.edu>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9cb5e457-dd4e-4632-0f91-08d67444c9de
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jan 2019 02:06:51.1604
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB6144
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

=20
>=20
> diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c
> b/drivers/usb/chipidea/ci_hdrc_msm.c
> index 880009987460..813673eee815 100644
> --- a/drivers/usb/chipidea/ci_hdrc_msm.c
> +++ b/drivers/usb/chipidea/ci_hdrc_msm.c
> @@ -250,6 +250,10 @@ static int ci_hdrc_msm_probe(struct platform_device
> *pdev)
>  	ulpi_node =3D of_get_child_by_name(pdev->dev.of_node, "ulpi");
>  	if (ulpi_node) {
>  		phy_node =3D of_get_next_available_child(ulpi_node, NULL);
> +		if (!phy_node) {
> +			ret =3D -EINVAL;
> +			goto err_mux;
> +		}

You may need to call of_node_put(ulpi_node) before goto, I commented it bef=
ore.

Peter

>  		ci->hsic =3D of_device_is_compatible(phy_node, "qcom,usb-hsic-phy");
>  		of_node_put(phy_node);
>  	}
> --
> 2.17.1