Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3468192imu; Mon, 7 Jan 2019 04:03:57 -0800 (PST) X-Google-Smtp-Source: ALg8bN7iKSd90U1VUesvOC06OviX480VzVPFVnSPeMj8x/LRsto/BuRmSkz7dxzKFGhs7wvlEERF X-Received: by 2002:a63:ce08:: with SMTP id y8mr10598320pgf.388.1546862637711; Mon, 07 Jan 2019 04:03:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546862637; cv=none; d=google.com; s=arc-20160816; b=tzbNqlGnawkcgnaDjmHyiFrg5e3RqYO7Q4O3O9kFOug3cs1sTAh8FuRaGK7l0xz6+b 5EQ1L8IpZ6mOLJS+ZEKuKZfRtQygo/b994ViTBkh9LPbsbRlM8eBi4n4jN8wBiVoE/za Rp1z41z2LGzQRboSk3v+hzKC/F2lYh30DOuYTWHJAJhh11ob3Q7be8cfsMT7eClAU1VJ Dkw2fUsf5wIzccAqt7rsWrbnopNyGQv1b1ZOz1MHZ48/x3Pleg4f2EIGydDA7SlTDvKd 26vLNsXJHTRSasrsjt1KkFRlahX8129l1XXEplkQNBxUSpd2MYQ5XCScjA/E3z6wpQ1y JcIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=GjYgixIpgFmAvJl3tK/npyP9ctWbmNMjMisqMZ0M25I=; b=p2BoYlG0IOOvTPdLmbdDECcrxiU2x7K9licUQArxLRr839DtJ7Z1UnrEoFZrRbZZxK xcXXSyU41Uz8q8/xtb+Ua8KtCosuMt4jcIeR2vsy4tZ8S5pXmtXD8G1hkVVLIoKh8eC3 z4qRUfHJh1X4TQmQTw7tbq8apZVj1kxCXEHFthZE8VQN1f5YApAdRd9elJZm/RafQke8 Ok1Jost3vtJ9NrqnwqYAlXkI6DqX03ObYKHqP9GwlDznDXXyGi7+pnA6Dihht0XLn1+/ ShZZ0TCL6/gsJrRp6xeqp8OjL+mKXOrCIURquxMpxWxhFy2BnL7sZ8WJl2TZQeO7oyPE 7XUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m2si1265847pgs.96.2019.01.07.04.03.40; Mon, 07 Jan 2019 04:03:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726651AbfAGLxg (ORCPT + 99 others); Mon, 7 Jan 2019 06:53:36 -0500 Received: from smtp.eu.citrix.com ([185.25.65.24]:63641 "EHLO SMTP.EU.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726485AbfAGLxg (ORCPT ); Mon, 7 Jan 2019 06:53:36 -0500 X-IronPort-AV: E=Sophos;i="5.56,450,1539648000"; d="scan'208";a="84221874" Date: Mon, 7 Jan 2019 12:53:25 +0100 From: Roger Pau =?utf-8?B?TW9ubsOp?= To: Dongli Zhang CC: , , , , , Subject: Re: [PATCH v4 1/2] xen/blkback: add stack variable 'blkif' in connect_ring() Message-ID: <20190107115325.nlw6irg4jgcjx6t2@mac> References: <1546839359-5478-1-git-send-email-dongli.zhang@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1546839359-5478-1-git-send-email-dongli.zhang@oracle.com> User-Agent: NeoMutt/20180716 X-ClientProxiedBy: AMSPEX02CAS02.citrite.net (10.69.22.113) To AMSPEX02CL02.citrite.net (10.69.22.126) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 07, 2019 at 01:35:58PM +0800, Dongli Zhang wrote: > As 'be->blkif' is used for many times in connect_ring(), the stack variable > 'blkif' is added to substitute 'be-blkif'. > > Suggested-by: Paul Durrant > Signed-off-by: Dongli Zhang Reviewed-by: Roger Pau Monn?