Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3495943imu; Mon, 7 Jan 2019 04:33:53 -0800 (PST) X-Google-Smtp-Source: ALg8bN6WKVc2BYzUuATRJMXFWN1GZyonV7FY4PkbW31nHXPzDIDq8dRooyZnwh1x+ZypYtcY3b04 X-Received: by 2002:a17:902:24e7:: with SMTP id l36mr61208277plg.61.1546864433723; Mon, 07 Jan 2019 04:33:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546864433; cv=none; d=google.com; s=arc-20160816; b=z8vp5Hcp5K+oFDBHv+C4hbZBUD+TD+2/I4xbrOrdEPKaEEwsugVSGhM8WNnAC4Q8Kq Zsa/GMX7EF7fPX2rKtgom7xkNhtmNOyWiGNZ7CkmngVnR2G/Z7Lzat+U6cvyke84AWcG fmqF+XP5AP+PR978bifPxODKec6dT3OIDa4//2cHz+908A/pX36a2pV2MVEF/LXJZulR aYB/HK3i4uHRR966ldAeetTEJDKrf7Jx2eKfTWtm/6uZpmP6B9tMwhe5n4bM+Dh1M9wD q5jZozzfUamkoFdsvHychD6evsZqZiAIrRAtcFWxxnt1EVzTAf/yU/cn14I4pQyRVQlO mYqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature; bh=e0fBSdAO5PjtDC0wVBHORxbqwBWBFdz5+Jgee6FFlAc=; b=o7E/DRREmolbIRoq6qucO1+nhPMJzCccLEPgzT80QxTc1XGfHljB5Uqywo5v/zxBSt ylgmWEwu1eh1AQ1Pa3zDQmENs8bDYnSljmGxS5Lj0qVVh+cgeLHPlDqYfMVJG8l/6VMk MEhL8tWSZD6HTB1d1iUl3OyHE2oQ6thSEGCUIrhMbKqGUSj4RgzX3SAofcc0tHITlNJl gbsuT2sbB420nxvTCg16h5iRHPl2iakDXeQZiSw14sXjR0I6eVgZiT1VuId3w4JPacGY WK9jFGHHyjDBHSRxSORwXr3dTHwmOI8x2fzMdLMNxvROp3CUt5WIwp1xzXVJHRHDLkmX BNaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=OqNgnMLm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q32si61568952pgm.410.2019.01.07.04.33.37; Mon, 07 Jan 2019 04:33:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=OqNgnMLm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726938AbfAGMbJ (ORCPT + 99 others); Mon, 7 Jan 2019 07:31:09 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:39954 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726521AbfAGMbJ (ORCPT ); Mon, 7 Jan 2019 07:31:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=e0fBSdAO5PjtDC0wVBHORxbqwBWBFdz5+Jgee6FFlAc=; b=OqNgnMLmepCD E9rKkXX7RUHiGlsC30gy7t8Ixs+T4mNgnGHK83GQPBOOcu46808xI1DHPvdkdDo+RhIUQOoDpdHzh 8RrQRa5T7qD3HMwtJXydSXdwK3erngsE0FK8IJb5kcBz+v+BSqazVcXZunXOg5vOMpAF2itkGCygc renyI=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1ggU3b-0006lK-9B; Mon, 07 Jan 2019 12:31:03 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id D557A1127491; Mon, 7 Jan 2019 12:31:02 +0000 (GMT) From: Mark Brown To: Katsuhiro Suzuki Cc: Mark Brown , Mark Brown , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org Subject: Applied "ASoC: rockchip: add workaround for silence of rk3288 ACODEC" to the asoc tree In-Reply-To: <20181220153636.5213-2-katsuhiro@katsuster.net> X-Patchwork-Hint: ignore Message-Id: <20190107123102.D557A1127491@debutante.sirena.org.uk> Date: Mon, 7 Jan 2019 12:31:02 +0000 (GMT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch ASoC: rockchip: add workaround for silence of rk3288 ACODEC has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From f5758544d98c8bec7793aeea28928f5e8bd45d47 Mon Sep 17 00:00:00 2001 From: Katsuhiro Suzuki Date: Fri, 21 Dec 2018 00:36:36 +0900 Subject: [PATCH] ASoC: rockchip: add workaround for silence of rk3288 ACODEC This patch adds reset and precharge in shutdown of PCM device. ACODEC goes to silence if we change Fs to 44.1kHz from 48kHz. This workaround seems to work but I don't know this workaround is correct sequence or not for ACODEC. Signed-off-by: Katsuhiro Suzuki Signed-off-by: Mark Brown --- sound/soc/codecs/rk3328_codec.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/rk3328_codec.c b/sound/soc/codecs/rk3328_codec.c index 71f3fc2d970c..f3442a2283ea 100644 --- a/sound/soc/codecs/rk3328_codec.c +++ b/sound/soc/codecs/rk3328_codec.c @@ -261,9 +261,12 @@ static int rk3328_codec_close_playback(struct rk3328_codec_priv *rk3328) mdelay(1); } + /* Workaround for silence when changed Fs 48 -> 44.1kHz */ + rk3328_codec_reset(rk3328); + regmap_update_bits(rk3328->regmap, DAC_PRECHARGE_CTRL, DAC_CHARGE_CURRENT_ALL_MASK, - DAC_CHARGE_CURRENT_I); + DAC_CHARGE_CURRENT_ALL_ON); return 0; } -- 2.20.1