Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3500278imu; Mon, 7 Jan 2019 04:38:33 -0800 (PST) X-Google-Smtp-Source: ALg8bN7rHTHNdzasH/RYUXWH+6+P71gme1NYh7uhF6DnNW9NiMFjGPhv24v/rT0A0KTKUPhWypmz X-Received: by 2002:a17:902:66e6:: with SMTP id e93mr14638756plk.92.1546864713585; Mon, 07 Jan 2019 04:38:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546864713; cv=none; d=google.com; s=arc-20160816; b=r1ha6bme9VAhY8duK4GxyZAYsT5nOBdxRWvNwpNF6NyU76KMDnUQFdIYSnQpfnhpvA j8O9nmNWjQ48QaBSeCW3mHuBFLwOe8t602tWuUzHGPNFYCs1zPhA8DabkOGc4AgzWRrZ z4Xsbm0oZJ8y4TQ3bKvic/hdFMLBPAbdM+qn9i3NVp0CcN4VrtDh/mR1zZs+7k9np9Kt 4Q8ZQybSZghflV5LBmkjKkOfn7LI+T0ib906EqreNiAeWsDfevlLHGJ98yZzJwwqL3Dx 3YpTs5htCiffiBEW6BTHbfLWBEUG28ki4GDnqVggwkTnD9Hi7uaekE2+a/UPgz0jpE5H 4Srg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=x4EQUTQ7081V6IlIwVnRvQlGejh6igmkcXnxpU/ji/w=; b=j0IHp94JdbguSev5MgzIV7uWYm0V3DejqOWvtF9kVEGa7abc1xpMkp4WD8/SG01HUv rBw6+KKnS77iNa/OuWx7ekv8fGBhDrr6S7qlNebrj8g/5DkqOoKd9flNuBX1NrtVvvWg ygQBZqu0ZkPOXcGBSSbApL9FYirLRRpUBy7HvDoudmHAEcGdBxUTTZnEjudx1bEym+DM xifxSdorDd5gzUNcDjux+k6/lGJE8FSNu0NqyaqMVGjwuHnJMG2aV95oelC/+OWIEQPA A1KQuRVVmwylwgmRT8GA6suosbOaEeal5Jivzy7aprInulLjZxAcDVyUJ02UUHimpFbf 6YWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=osqWPGTq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n34si53320899pld.381.2019.01.07.04.38.18; Mon, 07 Jan 2019 04:38:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=osqWPGTq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727653AbfAGMf5 (ORCPT + 99 others); Mon, 7 Jan 2019 07:35:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:50332 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727182AbfAGMfz (ORCPT ); Mon, 7 Jan 2019 07:35:55 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7294D218AD; Mon, 7 Jan 2019 12:35:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546864555; bh=GxRqCTkHQ1OeMbR4nuuXhqIClCNiFebthZZ9DA6OSNA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=osqWPGTqPT6UyOphknijjeciZp5Yyj2JqMNZ5bdill7h2AxeJPeJGn26FxSlvvHXc 2bxoiGrTx/GzOkxd58hL5OG6RzBNZOkWIFdn8nqCXnNcLN6hDFTi11slXPyXaKdGx4 LHFZ8rjqp2KeN7JjMALWjSbakvABkqdr6XZ39d8A= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Takashi Iwai Subject: [PATCH 4.20 048/145] staging: bcm2835-audio: double free in init error path Date: Mon, 7 Jan 2019 13:31:25 +0100 Message-Id: <20190107104443.713804379@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190107104437.308206189@linuxfoundation.org> References: <20190107104437.308206189@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.20-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dan Carpenter commit 649496b603000135683ee76d7ea499456617bf17 upstream. We free instance here and in the caller. It should be only the caller which handles it. Fixes: d7ca3a71545b ("staging: bcm2835-audio: Operate non-atomic PCM ops") Signed-off-by: Dan Carpenter Reviewed-by: Takashi Iwai Cc: stable Signed-off-by: Greg Kroah-Hartman --- drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c +++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c @@ -143,7 +143,6 @@ vc_vchi_audio_init(VCHI_INSTANCE_T vchi_ dev_err(instance->dev, "failed to open VCHI service connection (status=%d)\n", status); - kfree(instance); return -EPERM; }